Calculate client stats also if the span kind is eligible #9157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section tracing Agent [baseline] (996.134 ms) : 0, 996134 Total [baseline] (10.595 s) : 0, 10594892 Agent [candidate] (994.613 ms) : 0, 994613 Total [candidate] (10.552 s) : 0, 10551901 section appsec Agent [baseline] (1.176 s) : 0, 1175673 Total [baseline] (10.785 s) : 0, 10784918 Agent [candidate] (1.18 s) : 0, 1179794 Total [candidate] (10.827 s) : 0, 10827248 section iast Agent [baseline] (1.139 s) : 0, 1138686 Total [baseline] (10.968 s) : 0, 10967726 Agent [candidate] (1.135 s) : 0, 1134563 Total [candidate] (10.852 s) : 0, 10852262 section profiling Agent [baseline] (1.253 s) : 0, 1253285 Total [baseline] (11.122 s) : 0, 11122289 Agent [candidate] (1.247 s) : 0, 1247390 Total [candidate] (11.009 s) : 0, 11009253
gantt title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (687.886 ms) : 0, 687886 BytebuddyAgent [candidate] (686.327 ms) : 0, 686327 GlobalTracer [baseline] (242.291 ms) : 0, 242291 GlobalTracer [candidate] (242.497 ms) : 0, 242497 AppSec [baseline] (30.308 ms) : 0, 30308 AppSec [candidate] (30.16 ms) : 0, 30160 Debugger [baseline] (6.0 ms) : 0, 6000 Debugger [candidate] (5.958 ms) : 0, 5958 Remote Config [baseline] (680.516 µs) : 0, 681 Remote Config [candidate] (672.775 µs) : 0, 673 Telemetry [baseline] (8.179 ms) : 0, 8179 Telemetry [candidate] (8.21 ms) : 0, 8210 section appsec BytebuddyAgent [baseline] (710.174 ms) : 0, 710174 BytebuddyAgent [candidate] (713.287 ms) : 0, 713287 GlobalTracer [baseline] (235.491 ms) : 0, 235491 GlobalTracer [candidate] (235.975 ms) : 0, 235975 IAST [baseline] (23.625 ms) : 0, 23625 IAST [candidate] (23.658 ms) : 0, 23658 AppSec [baseline] (171.125 ms) : 0, 171125 AppSec [candidate] (171.545 ms) : 0, 171545 Debugger [baseline] (5.714 ms) : 0, 5714 Debugger [candidate] (5.736 ms) : 0, 5736 Remote Config [baseline] (609.816 µs) : 0, 610 Remote Config [candidate] (602.017 µs) : 0, 602 Telemetry [baseline] (8.01 ms) : 0, 8010 Telemetry [candidate] (8.057 ms) : 0, 8057 section iast BytebuddyAgent [baseline] (811.747 ms) : 0, 811747 BytebuddyAgent [candidate] (808.993 ms) : 0, 808993 GlobalTracer [baseline] (233.734 ms) : 0, 233734 GlobalTracer [candidate] (232.627 ms) : 0, 232627 IAST [baseline] (27.35 ms) : 0, 27350 IAST [candidate] (29.823 ms) : 0, 29823 AppSec [baseline] (30.532 ms) : 0, 30532 AppSec [candidate] (28.022 ms) : 0, 28022 Debugger [baseline] (5.772 ms) : 0, 5772 Debugger [candidate] (5.728 ms) : 0, 5728 Remote Config [baseline] (578.915 µs) : 0, 579 Remote Config [candidate] (575.995 µs) : 0, 576 Telemetry [baseline] (7.926 ms) : 0, 7926 Telemetry [candidate] (7.953 ms) : 0, 7953 section profiling BytebuddyAgent [baseline] (682.955 ms) : 0, 682955 BytebuddyAgent [candidate] (679.207 ms) : 0, 679207 GlobalTracer [baseline] (363.613 ms) : 0, 363613 GlobalTracer [candidate] (362.301 ms) : 0, 362301 AppSec [baseline] (33.804 ms) : 0, 33804 AppSec [candidate] (32.382 ms) : 0, 32382 Debugger [baseline] (10.05 ms) : 0, 10050 Debugger [candidate] (11.365 ms) : 0, 11365 Remote Config [baseline] (670.132 µs) : 0, 670 Remote Config [candidate] (673.069 µs) : 0, 673 Telemetry [baseline] (8.76 ms) : 0, 8760 Telemetry [candidate] (8.019 ms) : 0, 8019 ProfilingAgent [baseline] (104.396 ms) : 0, 104396 ProfilingAgent [candidate] (104.081 ms) : 0, 104081 Profiling [baseline] (104.42 ms) : 0, 104420 Profiling [candidate] (104.106 ms) : 0, 104106 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section tracing Agent [baseline] (995.455 ms) : 0, 995455 Total [baseline] (8.588 s) : 0, 8587801 Agent [candidate] (1.0 s) : 0, 1000446 Total [candidate] (8.582 s) : 0, 8582446 section iast Agent [baseline] (1.133 s) : 0, 1133333 Total [baseline] (9.255 s) : 0, 9255437 Agent [candidate] (1.132 s) : 0, 1131705 Total [candidate] (9.268 s) : 0, 9267662
gantt title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (686.978 ms) : 0, 686978 BytebuddyAgent [candidate] (691.738 ms) : 0, 691738 GlobalTracer [baseline] (242.259 ms) : 0, 242259 GlobalTracer [candidate] (242.816 ms) : 0, 242816 AppSec [baseline] (30.403 ms) : 0, 30403 AppSec [candidate] (30.099 ms) : 0, 30099 Debugger [baseline] (6.036 ms) : 0, 6036 Debugger [candidate] (5.946 ms) : 0, 5946 Remote Config [baseline] (687.319 µs) : 0, 687 Remote Config [candidate] (675.81 µs) : 0, 676 Telemetry [baseline] (8.218 ms) : 0, 8218 Telemetry [candidate] (8.231 ms) : 0, 8231 section iast BytebuddyAgent [baseline] (807.405 ms) : 0, 807405 BytebuddyAgent [candidate] (807.069 ms) : 0, 807069 GlobalTracer [baseline] (232.581 ms) : 0, 232581 GlobalTracer [candidate] (232.432 ms) : 0, 232432 IAST [baseline] (25.748 ms) : 0, 25748 IAST [candidate] (29.557 ms) : 0, 29557 AppSec [baseline] (31.758 ms) : 0, 31758 AppSec [candidate] (27.721 ms) : 0, 27721 Debugger [baseline] (6.551 ms) : 0, 6551 Debugger [candidate] (5.718 ms) : 0, 5718 Remote Config [baseline] (565.308 µs) : 0, 565 Remote Config [candidate] (572.702 µs) : 0, 573 Telemetry [baseline] (7.918 ms) : 0, 7918 Telemetry [candidate] (7.913 ms) : 0, 7913 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section baseline no_agent (37.832 ms) : 37513, 38151 . : milestone, 37832, appsec (47.772 ms) : 47344, 48200 . : milestone, 47772, code_origins (46.341 ms) : 45951, 46730 . : milestone, 46341, iast (44.513 ms) : 44121, 44904 . : milestone, 44513, profiling (51.077 ms) : 50603, 51551 . : milestone, 51077, tracing (43.946 ms) : 43579, 44313 . : milestone, 43946, section candidate no_agent (36.858 ms) : 36558, 37157 . : milestone, 36858, appsec (46.992 ms) : 46573, 47411 . : milestone, 46992, code_origins (45.634 ms) : 45233, 46036 . : milestone, 45634, iast (42.651 ms) : 42288, 43014 . : milestone, 42651, profiling (49.794 ms) : 49315, 50274 . : milestone, 49794, tracing (44.357 ms) : 43981, 44734 . : milestone, 44357,
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section baseline no_agent (4.303 ms) : 4255, 4351 . : milestone, 4303, iast (9.338 ms) : 9184, 9491 . : milestone, 9338, iast_FULL (14.403 ms) : 14117, 14689 . : milestone, 14403, iast_GLOBAL (10.161 ms) : 9981, 10341 . : milestone, 10161, profiling (8.797 ms) : 8646, 8948 . : milestone, 8797, tracing (7.631 ms) : 7516, 7746 . : milestone, 7631, section candidate no_agent (4.495 ms) : 4431, 4558 . : milestone, 4495, iast (9.645 ms) : 9488, 9803 . : milestone, 9645, iast_FULL (14.025 ms) : 13748, 14302 . : milestone, 14025, iast_GLOBAL (10.271 ms) : 10090, 10452 . : milestone, 10271, profiling (8.594 ms) : 8455, 8734 . : milestone, 8594, tracing (7.416 ms) : 7308, 7523 . : milestone, 7416,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section baseline no_agent (15.477 s) : 15477000, 15477000 . : milestone, 15477000, appsec (14.671 s) : 14671000, 14671000 . : milestone, 14671000, iast (18.537 s) : 18537000, 18537000 . : milestone, 18537000, iast_GLOBAL (17.823 s) : 17823000, 17823000 . : milestone, 17823000, profiling (15.738 s) : 15738000, 15738000 . : milestone, 15738000, tracing (14.901 s) : 14901000, 14901000 . : milestone, 14901000, section candidate no_agent (15.336 s) : 15336000, 15336000 . : milestone, 15336000, appsec (14.727 s) : 14727000, 14727000 . : milestone, 14727000, iast (18.392 s) : 18392000, 18392000 . : milestone, 18392000, iast_GLOBAL (17.972 s) : 17972000, 17972000 . : milestone, 17972000, profiling (15.171 s) : 15171000, 15171000 . : milestone, 15171000, tracing (14.739 s) : 14739000, 14739000 . : milestone, 14739000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~316c552bf7, baseline=1.52.0-SNAPSHOT~ad6d6b9786 dateFormat X axisFormat %s section baseline no_agent (1.486 ms) : 1474, 1497 . : milestone, 1486, appsec (2.423 ms) : 2373, 2473 . : milestone, 2423, iast (2.207 ms) : 2144, 2270 . : milestone, 2207, iast_GLOBAL (2.247 ms) : 2184, 2310 . : milestone, 2247, profiling (2.534 ms) : 2356, 2713 . : milestone, 2534, tracing (2.031 ms) : 1982, 2079 . : milestone, 2031, section candidate no_agent (1.483 ms) : 1472, 1495 . : milestone, 1483, appsec (2.424 ms) : 2374, 2474 . : milestone, 2424, iast (2.213 ms) : 2151, 2276 . : milestone, 2213, iast_GLOBAL (2.25 ms) : 2187, 2313 . : milestone, 2250, profiling (2.042 ms) : 1992, 2092 . : milestone, 2042, tracing (2.03 ms) : 1981, 2080 . : milestone, 2030,
|
bric3 approved these changes Jul 11, 2025
Comment on lines +305 to +307
| span_kinds instanceof List | ||
| ? unmodifiableSet(new HashSet<>((List<String>) span_kinds)) | ||
| : emptySet(); |
There was a problem hiding this comment.
praise: Indeed that's better to use an instance check if the paylaod ever changes 👍
mhlidd pushed a commit that referenced this pull request Jul 17, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Aug 5, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#​4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#​4218](redis/jedis#4218)) - Add support for new stream commands ([#​4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#​4188](redis/jedis#4188)) ([#​4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#​3566](redis/jedis#3566)) ([#​4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#​4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#​4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#​4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#​4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#​4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#​4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#​4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#​4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#​4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#​4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#​4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#​4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#​4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#​4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#​4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#​4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#​4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#​3617](redis/jedis#3617)) - Add retryable command execution example ([#​3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#​4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#​4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​219sansim](https://github.com/219sansim), [@​YoHanKi](https://github.com/YoHanKi), [@​andy-stark-redis](https://github.com/andy-stark-redis), [@​ggivo](https://github.com/ggivo), [@​jujn](https://github.com/jujn), [@​thachlp](https://github.com/thachlp), [@​uglide](https://github.com/uglide) and [@​xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#​3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#​3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#​3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#​3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#​3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#​3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#​3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#​9260](DataDog/dd-trace-java#9260) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9165](DataDog/dd-trace-java#9165) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#​9275](DataDog/dd-trace-java#9275) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#​9257](DataDog/dd-trace-java#9257) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#​9256](DataDog/dd-trace-java#9256) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#​9235](DataDog/dd-trace-java#9235) - [@​daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#​9210](DataDog/dd-trace-java#9210) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#​9145](DataDog/dd-trace-java#9145) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#​9151](DataDog/dd-trace-java#9151) - [@​kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#​9137](DataDog/dd-trace-java#9137) - [@​kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#​9285](DataDog/dd-trace-java#9285) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#​9271](DataDog/dd-trace-java#9271) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#​9245](DataDog/dd-trace-java#9245) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#​9205](DataDog/dd-trace-java#9205) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#​9297](DataDog/dd-trace-java#9297) - [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#​9196](DataDog/dd-trace-java#9196) - [@​amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#​9157](DataDog/dd-trace-java#9157) - [@​amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#​9144](DataDog/dd-trace-java#9144) - [@​bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#​9136](DataDog/dd-trace-java#9136) - [@​amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#​9255](DataDog/dd-trace-java#9255) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#​9293](DataDog/dd-trace-java#9293) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#​9262](DataDog/dd-trace-java#9262) - [@​zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#​9130](DataDog/dd-trace-java#9130) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#​9146](DataDog/dd-trace-java#9146) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#​8589](DataDog/dd-trace-java#8589) - [@​dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#​9201](DataDog/dd-trace-java#9201) - [@​paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#​9197](DataDog/dd-trace-java#9197) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#​9190](DataDog/dd-trace-java#9190) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#​9185](DataDog/dd-trace-java#9185) - [@​sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#​9173](DataDog/dd-trace-java#9173) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#​9170](DataDog/dd-trace-java#9170) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#​9169](DataDog/dd-trace-java#9169) - [@​rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#​9161](DataDog/dd-trace-java#9161) - [@​mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#​9156](DataDog/dd-trace-java#9156) - [@​amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#​9135](DataDog/dd-trace-java#9135) - [@​amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#​9203](DataDog/dd-trace-java#9203) - [@​zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#​9246](DataDog/dd-trace-java#9246) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
The datadog agent already calculates the stats not only if the span is top level or measured but also if its span kind is among the one eligible.
Those span kinds are returned by the agent through the info endpoint response.
This PR enable including span with eligible kind in the stats computation
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]