- Notifications
You must be signed in to change notification settings - Fork 314
Make client stats reliable in case of downgrade #9136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section tracing Agent [baseline] (993.315 ms) : 0, 993315 Total [baseline] (8.566 s) : 0, 8566070 Agent [candidate] (995.489 ms) : 0, 995489 Total [candidate] (8.532 s) : 0, 8532339 section iast Agent [baseline] (1.13 s) : 0, 1130101 Total [baseline] (9.292 s) : 0, 9292094 Agent [candidate] (1.141 s) : 0, 1141073 Total [candidate] (9.305 s) : 0, 9304586
gantt title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (685.926 ms) : 0, 685926 BytebuddyAgent [candidate] (687.932 ms) : 0, 687932 GlobalTracer [baseline] (241.479 ms) : 0, 241479 GlobalTracer [candidate] (241.821 ms) : 0, 241821 AppSec [baseline] (30.259 ms) : 0, 30259 AppSec [candidate] (30.142 ms) : 0, 30142 Debugger [baseline] (5.962 ms) : 0, 5962 Debugger [candidate] (5.977 ms) : 0, 5977 Remote Config [baseline] (677.899 µs) : 0, 678 Remote Config [candidate] (674.159 µs) : 0, 674 Telemetry [baseline] (8.245 ms) : 0, 8245 Telemetry [candidate] (8.241 ms) : 0, 8241 section iast BytebuddyAgent [baseline] (805.668 ms) : 0, 805668 BytebuddyAgent [candidate] (814.548 ms) : 0, 814548 GlobalTracer [baseline] (231.395 ms) : 0, 231395 GlobalTracer [candidate] (233.322 ms) : 0, 233322 IAST [baseline] (25.389 ms) : 0, 25389 IAST [candidate] (27.203 ms) : 0, 27203 AppSec [baseline] (32.604 ms) : 0, 32604 AppSec [candidate] (30.11 ms) : 0, 30110 Debugger [baseline] (5.772 ms) : 0, 5772 Debugger [candidate] (6.577 ms) : 0, 6577 Remote Config [baseline] (572.136 µs) : 0, 572 Remote Config [candidate] (573.88 µs) : 0, 574 Telemetry [baseline] (8.003 ms) : 0, 8003 Telemetry [candidate] (7.94 ms) : 0, 7940 Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section tracing Agent [baseline] (992.594 ms) : 0, 992594 Total [baseline] (10.688 s) : 0, 10687755 Agent [candidate] (994.149 ms) : 0, 994149 Total [candidate] (10.628 s) : 0, 10628010 section appsec Agent [baseline] (1.184 s) : 0, 1184201 Total [baseline] (10.923 s) : 0, 10922743 Agent [candidate] (1.172 s) : 0, 1171558 Total [candidate] (10.691 s) : 0, 10690540 section iast Agent [baseline] (1.13 s) : 0, 1129551 Total [baseline] (10.851 s) : 0, 10850907 Agent [candidate] (1.151 s) : 0, 1150727 Total [candidate] (10.811 s) : 0, 10810731 section profiling Agent [baseline] (1.245 s) : 0, 1245215 Total [baseline] (10.994 s) : 0, 10994174 Agent [candidate] (1.24 s) : 0, 1239820 Total [candidate] (10.943 s) : 0, 10942945
gantt title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (685.375 ms) : 0, 685375 BytebuddyAgent [candidate] (686.682 ms) : 0, 686682 GlobalTracer [baseline] (241.65 ms) : 0, 241650 GlobalTracer [candidate] (241.68 ms) : 0, 241680 AppSec [baseline] (30.066 ms) : 0, 30066 AppSec [candidate] (30.206 ms) : 0, 30206 Debugger [baseline] (5.931 ms) : 0, 5931 Debugger [candidate] (5.994 ms) : 0, 5994 Remote Config [baseline] (671.208 µs) : 0, 671 Remote Config [candidate] (671.666 µs) : 0, 672 Telemetry [baseline] (8.174 ms) : 0, 8174 Telemetry [candidate] (8.164 ms) : 0, 8164 section appsec BytebuddyAgent [baseline] (714.875 ms) : 0, 714875 BytebuddyAgent [candidate] (708.811 ms) : 0, 708811 GlobalTracer [baseline] (237.875 ms) : 0, 237875 GlobalTracer [candidate] (234.33 ms) : 0, 234330 IAST [baseline] (23.697 ms) : 0, 23697 IAST [candidate] (23.191 ms) : 0, 23191 AppSec [baseline] (172.322 ms) : 0, 172322 AppSec [candidate] (170.107 ms) : 0, 170107 Debugger [baseline] (5.72 ms) : 0, 5720 Debugger [candidate] (5.681 ms) : 0, 5681 Remote Config [baseline] (614.923 µs) : 0, 615 Remote Config [candidate] (591.972 µs) : 0, 592 Telemetry [baseline] (8.124 ms) : 0, 8124 Telemetry [candidate] (8.051 ms) : 0, 8051 section iast BytebuddyAgent [baseline] (805.229 ms) : 0, 805229 BytebuddyAgent [candidate] (822.565 ms) : 0, 822565 GlobalTracer [baseline] (231.657 ms) : 0, 231657 GlobalTracer [candidate] (233.969 ms) : 0, 233969 IAST [baseline] (26.938 ms) : 0, 26938 IAST [candidate] (30.053 ms) : 0, 30053 AppSec [baseline] (30.668 ms) : 0, 30668 AppSec [candidate] (27.804 ms) : 0, 27804 Debugger [baseline] (5.764 ms) : 0, 5764 Debugger [candidate] (5.851 ms) : 0, 5851 Remote Config [baseline] (588.38 µs) : 0, 588 Remote Config [candidate] (600.772 µs) : 0, 601 Telemetry [baseline] (7.925 ms) : 0, 7925 Telemetry [candidate] (8.05 ms) : 0, 8050 section profiling BytebuddyAgent [baseline] (678.988 ms) : 0, 678988 BytebuddyAgent [candidate] (675.609 ms) : 0, 675609 GlobalTracer [baseline] (361.255 ms) : 0, 361255 GlobalTracer [candidate] (360.027 ms) : 0, 360027 AppSec [baseline] (33.843 ms) : 0, 33843 AppSec [candidate] (31.592 ms) : 0, 31592 Debugger [baseline] (10.572 ms) : 0, 10572 Debugger [candidate] (10.521 ms) : 0, 10521 Remote Config [baseline] (666.695 µs) : 0, 667 Remote Config [candidate] (655.627 µs) : 0, 656 Telemetry [baseline] (7.964 ms) : 0, 7964 Telemetry [candidate] (10.158 ms) : 0, 10158 ProfilingAgent [baseline] (103.027 ms) : 0, 103027 ProfilingAgent [candidate] (102.844 ms) : 0, 102844 Profiling [baseline] (103.051 ms) : 0, 103051 Profiling [candidate] (102.867 ms) : 0, 102867 LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section baseline no_agent (4.285 ms) : 4232, 4339 . : milestone, 4285, iast (9.318 ms) : 9152, 9484 . : milestone, 9318, iast_FULL (14.377 ms) : 14091, 14664 . : milestone, 14377, iast_GLOBAL (10.54 ms) : 10357, 10724 . : milestone, 10540, profiling (8.534 ms) : 8402, 8666 . : milestone, 8534, tracing (7.651 ms) : 7542, 7760 . : milestone, 7651, section candidate no_agent (4.406 ms) : 4349, 4463 . : milestone, 4406, iast (9.457 ms) : 9303, 9611 . : milestone, 9457, iast_FULL (13.957 ms) : 13683, 14231 . : milestone, 13957, iast_GLOBAL (10.789 ms) : 10598, 10980 . : milestone, 10789, profiling (8.724 ms) : 8583, 8866 . : milestone, 8724, tracing (7.682 ms) : 7572, 7791 . : milestone, 7682,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section baseline no_agent (37.623 ms) : 37318, 37928 . : milestone, 37623, appsec (48.905 ms) : 48479, 49331 . : milestone, 48905, code_origins (44.686 ms) : 44313, 45059 . : milestone, 44686, iast (43.919 ms) : 43532, 44305 . : milestone, 43919, profiling (51.998 ms) : 51501, 52495 . : milestone, 51998, tracing (45.061 ms) : 44691, 45431 . : milestone, 45061, section candidate no_agent (38.003 ms) : 37698, 38308 . : milestone, 38003, appsec (47.893 ms) : 47469, 48318 . : milestone, 47893, code_origins (44.724 ms) : 44349, 45098 . : milestone, 44724, iast (46.215 ms) : 45794, 46636 . : milestone, 46215, profiling (47.692 ms) : 47237, 48147 . : milestone, 47692, tracing (44.391 ms) : 44021, 44762 . : milestone, 44391,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section baseline no_agent (15.132 s) : 15132000, 15132000 . : milestone, 15132000, appsec (14.832 s) : 14832000, 14832000 . : milestone, 14832000, iast (18.489 s) : 18489000, 18489000 . : milestone, 18489000, iast_GLOBAL (18.02 s) : 18020000, 18020000 . : milestone, 18020000, profiling (15.101 s) : 15101000, 15101000 . : milestone, 15101000, tracing (15.002 s) : 15002000, 15002000 . : milestone, 15002000, section candidate no_agent (14.836 s) : 14836000, 14836000 . : milestone, 14836000, appsec (14.616 s) : 14616000, 14616000 . : milestone, 14616000, iast (18.26 s) : 18260000, 18260000 . : milestone, 18260000, iast_GLOBAL (18.471 s) : 18471000, 18471000 . : milestone, 18471000, profiling (15.03 s) : 15030000, 15030000 . : milestone, 15030000, tracing (14.934 s) : 14934000, 14934000 . : milestone, 14934000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~fd30bcf899, baseline=1.52.0-SNAPSHOT~54c1853735 dateFormat X axisFormat %s section baseline no_agent (1.481 ms) : 1469, 1492 . : milestone, 1481, appsec (2.413 ms) : 2363, 2462 . : milestone, 2413, iast (2.202 ms) : 2140, 2264 . : milestone, 2202, iast_GLOBAL (2.237 ms) : 2174, 2299 . : milestone, 2237, profiling (2.502 ms) : 2328, 2676 . : milestone, 2502, tracing (2.019 ms) : 1971, 2068 . : milestone, 2019, section candidate no_agent (1.48 ms) : 1468, 1492 . : milestone, 1480, appsec (2.419 ms) : 2369, 2469 . : milestone, 2419, iast (2.196 ms) : 2134, 2258 . : milestone, 2196, iast_GLOBAL (2.246 ms) : 2183, 2308 . : milestone, 2246, profiling (2.067 ms) : 2015, 2119 . : milestone, 2067, tracing (2.012 ms) : 1963, 2060 . : milestone, 2012,
|
mcculls approved these changes Jul 9, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Aug 5, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [redis.clients:jedis](https://github.com/redis/jedis) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.0.0` -> `6.1.0` | | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.59.2` -> `2.60.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.2` -> `2.59.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.68.2` -> `2.69.0` | | [com.squareup.wire](https://github.com/square/wire) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-schema](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-runtime](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-reflector](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-moshi-adapter](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-grpc-client](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.squareup.wire:wire-bom](https://github.com/square/wire) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `5.3.5` -> `5.3.6` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.51.2` -> `1.52.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.14` -> `2.32.15` | --- ### Release Notes <details> <summary>redis/jedis (redis.clients:jedis)</summary> ### [`v6.1.0`](https://github.com/redis/jedis/releases/tag/v6.1.0): 6.1.0 ### Changes #### 🚀 New Features - Add support for SVS-VAMANA vector indexing ([#​4222](redis/jedis#4222)) - Clarify why new stream entries aren't deleted with XDELEX ([#​4218](redis/jedis#4218)) - Add support for new stream commands ([#​4211](redis/jedis#4211)) - Add Support for New BITOP Operations in Redis 8.2 ([#​4188](redis/jedis#4188)) ([#​4190](redis/jedis#4190)) - Add binary stream support for XREAD and XREADGROUP ([#​3566](redis/jedis#3566)) ([#​4152](redis/jedis#4152)) - Run pipeline in current thread if all the keys on same node ([#​4149](redis/jedis#4149)) #### 🐛 Bug Fixes - Restore binary compatibility of SetParams ([#​4225](redis/jedis#4225)) - Fix memory leak in JedisClusterInfoCache - replica nodes not cleared ([#​4205](redis/jedis#4205)) - Fix:JedisCluster throws NullPointerException when maxAttempts is set to 0 ([#​4186](redis/jedis#4186)) #### 🧰 Maintenance - DOC-5471 time series doc examples ([#​4210](redis/jedis#4210)) - Bump jackson.version from 2.19.1 to 2.19.2 ([#​4208](redis/jedis#4208)) - Fix flaky test ClientCommandsTest.killSkipmeYesNo ([#​4206](redis/jedis#4206)) - Bump org.junit:junit-bom from 5.13.2 to 5.13.3 ([#​4198](redis/jedis#4198)) - Migrate publishing to Maven Central Portal ([#​4199](redis/jedis#4199)) - Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.7 to 3.2.8 ([#​4197](redis/jedis#4197)) - Bump org.junit:junit-bom from 5.13.1 to 5.13.2 ([#​4192](redis/jedis#4192)) - DOC-5227 added probabilistic data type examples ([#​4184](redis/jedis#4184)) - Bump jackson.version from 2.19.0 to 2.19.1 ([#​4180](redis/jedis#4180)) - Update test infra to use latest Redis ([#​4179](redis/jedis#4179)) - Bump org.junit:junit-bom from 5.13.0-RC1 to 5.13.1 ([#​4174](redis/jedis#4174)) - Bump org.json:json from [`2025010`](redis/jedis@20250107) to [`2025051`](redis/jedis@20250517) ([#​4171](redis/jedis#4171)) - Bump org.apache.httpcomponents.client5:httpclient5-fluent from 5.4.4 to 5.5 ([#​4170](redis/jedis#4170)) - Fix flaky tests in DocumentTest ([#​3617](redis/jedis#3617)) - Add retryable command execution example ([#​3780](redis/jedis#3780)) - Bump jackson.version from 2.18.3 to 2.19.0 ([#​4160](redis/jedis#4160)) - Bump com.google.code.gson:gson from 2.12.1 to 2.13.1 ([#​4161](redis/jedis#4161)) #### Contributors We'd like to thank all the contributors who worked on this release! [@​219sansim](https://github.com/219sansim), [@​YoHanKi](https://github.com/YoHanKi), [@​andy-stark-redis](https://github.com/andy-stark-redis), [@​ggivo](https://github.com/ggivo), [@​jujn](https://github.com/jujn), [@​thachlp](https://github.com/thachlp), [@​uglide](https://github.com/uglide) and [@​xrayw](https://github.com/xrayw) </details> <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.60.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2600-2025-06-23) ##### Features - handle auto pagination for BigQuery v2 ([#​3829](googleapis/sdk-platform-java#3829)) ([025c84c](googleapis/sdk-platform-java@025c84c)) ##### Dependencies - update google auth library dependencies to v1.37.1 ([#​3846](googleapis/sdk-platform-java#3846)) ([ea1d9e5](googleapis/sdk-platform-java@ea1d9e5)) - update google http client dependencies to v1.47.1 ([#​3848](googleapis/sdk-platform-java#3848)) ([a9a39d7](googleapis/sdk-platform-java@a9a39d7)) </details> <details> <summary>square/wire (com.squareup.wire)</summary> ### [`v5.3.6`](https://github.com/square/wire/blob/HEAD/CHANGELOG.md#Version-536) [Compare Source](square/wire@5.3.5...5.3.6) *2025-08-05* ##### CLI - New CLI option `--ignore_unused_roots_and_prunes` ([#​3354](square/wire#3354)) ##### JVM - Fix: Handle negative hexadecimal in default values ([#​3355](square/wire#3355)) - Optimization: Avoid copying of repeated and map types when mutableTypes are being used ([#​3352](square/wire#3352) by \[Rahul Ravikumar]\[tikurahul]) ##### Swift - Fix: Properly disambiguate OneOf enum if it has the same name as enclosing type ([#​3350](square/wire#3350) by \[Dimitris Koutsogiorgas]\[dnkoutso]) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.52.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.52.0): 1.52.0 ### Components #### Application Security Management (WAF) - ✨ Only report ASM\_DD, ASM\_DATA and ASM capabilities when AppSec is enabled ([#​9260](DataDog/dd-trace-java#9260) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9165](DataDog/dd-trace-java#9165) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Build & Tooling - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Configuration at Runtime - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Continuous Integration Visibility - ✨ Update GitLab provided tags ([#​9275](DataDog/dd-trace-java#9275) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Fix base branch SHA usage in GitHub Actions ([#​9257](DataDog/dd-trace-java#9257) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add `ci.job.id` tag ([#​9256](DataDog/dd-trace-java#9256) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add new org to Weaver instrumentation ([#​9235](DataDog/dd-trace-java#9235) - [@​daniel-mohedano](https://github.com/daniel-mohedano) - thanks for the contribution!) - ✨ Improve Git commit info building ([#​9210](DataDog/dd-trace-java#9210) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update Attempt to Fix to v5 ([#​9145](DataDog/dd-trace-java#9145) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - ✨📖 Automatically register crashtracking via native extensions ([#​8851](DataDog/dd-trace-java#8851) - [@​MattAlp](https://github.com/MattAlp)) #### Data Streams Monitoring - ✨ Reduce DSM CPU overheard ([#​9151](DataDog/dd-trace-java#9151) - [@​kr-igor](https://github.com/kr-igor)) - ✨⚡ DSM optimizations for high throughput scenarios ([#​9137](DataDog/dd-trace-java#9137) - [@​kr-igor](https://github.com/kr-igor)) #### Database Monitoring - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Dynamic Instrumentation - 🐛 Add URI in string primitives ([#​9285](DataDog/dd-trace-java#9285) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Increase SourceFile tracking max queue size ([#​9271](DataDog/dd-trace-java#9271) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add capping on SourceFile tracking queue ([#​9245](DataDog/dd-trace-java#9245) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Add third-party filtering in SourceFile tracking ([#​9205](DataDog/dd-trace-java#9205) - [@​jpbempel](https://github.com/jpbempel)) #### ML Observability (LLMObs) - ✨ Add methods to capture embedding and retrieval spans ([#​9297](DataDog/dd-trace-java#9297) - [@​nayeem-kamal](https://github.com/nayeem-kamal)) #### Metrics - ✨ Change primary client stats configuration key ([#​9196](DataDog/dd-trace-java#9196) - [@​amarziali](https://github.com/amarziali)) - ✨ Calculate client stats also if the span kind is eligible ([#​9157](DataDog/dd-trace-java#9157) - [@​amarziali](https://github.com/amarziali)) - ✨ Backpropagate peer tags ([#​9144](DataDog/dd-trace-java#9144) - [@​bric3](https://github.com/bric3)) - 🐛 Make client stats reliable in case of downgrade ([#​9136](DataDog/dd-trace-java#9136) - [@​amarziali](https://github.com/amarziali)) #### Platform components - 🐛 Fix VM options parsing from /proc/fs ([#​9255](DataDog/dd-trace-java#9255) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Profiling - ✨ Switch profile compression to zstd default ([#​9293](DataDog/dd-trace-java#9293) - [@​jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.29.0 ([#​9262](DataDog/dd-trace-java#9262) - [@​zhengyu123](https://github.com/zhengyu123)) - Potential memory leak and race with the JVMTI wallclock sampler by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#234 - Downport async-profiler no-allocation changes by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#245 - Adopt openjdk safefetch by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#246 - Safe fetch 64-bit value and pointer by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#247 - Rebase on Async-Profiler 4.1 by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#252 - Patch upstream stackWalker.cpp not to fail on unaligned access by [@​jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#218 - Remap thread id to avoid bitmap contention by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#229 - Improve performance using Unsafe to activate/deactivate thread filter by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#230 - Unify context propagation by [@​zhengyu123](https://github.com/zhengyu123) in DataDog/java-profiler#231 - 🐛 Fix the profiler stackdepth setting propagation in recent (22+) Java versions ([#​9130](DataDog/dd-trace-java#9130) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - ✨ Wrap servlet original PrintWriter on rum injector ([#​9146](DataDog/dd-trace-java#9146) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - ✨ Create activation origin config for telemetry ([#​9064](DataDog/dd-trace-java#9064) - [@​sezen-datadog](https://github.com/sezen-datadog)) #### Tracer core - ✨⚡ Reduce span construction overhead by switching to optimized TagMap ([#​8589](DataDog/dd-trace-java#8589) - [@​dougqh](https://github.com/dougqh)) - 🐛 Match Hands Off Config selectors on process\_arguments value ([#​9201](DataDog/dd-trace-java#9201) - [@​paullegranddc](https://github.com/paullegranddc)) - ✨ Move JSON generation to sender thread to improve startup time. ([#​9197](DataDog/dd-trace-java#9197) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - ✨ Improve agent to avoid loading global config on main thread ([#​9190](DataDog/dd-trace-java#9190) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ add injection metadata fields to telemetry forwarder ([#​9185](DataDog/dd-trace-java#9185) - [@​sydney-tung](https://github.com/sydney-tung)) - 🐛 Avoid race conditions on feature discovery during Writer creation ([#​9173](DataDog/dd-trace-java#9173) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Surface potential root cause when agent initialization errors ([#​9170](DataDog/dd-trace-java#9170) - [@​AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Support adding W3C baggage as span tags ([#​9169](DataDog/dd-trace-java#9169) - [@​rachelyangdog](https://github.com/rachelyangdog)) - ✨⚡ Align our default classloader excludes with OTel ([#​9161](DataDog/dd-trace-java#9161) - [@​mcculls](https://github.com/mcculls)) - ✨ Backpropagate container tags hash coming from the info endpoint ([#​9156](DataDog/dd-trace-java#9156) - [@​amarziali](https://github.com/amarziali)) - 🐛 Avoid race conditions and multiple agent discovery feature states ([#​9135](DataDog/dd-trace-java#9135) - [@​amarziali](https://github.com/amarziali)) ### Instrumentations #### AWS SDK instrumentation - ✨ Enhance Service Representation for Serverless ([#​9203](DataDog/dd-trace-java#9203) - [@​zarirhamza](https://github.com/zarirhamza)) #### gRPC instrumentation - 🐛 Add check to prevent injection of repeated GRPC headers ([#​9246](DataDog/dd-trace-java#9246) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Fix duplicate trace injection for SQL Server and Oracle DBM full propagation mode ([#​9224](DataDog/dd-trace-java#9224) - [@​lu-zhengda](https://github.com/lu-zhengda)) #### Play Framework instrumentation - 🐛 Fix AppSec play.mvc.StatusHeader instrumentation for play 2.6 ([#​9160](DataDog/dd-trace-java#9160) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9da36329ffa552291a640381780b608ef6513e29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
In case of downgrade the client stats thread is interrupted. However the
DDAgentFeatureDiscovery
maintains a state based on the info endpoint that is then driving the fact that we inform the agent we are calculating or not the client stats (headerDatadog-Client-Stats-Computed
)If the client stats thread exit, and we discover again that the agent supports the client stats, we will end up in a situation where nobody will calculate the stats (since the thread is exited).
This PR avoid shutting down that thread. In any case there is always a guard (features.clientStatsSupported) in any metric writer method.
It also adds reliability test for this scenario
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]