Skip to content

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Apr 22, 2025

What Does This Do

Changes the default value of dd.jdk.socket.enabled to false

Motivation

Mitigation for #8696 while we address some differences in behaviour between the JFFI and JDK tunnelling socket implementations.

Contributor Checklist

Jira ticket: APMS-15527

@mcculls mcculls added type: bug Bug report and fix comp: core Tracer core labels Apr 22, 2025
@mcculls mcculls requested a review from a team as a code owner April 22, 2025 12:20
@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/jdk-sockets-off-by-default
git_commit_date 1745246084 1745323933
git_commit_sha 7dc621f 27050fc
release_version 1.49.0-SNAPSHOT~7dc621f3bb 1.49.0-SNAPSHOT~27050fc128
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745326919 1745326919
ci_job_id 906446694 906446694
ci_pipeline_id 62894811 62894811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-7s1ghto-project-304-concurrent-0-c3twrbt1 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-7s1ghto-project-304-concurrent-0-c3twrbt1 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 12 unstable metrics.

Startup time reports for petclinic
gantt title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section tracing Agent [baseline] (1.061 s) : 0, 1061280 Total [baseline] (10.464 s) : 0, 10464311 Agent [candidate] (1.062 s) : 0, 1061667 Total [candidate] (10.59 s) : 0, 10589887 section appsec Agent [baseline] (1.206 s) : 0, 1205658 Total [baseline] (10.834 s) : 0, 10834256 Agent [candidate] (1.202 s) : 0, 1201625 Total [candidate] (10.773 s) : 0, 10773451 section iast Agent [baseline] (1.187 s) : 0, 1187461 Total [baseline] (11.091 s) : 0, 11091455 Agent [candidate] (1.189 s) : 0, 1188505 Total [candidate] (11.057 s) : 0, 11056948 section profiling Agent [baseline] (1.31 s) : 0, 1310268 Total [baseline] (10.936 s) : 0, 10935932 Agent [candidate] (1.31 s) : 0, 1309703 Total [candidate] (10.996 s) : 0, 10996251 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.206 s 144.378 ms (13.6%)
Agent iast 1.187 s 126.18 ms (11.9%)
Agent profiling 1.31 s 248.987 ms (23.5%)
Total tracing 10.464 s -
Total appsec 10.834 s 369.945 ms (3.5%)
Total iast 11.091 s 627.143 ms (6.0%)
Total profiling 10.936 s 471.621 ms (4.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.202 s 139.958 ms (13.2%)
Agent iast 1.189 s 126.837 ms (11.9%)
Agent profiling 1.31 s 248.036 ms (23.4%)
Total tracing 10.59 s -
Total appsec 10.773 s 183.564 ms (1.7%)
Total iast 11.057 s 467.061 ms (4.4%)
Total profiling 10.996 s 406.364 ms (3.8%)
gantt title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (723.265 ms) : 0, 723265 BytebuddyAgent [candidate] (724.895 ms) : 0, 724895 GlobalTracer [baseline] (239.902 ms) : 0, 239902 GlobalTracer [candidate] (240.486 ms) : 0, 240486 AppSec [baseline] (54.54 ms) : 0, 54540 AppSec [candidate] (57.606 ms) : 0, 57606 Debugger [baseline] (4.427 ms) : 0, 4427 Debugger [candidate] (4.408 ms) : 0, 4408 Remote Config [baseline] (704.783 µs) : 0, 705 Remote Config [candidate] (711.28 µs) : 0, 711 Telemetry [baseline] (14.971 ms) : 0, 14971 Telemetry [candidate] (10.011 ms) : 0, 10011 section appsec BytebuddyAgent [baseline] (744.19 ms) : 0, 744190 BytebuddyAgent [candidate] (742.24 ms) : 0, 742240 GlobalTracer [baseline] (237.421 ms) : 0, 237421 GlobalTracer [candidate] (236.377 ms) : 0, 236377 AppSec [baseline] (175.917 ms) : 0, 175917 AppSec [candidate] (175.494 ms) : 0, 175494 Debugger [baseline] (4.218 ms) : 0, 4218 Debugger [candidate] (4.239 ms) : 0, 4239 Remote Config [baseline] (989.944 µs) : 0, 990 Remote Config [candidate] (637.404 µs) : 0, 637 Telemetry [baseline] (8.234 ms) : 0, 8234 Telemetry [candidate] (8.205 ms) : 0, 8205 IAST [baseline] (22.182 ms) : 0, 22182 IAST [candidate] (21.941 ms) : 0, 21941 section iast BytebuddyAgent [baseline] (841.635 ms) : 0, 841635 BytebuddyAgent [candidate] (841.512 ms) : 0, 841512 GlobalTracer [baseline] (230.241 ms) : 0, 230241 GlobalTracer [candidate] (230.76 ms) : 0, 230760 AppSec [baseline] (55.839 ms) : 0, 55839 AppSec [candidate] (54.622 ms) : 0, 54622 Debugger [baseline] (4.242 ms) : 0, 4242 Debugger [candidate] (4.252 ms) : 0, 4252 Remote Config [baseline] (611.784 µs) : 0, 612 Remote Config [candidate] (604.3 µs) : 0, 604 Telemetry [baseline] (8.621 ms) : 0, 8621 Telemetry [candidate] (8.829 ms) : 0, 8829 IAST [baseline] (22.847 ms) : 0, 22847 IAST [candidate] (24.487 ms) : 0, 24487 section profiling BytebuddyAgent [baseline] (713.679 ms) : 0, 713679 BytebuddyAgent [candidate] (713.444 ms) : 0, 713444 GlobalTracer [baseline] (375.855 ms) : 0, 375855 GlobalTracer [candidate] (376.55 ms) : 0, 376550 AppSec [baseline] (54.396 ms) : 0, 54396 AppSec [candidate] (53.303 ms) : 0, 53303 Debugger [baseline] (4.361 ms) : 0, 4361 Debugger [candidate] (4.373 ms) : 0, 4373 Remote Config [baseline] (666.897 µs) : 0, 667 Remote Config [candidate] (662.075 µs) : 0, 662 Telemetry [baseline] (8.964 ms) : 0, 8964 Telemetry [candidate] (8.934 ms) : 0, 8934 ProfilingAgent [baseline] (101.795 ms) : 0, 101795 ProfilingAgent [candidate] (102.1 ms) : 0, 102100 Profiling [baseline] (101.821 ms) : 0, 101821 Profiling [candidate] (102.125 ms) : 0, 102125 
Loading
Startup time reports for insecure-bank
gantt title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section tracing Agent [baseline] (1.059 s) : 0, 1058976 Total [baseline] (8.699 s) : 0, 8699341 Agent [candidate] (1.06 s) : 0, 1059970 Total [candidate] (8.717 s) : 0, 8717362 section iast Agent [baseline] (1.184 s) : 0, 1184468 Total [baseline] (9.248 s) : 0, 9248062 Agent [candidate] (1.185 s) : 0, 1185183 Total [candidate] (9.252 s) : 0, 9251675 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.185 s) : 0, 1185208 Total [baseline] (9.287 s) : 0, 9287353 Agent [candidate] (1.186 s) : 0, 1185926 Total [candidate] (9.235 s) : 0, 9235143 section iast_TELEMETRY_OFF Agent [baseline] (1.193 s) : 0, 1192605 Total [baseline] (9.313 s) : 0, 9312643 Agent [candidate] (1.183 s) : 0, 1182938 Total [candidate] (9.297 s) : 0, 9296784 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.184 s 125.492 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 126.232 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.193 s 133.629 ms (12.6%)
Total tracing 8.699 s -
Total iast 9.248 s 548.722 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.287 s 588.012 ms (6.8%)
Total iast_TELEMETRY_OFF 9.313 s 613.302 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.185 s 125.213 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 125.956 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.183 s 122.968 ms (11.6%)
Total tracing 8.717 s -
Total iast 9.252 s 534.312 ms (6.1%)
Total iast_HARDCODED_SECRET_DISABLED 9.235 s 517.781 ms (5.9%)
Total iast_TELEMETRY_OFF 9.297 s 579.421 ms (6.6%)
gantt title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (721.649 ms) : 0, 721649 BytebuddyAgent [candidate] (722.102 ms) : 0, 722102 GlobalTracer [baseline] (240.035 ms) : 0, 240035 GlobalTracer [candidate] (239.843 ms) : 0, 239843 AppSec [baseline] (55.787 ms) : 0, 55787 AppSec [candidate] (55.051 ms) : 0, 55051 Debugger [baseline] (4.364 ms) : 0, 4364 Debugger [candidate] (4.365 ms) : 0, 4365 Remote Config [baseline] (2.873 ms) : 0, 2873 Remote Config [candidate] (2.129 ms) : 0, 2129 Telemetry [baseline] (10.815 ms) : 0, 10815 Telemetry [candidate] (12.963 ms) : 0, 12963 section iast BytebuddyAgent [baseline] (838.714 ms) : 0, 838714 BytebuddyAgent [candidate] (839.812 ms) : 0, 839812 GlobalTracer [baseline] (229.781 ms) : 0, 229781 GlobalTracer [candidate] (229.905 ms) : 0, 229905 IAST [baseline] (24.588 ms) : 0, 24588 IAST [candidate] (22.751 ms) : 0, 22751 AppSec [baseline] (54.393 ms) : 0, 54393 AppSec [candidate] (55.118 ms) : 0, 55118 Debugger [baseline] (4.248 ms) : 0, 4248 Debugger [candidate] (4.212 ms) : 0, 4212 Remote Config [baseline] (625.232 µs) : 0, 625 Remote Config [candidate] (605.729 µs) : 0, 606 Telemetry [baseline] (8.773 ms) : 0, 8773 Telemetry [candidate] (8.644 ms) : 0, 8644 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (840.279 ms) : 0, 840279 BytebuddyAgent [candidate] (840.404 ms) : 0, 840404 GlobalTracer [baseline] (229.403 ms) : 0, 229403 GlobalTracer [candidate] (230.044 ms) : 0, 230044 IAST [baseline] (23.693 ms) : 0, 23693 IAST [candidate] (24.286 ms) : 0, 24286 AppSec [baseline] (54.114 ms) : 0, 54114 AppSec [candidate] (54.235 ms) : 0, 54235 Debugger [baseline] (4.209 ms) : 0, 4209 Debugger [candidate] (4.195 ms) : 0, 4195 Remote Config [baseline] (613.238 µs) : 0, 613 Remote Config [candidate] (608.157 µs) : 0, 608 Telemetry [baseline] (8.711 ms) : 0, 8711 Telemetry [candidate] (8.725 ms) : 0, 8725 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (844.149 ms) : 0, 844149 BytebuddyAgent [candidate] (838.696 ms) : 0, 838696 GlobalTracer [baseline] (231.798 ms) : 0, 231798 GlobalTracer [candidate] (229.847 ms) : 0, 229847 IAST [baseline] (22.838 ms) : 0, 22838 IAST [candidate] (23.127 ms) : 0, 23127 AppSec [baseline] (56.607 ms) : 0, 56607 AppSec [candidate] (54.625 ms) : 0, 54625 Debugger [baseline] (4.238 ms) : 0, 4238 Debugger [candidate] (4.101 ms) : 0, 4101 Remote Config [baseline] (662.578 µs) : 0, 663 Remote Config [candidate] (606.975 µs) : 0, 607 Telemetry [baseline] (8.806 ms) : 0, 8806 Telemetry [candidate] (8.575 ms) : 0, 8575 
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-22T12:31:56 2025-04-22T12:39:44
git_branch master mcculls/jdk-sockets-off-by-default
git_commit_date 1745246084 1745323933
git_commit_sha 7dc621f 27050fc
release_version 1.49.0-SNAPSHOT~7dc621f3bb 1.49.0-SNAPSHOT~27050fc128
start_time 2025-04-22T12:31:42 2025-04-22T12:39:30
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745325987 1745325987
ci_job_id 906446695 906446695
ci_pipeline_id 62894811 62894811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-uvgw7qef-project-304-concurrent-0-zrf0bvv9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-uvgw7qef-project-304-concurrent-0-zrf0bvv9 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section baseline no_agent (383.261 µs) : 363, 403 . : milestone, 383, iast (524.864 µs) : 502, 548 . : milestone, 525, iast_FULL (740.389 µs) : 718, 763 . : milestone, 740, iast_GLOBAL (563.852 µs) : 542, 585 . : milestone, 564, iast_HARDCODED_SECRET_DISABLED (517.841 µs) : 496, 540 . : milestone, 518, iast_INACTIVE (470.177 µs) : 448, 492 . : milestone, 470, iast_TELEMETRY_OFF (505.957 µs) : 484, 528 . : milestone, 506, tracing (465.363 µs) : 444, 487 . : milestone, 465, section candidate no_agent (384.005 µs) : 364, 404 . : milestone, 384, iast (514.514 µs) : 493, 536 . : milestone, 515, iast_FULL (730.567 µs) : 708, 753 . : milestone, 731, iast_GLOBAL (572.326 µs) : 550, 595 . : milestone, 572, iast_HARDCODED_SECRET_DISABLED (516.104 µs) : 494, 538 . : milestone, 516, iast_INACTIVE (466.089 µs) : 445, 487 . : milestone, 466, iast_TELEMETRY_OFF (503.197 µs) : 482, 525 . : milestone, 503, tracing (462.836 µs) : 442, 483 . : milestone, 463, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.261 µs [363.42 µs, 403.102 µs] -
iast 524.864 µs [502.106 µs, 547.621 µs] 141.603 µs (36.9%)
iast_FULL 740.389 µs [718.268 µs, 762.51 µs] 357.128 µs (93.2%)
iast_GLOBAL 563.852 µs [542.358 µs, 585.346 µs] 180.591 µs (47.1%)
iast_HARDCODED_SECRET_DISABLED 517.841 µs [496.132 µs, 539.549 µs] 134.58 µs (35.1%)
iast_INACTIVE 470.177 µs [448.43 µs, 491.924 µs] 86.916 µs (22.7%)
iast_TELEMETRY_OFF 505.957 µs [483.93 µs, 527.984 µs] 122.697 µs (32.0%)
tracing 465.363 µs [443.851 µs, 486.875 µs] 82.102 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 384.005 µs [364.294 µs, 403.716 µs] -
iast 514.514 µs [492.784 µs, 536.244 µs] 130.509 µs (34.0%)
iast_FULL 730.567 µs [708.404 µs, 752.73 µs] 346.562 µs (90.2%)
iast_GLOBAL 572.326 µs [549.73 µs, 594.921 µs] 188.32 µs (49.0%)
iast_HARDCODED_SECRET_DISABLED 516.104 µs [494.479 µs, 537.728 µs] 132.098 µs (34.4%)
iast_INACTIVE 466.089 µs [444.979 µs, 487.199 µs] 82.084 µs (21.4%)
iast_TELEMETRY_OFF 503.197 µs [481.645 µs, 524.749 µs] 119.192 µs (31.0%)
tracing 462.836 µs [442.275 µs, 483.398 µs] 78.831 µs (20.5%)
Request duration reports for petclinic
gantt title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section baseline no_agent (1.365 ms) : 1345, 1385 . : milestone, 1365, appsec (1.744 ms) : 1719, 1768 . : milestone, 1744, appsec_no_iast (1.742 ms) : 1718, 1766 . : milestone, 1742, code_origins (1.705 ms) : 1678, 1732 . : milestone, 1705, iast (1.522 ms) : 1498, 1546 . : milestone, 1522, profiling (1.566 ms) : 1541, 1591 . : milestone, 1566, tracing (1.517 ms) : 1493, 1541 . : milestone, 1517, section candidate no_agent (1.371 ms) : 1352, 1391 . : milestone, 1371, appsec (1.768 ms) : 1744, 1792 . : milestone, 1768, appsec_no_iast (1.754 ms) : 1731, 1777 . : milestone, 1754, code_origins (1.703 ms) : 1676, 1730 . : milestone, 1703, iast (1.522 ms) : 1497, 1546 . : milestone, 1522, profiling (1.585 ms) : 1560, 1609 . : milestone, 1585, tracing (1.499 ms) : 1474, 1524 . : milestone, 1499, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.345 ms, 1.385 ms] -
appsec 1.744 ms [1.719 ms, 1.768 ms] 378.639 µs (27.7%)
appsec_no_iast 1.742 ms [1.718 ms, 1.766 ms] 377.246 µs (27.6%)
code_origins 1.705 ms [1.678 ms, 1.732 ms] 340.223 µs (24.9%)
iast 1.522 ms [1.498 ms, 1.546 ms] 157.035 µs (11.5%)
profiling 1.566 ms [1.541 ms, 1.591 ms] 201.117 µs (14.7%)
tracing 1.517 ms [1.493 ms, 1.541 ms] 151.945 µs (11.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.371 ms [1.352 ms, 1.391 ms] -
appsec 1.768 ms [1.744 ms, 1.792 ms] 396.591 µs (28.9%)
appsec_no_iast 1.754 ms [1.731 ms, 1.777 ms] 382.439 µs (27.9%)
code_origins 1.703 ms [1.676 ms, 1.73 ms] 331.464 µs (24.2%)
iast 1.522 ms [1.497 ms, 1.546 ms] 150.09 µs (10.9%)
profiling 1.585 ms [1.56 ms, 1.609 ms] 213.431 µs (15.6%)
tracing 1.499 ms [1.474 ms, 1.524 ms] 127.612 µs (9.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/jdk-sockets-off-by-default
git_commit_date 1745246084 1745323933
git_commit_sha 7dc621f 27050fc
release_version 1.49.0-SNAPSHOT~7dc621f3bb 1.49.0-SNAPSHOT~27050fc128
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745326484 1745326484
ci_job_id 906446696 906446696
ci_pipeline_id 62894811 62894811
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-dt3tsoob-project-304-concurrent-0-egfe6o6h 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-dt3tsoob-project-304-concurrent-0-egfe6o6h 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section baseline no_agent (15.241 s) : 15241000, 15241000 . : milestone, 15241000, appsec (15.04 s) : 15040000, 15040000 . : milestone, 15040000, iast (19.089 s) : 19089000, 19089000 . : milestone, 19089000, iast_GLOBAL (17.785 s) : 17785000, 17785000 . : milestone, 17785000, profiling (15.001 s) : 15001000, 15001000 . : milestone, 15001000, tracing (15.079 s) : 15079000, 15079000 . : milestone, 15079000, section candidate no_agent (15.276 s) : 15276000, 15276000 . : milestone, 15276000, appsec (14.91 s) : 14910000, 14910000 . : milestone, 14910000, iast (18.467 s) : 18467000, 18467000 . : milestone, 18467000, iast_GLOBAL (18.243 s) : 18243000, 18243000 . : milestone, 18243000, profiling (15.023 s) : 15023000, 15023000 . : milestone, 15023000, tracing (14.86 s) : 14860000, 14860000 . : milestone, 14860000, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.241 s [15.241 s, 15.241 s] -
appsec 15.04 s [15.04 s, 15.04 s] -201.0 ms (-1.3%)
iast 19.089 s [19.089 s, 19.089 s] 3.848 s (25.2%)
iast_GLOBAL 17.785 s [17.785 s, 17.785 s] 2.544 s (16.7%)
profiling 15.001 s [15.001 s, 15.001 s] -240.0 ms (-1.6%)
tracing 15.079 s [15.079 s, 15.079 s] -162.0 ms (-1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.276 s [15.276 s, 15.276 s] -
appsec 14.91 s [14.91 s, 14.91 s] -366.0 ms (-2.4%)
iast 18.467 s [18.467 s, 18.467 s] 3.191 s (20.9%)
iast_GLOBAL 18.243 s [18.243 s, 18.243 s] 2.967 s (19.4%)
profiling 15.023 s [15.023 s, 15.023 s] -253.0 ms (-1.7%)
tracing 14.86 s [14.86 s, 14.86 s] -416.0 ms (-2.7%)
Execution time for tomcat
gantt title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~27050fc128, baseline=1.49.0-SNAPSHOT~7dc621f3bb dateFormat X axisFormat %s section baseline no_agent (1.477 ms) : 1465, 1488 . : milestone, 1477, appsec (2.344 ms) : 2301, 2388 . : milestone, 2344, iast (2.119 ms) : 2064, 2174 . : milestone, 2119, iast_GLOBAL (2.172 ms) : 2116, 2228 . : milestone, 2172, profiling (1.983 ms) : 1938, 2027 . : milestone, 1983, tracing (1.958 ms) : 1915, 2000 . : milestone, 1958, section candidate no_agent (1.476 ms) : 1464, 1487 . : milestone, 1476, appsec (2.357 ms) : 2312, 2401 . : milestone, 2357, iast (2.117 ms) : 2061, 2172 . : milestone, 2117, iast_GLOBAL (2.171 ms) : 2114, 2227 . : milestone, 2171, profiling (1.974 ms) : 1930, 2018 . : milestone, 1974, tracing (1.951 ms) : 1909, 1994 . : milestone, 1951, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.344 ms [2.301 ms, 2.388 ms] 867.776 µs (58.8%)
iast 2.119 ms [2.064 ms, 2.174 ms] 642.376 µs (43.5%)
iast_GLOBAL 2.172 ms [2.116 ms, 2.228 ms] 695.437 µs (47.1%)
profiling 1.983 ms [1.938 ms, 2.027 ms] 506.006 µs (34.3%)
tracing 1.958 ms [1.915 ms, 2.0 ms] 481.191 µs (32.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.464 ms, 1.487 ms] -
appsec 2.357 ms [2.312 ms, 2.401 ms] 880.828 µs (59.7%)
iast 2.117 ms [2.061 ms, 2.172 ms] 640.868 µs (43.4%)
iast_GLOBAL 2.171 ms [2.114 ms, 2.227 ms] 694.687 µs (47.1%)
profiling 1.974 ms [1.93 ms, 2.018 ms] 497.832 µs (33.7%)
tracing 1.951 ms [1.909 ms, 1.994 ms] 475.568 µs (32.2%)
@mcculls mcculls merged commit c827609 into master Apr 22, 2025
377 of 378 checks passed
@mcculls mcculls deleted the mcculls/jdk-sockets-off-by-default branch April 22, 2025 18:10
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 22, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.22.2` -> `3.22.3` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.28.0` -> `2.28.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.48.2` -> `1.49.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | --- ### Release Notes <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.56.3 ([844f4fa](googleapis/java-logging@844f4fa)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3 ([#&#8203;1801](googleapis/java-logging#1801)) ([d7aa7bc](googleapis/java-logging@d7aa7bc)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#&#8203;1803](googleapis/java-logging#1803)) ([5967ffe](googleapis/java-logging@5967ffe)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#&#8203;1804](googleapis/java-logging#1804)) ([e9a27ec](googleapis/java-logging@e9a27ec)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#&#8203;1841](googleapis/java-datastore#1841)) ([ac393e6](googleapis/java-datastore@ac393e6)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#&#8203;1842](googleapis/java-datastore#1842)) ([0745906](googleapis/java-datastore@0745906)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0): 1.49.0 ### Components #### Configuration at Runtime - ✨ Add process tags as list to remote config payload ([#&#8203;8705](DataDog/dd-trace-java#8705) - [@&#8203;amarziali](https://github.com/amarziali)) #### Continuous Integration Visibility - 🐛 Add span propagation for Pekko scheduled tasks ([#&#8203;8765](DataDog/dd-trace-java#8765) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Update test.retry_reason to use full name of the feature ([#&#8203;8689](DataDog/dd-trace-java#8689) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Remove unused TestEventsHandler methods ([#&#8203;8674](DataDog/dd-trace-java#8674) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) #### Dynamic Instrumentation - 🐛 Fix exclude identifiers normalization ([#&#8203;8742](DataDog/dd-trace-java#8742) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Make source file tracking asynchronous ([#&#8203;8684](DataDog/dd-trace-java#8684) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Add scope filtering for symbol extraction ([#&#8203;8676](DataDog/dd-trace-java#8676) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Add support for [@&#8203;key](https://github.com/key) and [@&#8203;value](https://github.com/value) for Map filtering ([#&#8203;8669](DataDog/dd-trace-java#8669) - [@&#8203;jpbempel](https://github.com/jpbempel)) #### Library Injection - ✨ Add system property to force injection of the tracing library even though multiple javaagents have been detected ([#&#8203;8697](DataDog/dd-trace-java#8697) - [@&#8203;cecile75](https://github.com/cecile75)) #### Metrics - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#&#8203;8693](DataDog/dd-trace-java#8693) - [@&#8203;randomanderson](https://github.com/randomanderson)) #### Profiling - ✨ Bump ddprof-java to 1.25.1 ([#&#8203;8750](DataDog/dd-trace-java#8750) - [@&#8203;jbachorik](https://github.com/jbachorik)) - 🐛 Remove cleanup-on-shutdown for temporary files ([#&#8203;8746](DataDog/dd-trace-java#8746) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨⚡ Replace a regex-based SMAP parser with a hand-crafted one ([#&#8203;8730](DataDog/dd-trace-java#8730) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Improve error reporting on profiler startup ([#&#8203;8714](DataDog/dd-trace-java#8714) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Exclude ProxyLeakTask exception from exception profiling ([#&#8203;8666](DataDog/dd-trace-java#8666) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#&#8203;8641](DataDog/dd-trace-java#8641) - [@&#8203;MattAlp](https://github.com/MattAlp)) #### Telemetry - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#&#8203;8693](DataDog/dd-trace-java#8693) - [@&#8203;randomanderson](https://github.com/randomanderson)) - 🐛 Fix appsec.waf.requests telemetry metric ([#&#8203;8644](DataDog/dd-trace-java#8644) - [@&#8203;jandro996](https://github.com/jandro996)) #### Tracer core - ✨ Exclude jackson afterburner dynamic classes from instrumentation ([#&#8203;8747](DataDog/dd-trace-java#8747) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Introduce Java 8 bytecode bridge for instrumentation API ([#&#8203;8736](DataDog/dd-trace-java#8736) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) - ⚡🧹 Use byte-buddy classes optimized for Java8+ ([#&#8203;8735](DataDog/dd-trace-java#8735) - [@&#8203;mcculls](https://github.com/mcculls)) - 🐛 Do not set the hibernate or datanucleus span service name when disabled ([#&#8203;8727](DataDog/dd-trace-java#8727) - [@&#8203;ygree](https://github.com/ygree)) - ✨ Update bytebuddy and ASM to support JDK 24 ([#&#8203;8720](DataDog/dd-trace-java#8720) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) - 🐛 Turn off JDK socket support by default ([#&#8203;8715](DataDog/dd-trace-java#8715) - [@&#8203;mcculls](https://github.com/mcculls)) - 🐛 Log warning when trace buffer overflow occurs ([#&#8203;8712](DataDog/dd-trace-java#8712) - [@&#8203;ygree](https://github.com/ygree)) - ✨🧪 Introducing an internal integration name ([#&#8203;8708](DataDog/dd-trace-java#8708) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Add process tags to client stats payload ([#&#8203;8704](DataDog/dd-trace-java#8704) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Collect process tags for tracing ([#&#8203;8698](DataDog/dd-trace-java#8698) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Stable Config file: target system properties in process_arguments and support template variables in YamlParser ([#&#8203;8690](DataDog/dd-trace-java#8690) - [@&#8203;mtoffl01](https://github.com/mtoffl01)) - ✨⚡ Use prefix trie for proxy ignores ([#&#8203;8678](DataDog/dd-trace-java#8678) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Allow agent to be automatically injected when running aside Log4J patch agent ([#&#8203;8648](DataDog/dd-trace-java#8648) - [@&#8203;paullegranddc](https://github.com/paullegranddc)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#&#8203;8641](DataDog/dd-trace-java#8641) - [@&#8203;MattAlp](https://github.com/MattAlp)) #### Tracer internal logging - 🐛 Delete print line ([#&#8203;8686](DataDog/dd-trace-java#8686) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) ### Instrumentations #### Akka instrumentation - 🐛 Handle reentrant scope cleanup in Akka/Pekko actor instrumentations ([#&#8203;8722](DataDog/dd-trace-java#8722) - [@&#8203;mcculls](https://github.com/mcculls)) #### Apache Spark instrumentation - ✨ Use OpenLineage root parent information to generate trace id ([#&#8203;8726](DataDog/dd-trace-java#8726) - [@&#8203;mobuchowski](https://github.com/mobuchowski)) - ✨ Spark job cancellation no longer marks application as failed ([#&#8203;8701](DataDog/dd-trace-java#8701) - [@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd)) #### JDBC instrumentation - 💡 Add support for sybase tds jdbc driver ([#&#8203;8764](DataDog/dd-trace-java#8764) - [@&#8203;amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - 🐛 Take defensive copy of parent scope stack when closing nested coroutines ([#&#8203;8749](DataDog/dd-trace-java#8749) - [@&#8203;mcculls](https://github.com/mcculls)) #### Reactor instrumentation - ✨⚡ Do not inspect reactor context when not needed ([#&#8203;8745](DataDog/dd-trace-java#8745) - [@&#8203;amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: core Tracer core type: bug Bug report and fix

3 participants