Skip to content

Conversation

jbachorik
Copy link
Contributor

@jbachorik jbachorik commented Apr 22, 2025

What Does This Do

This modifies the way how we report the failures to initialize profiler components to DD telemetry and enhances the visibility to why the expected temporary directory structure may not get properly created.

Motivation

Improve the supportability of the profiler configuration issues

Additional Notes

Contributor Checklist

Jira ticket: PROF-11667

@jbachorik jbachorik added type: enhancement Enhancements and improvements comp: profiling Profiling labels Apr 22, 2025
@jbachorik jbachorik requested a review from a team as a code owner April 22, 2025 11:25
@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/prof_startup_err
git_commit_date 1745391799 1745401404
git_commit_sha 6b6cbf6 786d17e
release_version 1.49.0-SNAPSHOT~6b6cbf6499 1.49.0-SNAPSHOT~786d17e3a3
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745404292 1745404292
ci_job_id 908268040 908268040
ci_pipeline_id 63020161 63020161
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ekfrqbyz-project-304-concurrent-1-gamiw2ze 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ekfrqbyz-project-304-concurrent-1-gamiw2ze 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics.

Startup time reports for insecure-bank
gantt title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section tracing Agent [baseline] (1.056 s) : 0, 1056184 Total [baseline] (8.671 s) : 0, 8671307 Agent [candidate] (1.063 s) : 0, 1062785 Total [candidate] (8.654 s) : 0, 8654257 section iast Agent [baseline] (1.192 s) : 0, 1191685 Total [baseline] (9.231 s) : 0, 9231321 Agent [candidate] (1.182 s) : 0, 1181747 Total [candidate] (9.195 s) : 0, 9195119 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.187 s) : 0, 1186540 Total [baseline] (9.206 s) : 0, 9205531 Agent [candidate] (1.185 s) : 0, 1184662 Total [candidate] (9.23 s) : 0, 9230341 section iast_TELEMETRY_OFF Agent [baseline] (1.19 s) : 0, 1190017 Total [baseline] (9.213 s) : 0, 9213482 Agent [candidate] (1.191 s) : 0, 1190636 Total [candidate] (9.243 s) : 0, 9242579 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.056 s -
Agent iast 1.192 s 135.501 ms (12.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.187 s 130.356 ms (12.3%)
Agent iast_TELEMETRY_OFF 1.19 s 133.833 ms (12.7%)
Total tracing 8.671 s -
Total iast 9.231 s 560.014 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.206 s 534.224 ms (6.2%)
Total iast_TELEMETRY_OFF 9.213 s 542.175 ms (6.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.182 s 118.962 ms (11.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.185 s 121.877 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.191 s 127.851 ms (12.0%)
Total tracing 8.654 s -
Total iast 9.195 s 540.862 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 9.23 s 576.084 ms (6.7%)
Total iast_TELEMETRY_OFF 9.243 s 588.322 ms (6.8%)
gantt title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (722.366 ms) : 0, 722366 BytebuddyAgent [candidate] (723.027 ms) : 0, 723027 GlobalTracer [baseline] (238.913 ms) : 0, 238913 GlobalTracer [candidate] (239.905 ms) : 0, 239905 AppSec [baseline] (54.368 ms) : 0, 54368 AppSec [candidate] (56.24 ms) : 0, 56240 Debugger [baseline] (6.537 ms) : 0, 6537 Debugger [candidate] (4.401 ms) : 0, 4401 Remote Config [baseline] (694.401 µs) : 0, 694 Remote Config [candidate] (3.631 ms) : 0, 3631 Telemetry [baseline] (9.94 ms) : 0, 9940 Telemetry [candidate] (12.152 ms) : 0, 12152 section iast BytebuddyAgent [baseline] (846.307 ms) : 0, 846307 BytebuddyAgent [candidate] (837.323 ms) : 0, 837323 GlobalTracer [baseline] (229.783 ms) : 0, 229783 GlobalTracer [candidate] (228.832 ms) : 0, 228832 IAST [baseline] (25.223 ms) : 0, 25223 IAST [candidate] (22.841 ms) : 0, 22841 AppSec [baseline] (51.974 ms) : 0, 51974 AppSec [candidate] (55.976 ms) : 0, 55976 Debugger [baseline] (4.216 ms) : 0, 4216 Debugger [candidate] (4.229 ms) : 0, 4229 Remote Config [baseline] (600.814 µs) : 0, 601 Remote Config [candidate] (609.415 µs) : 0, 609 Telemetry [baseline] (8.623 ms) : 0, 8623 Telemetry [candidate] (8.617 ms) : 0, 8617 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (839.821 ms) : 0, 839821 BytebuddyAgent [candidate] (840.052 ms) : 0, 840052 GlobalTracer [baseline] (229.718 ms) : 0, 229718 GlobalTracer [candidate] (229.049 ms) : 0, 229049 IAST [baseline] (23.131 ms) : 0, 23131 IAST [candidate] (22.857 ms) : 0, 22857 AppSec [baseline] (55.311 ms) : 0, 55311 AppSec [candidate] (55.757 ms) : 0, 55757 Debugger [baseline] (4.248 ms) : 0, 4248 Debugger [candidate] (4.243 ms) : 0, 4243 Remote Config [baseline] (616.375 µs) : 0, 616 Remote Config [candidate] (601.421 µs) : 0, 601 Telemetry [baseline] (8.765 ms) : 0, 8765 Telemetry [candidate] (8.658 ms) : 0, 8658 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (843.68 ms) : 0, 843680 BytebuddyAgent [candidate] (844.433 ms) : 0, 844433 GlobalTracer [baseline] (230.318 ms) : 0, 230318 GlobalTracer [candidate] (230.85 ms) : 0, 230850 IAST [baseline] (22.648 ms) : 0, 22648 IAST [candidate] (22.627 ms) : 0, 22627 AppSec [baseline] (56.324 ms) : 0, 56324 AppSec [candidate] (55.807 ms) : 0, 55807 Debugger [baseline] (4.23 ms) : 0, 4230 Debugger [candidate] (4.164 ms) : 0, 4164 Remote Config [baseline] (638.175 µs) : 0, 638 Remote Config [candidate] (626.261 µs) : 0, 626 Telemetry [baseline] (8.711 ms) : 0, 8711 Telemetry [candidate] (8.577 ms) : 0, 8577 
Loading
Startup time reports for petclinic
gantt title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section tracing Agent [baseline] (1.057 s) : 0, 1056820 Total [baseline] (10.473 s) : 0, 10472837 Agent [candidate] (1.064 s) : 0, 1063823 Total [candidate] (10.446 s) : 0, 10445763 section appsec Agent [baseline] (1.198 s) : 0, 1197789 Total [baseline] (10.843 s) : 0, 10843238 Agent [candidate] (1.195 s) : 0, 1195060 Total [candidate] (10.735 s) : 0, 10734932 section iast Agent [baseline] (1.189 s) : 0, 1189022 Total [baseline] (11.02 s) : 0, 11019774 Agent [candidate] (1.185 s) : 0, 1184644 Total [candidate] (10.95 s) : 0, 10949788 section profiling Agent [baseline] (1.328 s) : 0, 1327693 Total [baseline] (10.954 s) : 0, 10954145 Agent [candidate] (1.306 s) : 0, 1305786 Total [candidate] (10.891 s) : 0, 10890801 
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.198 s 140.969 ms (13.3%)
Agent iast 1.189 s 132.203 ms (12.5%)
Agent profiling 1.328 s 270.873 ms (25.6%)
Total tracing 10.473 s -
Total appsec 10.843 s 370.401 ms (3.5%)
Total iast 11.02 s 546.937 ms (5.2%)
Total profiling 10.954 s 481.308 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent appsec 1.195 s 131.237 ms (12.3%)
Agent iast 1.185 s 120.821 ms (11.4%)
Agent profiling 1.306 s 241.963 ms (22.7%)
Total tracing 10.446 s -
Total appsec 10.735 s 289.169 ms (2.8%)
Total iast 10.95 s 504.025 ms (4.8%)
Total profiling 10.891 s 445.038 ms (4.3%)
gantt title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (721.63 ms) : 0, 721630 BytebuddyAgent [candidate] (726.105 ms) : 0, 726105 GlobalTracer [baseline] (238.865 ms) : 0, 238865 GlobalTracer [candidate] (240.632 ms) : 0, 240632 AppSec [baseline] (55.156 ms) : 0, 55156 AppSec [candidate] (55.037 ms) : 0, 55037 Debugger [baseline] (7.238 ms) : 0, 7238 Debugger [candidate] (4.399 ms) : 0, 4399 Remote Config [baseline] (685.267 µs) : 0, 685 Remote Config [candidate] (1.453 ms) : 0, 1453 Telemetry [baseline] (9.869 ms) : 0, 9869 Telemetry [candidate] (12.774 ms) : 0, 12774 section appsec BytebuddyAgent [baseline] (739.676 ms) : 0, 739676 BytebuddyAgent [candidate] (737.141 ms) : 0, 737141 GlobalTracer [baseline] (235.563 ms) : 0, 235563 GlobalTracer [candidate] (235.029 ms) : 0, 235029 IAST [baseline] (21.69 ms) : 0, 21690 IAST [candidate] (21.709 ms) : 0, 21709 AppSec [baseline] (175.238 ms) : 0, 175238 AppSec [candidate] (175.66 ms) : 0, 175660 Debugger [baseline] (4.206 ms) : 0, 4206 Debugger [candidate] (4.223 ms) : 0, 4223 Remote Config [baseline] (627.933 µs) : 0, 628 Remote Config [candidate] (626.766 µs) : 0, 627 Telemetry [baseline] (8.203 ms) : 0, 8203 Telemetry [candidate] (8.188 ms) : 0, 8188 section iast BytebuddyAgent [baseline] (843.014 ms) : 0, 843014 BytebuddyAgent [candidate] (839.303 ms) : 0, 839303 GlobalTracer [baseline] (230.322 ms) : 0, 230322 GlobalTracer [candidate] (229.523 ms) : 0, 229523 IAST [baseline] (22.94 ms) : 0, 22940 IAST [candidate] (23.663 ms) : 0, 23663 AppSec [baseline] (52.697 ms) : 0, 52697 AppSec [candidate] (55.152 ms) : 0, 55152 Debugger [baseline] (4.251 ms) : 0, 4251 Debugger [candidate] (4.261 ms) : 0, 4261 Remote Config [baseline] (605.727 µs) : 0, 606 Remote Config [candidate] (606.734 µs) : 0, 607 Telemetry [baseline] (8.665 ms) : 0, 8665 Telemetry [candidate] (8.767 ms) : 0, 8767 section profiling BytebuddyAgent [baseline] (725.795 ms) : 0, 725795 BytebuddyAgent [candidate] (711.051 ms) : 0, 711051 GlobalTracer [baseline] (379.395 ms) : 0, 379395 GlobalTracer [candidate] (375.953 ms) : 0, 375953 AppSec [baseline] (54.783 ms) : 0, 54783 AppSec [candidate] (53.145 ms) : 0, 53145 Debugger [baseline] (4.462 ms) : 0, 4462 Debugger [candidate] (4.357 ms) : 0, 4357 Remote Config [baseline] (684.679 µs) : 0, 685 Remote Config [candidate] (652.928 µs) : 0, 653 Telemetry [baseline] (9.078 ms) : 0, 9078 Telemetry [candidate] (8.965 ms) : 0, 8965 ProfilingAgent [baseline] (102.81 ms) : 0, 102810 ProfilingAgent [candidate] (101.503 ms) : 0, 101503 Profiling [baseline] (102.835 ms) : 0, 102835 Profiling [candidate] (101.529 ms) : 0, 101529 
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-04-23T10:01:52 2025-04-23T10:09:40
git_branch master jb/prof_startup_err
git_commit_date 1745391799 1745401404
git_commit_sha 6b6cbf6 786d17e
release_version 1.49.0-SNAPSHOT~6b6cbf6499 1.49.0-SNAPSHOT~786d17e3a3
start_time 2025-04-23T10:01:38 2025-04-23T10:09:26
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1745403381 1745403381
ci_job_id 908268041 908268041
ci_pipeline_id 63020161 63020161
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4i48fg5e-project-304-concurrent-1-0cus4cvy 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4i48fg5e-project-304-concurrent-1-0cus4cvy 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.

Request duration reports for insecure-bank
gantt title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section baseline no_agent (390.469 µs) : 370, 411 . : milestone, 390, iast (515.0 µs) : 492, 538 . : milestone, 515, iast_FULL (737.786 µs) : 716, 760 . : milestone, 738, iast_GLOBAL (568.429 µs) : 546, 591 . : milestone, 568, iast_HARDCODED_SECRET_DISABLED (517.022 µs) : 495, 539 . : milestone, 517, iast_INACTIVE (472.642 µs) : 451, 494 . : milestone, 473, iast_TELEMETRY_OFF (503.543 µs) : 482, 525 . : milestone, 504, tracing (462.318 µs) : 442, 483 . : milestone, 462, section candidate no_agent (389.137 µs) : 369, 409 . : milestone, 389, iast (515.51 µs) : 494, 537 . : milestone, 516, iast_FULL (740.186 µs) : 718, 762 . : milestone, 740, iast_GLOBAL (565.989 µs) : 544, 588 . : milestone, 566, iast_HARDCODED_SECRET_DISABLED (516.603 µs) : 495, 538 . : milestone, 517, iast_INACTIVE (472.724 µs) : 451, 494 . : milestone, 473, iast_TELEMETRY_OFF (511.369 µs) : 489, 533 . : milestone, 511, tracing (459.707 µs) : 439, 480 . : milestone, 460, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 390.469 µs [369.652 µs, 411.286 µs] -
iast 515.0 µs [492.46 µs, 537.54 µs] 124.531 µs (31.9%)
iast_FULL 737.786 µs [715.671 µs, 759.902 µs] 347.318 µs (88.9%)
iast_GLOBAL 568.429 µs [546.23 µs, 590.628 µs] 177.96 µs (45.6%)
iast_HARDCODED_SECRET_DISABLED 517.022 µs [495.375 µs, 538.669 µs] 126.554 µs (32.4%)
iast_INACTIVE 472.642 µs [450.807 µs, 494.477 µs] 82.173 µs (21.0%)
iast_TELEMETRY_OFF 503.543 µs [481.991 µs, 525.094 µs] 113.074 µs (29.0%)
tracing 462.318 µs [441.582 µs, 483.054 µs] 71.849 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 389.137 µs [369.443 µs, 408.83 µs] -
iast 515.51 µs [493.747 µs, 537.274 µs] 126.374 µs (32.5%)
iast_FULL 740.186 µs [718.068 µs, 762.304 µs] 351.049 µs (90.2%)
iast_GLOBAL 565.989 µs [544.085 µs, 587.894 µs] 176.853 µs (45.4%)
iast_HARDCODED_SECRET_DISABLED 516.603 µs [495.029 µs, 538.177 µs] 127.466 µs (32.8%)
iast_INACTIVE 472.724 µs [451.006 µs, 494.443 µs] 83.588 µs (21.5%)
iast_TELEMETRY_OFF 511.369 µs [489.481 µs, 533.256 µs] 122.232 µs (31.4%)
tracing 459.707 µs [439.321 µs, 480.094 µs] 70.57 µs (18.1%)
Request duration reports for petclinic
gantt title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section baseline no_agent (1.36 ms) : 1340, 1379 . : milestone, 1360, appsec (1.737 ms) : 1713, 1761 . : milestone, 1737, appsec_no_iast (1.733 ms) : 1708, 1757 . : milestone, 1733, code_origins (1.7 ms) : 1673, 1728 . : milestone, 1700, iast (1.53 ms) : 1505, 1554 . : milestone, 1530, profiling (1.534 ms) : 1509, 1559 . : milestone, 1534, tracing (1.54 ms) : 1516, 1564 . : milestone, 1540, section candidate no_agent (1.378 ms) : 1357, 1398 . : milestone, 1378, appsec (1.762 ms) : 1739, 1785 . : milestone, 1762, appsec_no_iast (1.771 ms) : 1746, 1795 . : milestone, 1771, code_origins (1.696 ms) : 1669, 1722 . : milestone, 1696, iast (1.514 ms) : 1490, 1537 . : milestone, 1514, profiling (1.527 ms) : 1504, 1550 . : milestone, 1527, tracing (1.528 ms) : 1503, 1553 . : milestone, 1528, 
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.34 ms, 1.379 ms] -
appsec 1.737 ms [1.713 ms, 1.761 ms] 377.151 µs (27.7%)
appsec_no_iast 1.733 ms [1.708 ms, 1.757 ms] 373.064 µs (27.4%)
code_origins 1.7 ms [1.673 ms, 1.728 ms] 340.643 µs (25.1%)
iast 1.53 ms [1.505 ms, 1.554 ms] 169.765 µs (12.5%)
profiling 1.534 ms [1.509 ms, 1.559 ms] 174.034 µs (12.8%)
tracing 1.54 ms [1.516 ms, 1.564 ms] 180.371 µs (13.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.378 ms [1.357 ms, 1.398 ms] -
appsec 1.762 ms [1.739 ms, 1.785 ms] 384.158 µs (27.9%)
appsec_no_iast 1.771 ms [1.746 ms, 1.795 ms] 392.889 µs (28.5%)
code_origins 1.696 ms [1.669 ms, 1.722 ms] 318.019 µs (23.1%)
iast 1.514 ms [1.49 ms, 1.537 ms] 136.016 µs (9.9%)
profiling 1.527 ms [1.504 ms, 1.55 ms] 149.001 µs (10.8%)
tracing 1.528 ms [1.503 ms, 1.553 ms] 150.411 µs (10.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/prof_startup_err
git_commit_date 1745391799 1745401404
git_commit_sha 6b6cbf6 786d17e
release_version 1.49.0-SNAPSHOT~6b6cbf6499 1.49.0-SNAPSHOT~786d17e3a3
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1745403830 1745403830
ci_job_id 908268044 908268044
ci_pipeline_id 63020161 63020161
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-ekfrqbyz-project-304-concurrent-2-n1z503bs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-ekfrqbyz-project-304-concurrent-2-n1z503bs 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section baseline no_agent (1.477 ms) : 1465, 1488 . : milestone, 1477, appsec (2.359 ms) : 2315, 2402 . : milestone, 2359, iast (2.144 ms) : 2089, 2200 . : milestone, 2144, iast_GLOBAL (2.169 ms) : 2113, 2225 . : milestone, 2169, profiling (1.978 ms) : 1935, 2022 . : milestone, 1978, tracing (1.96 ms) : 1918, 2003 . : milestone, 1960, section candidate no_agent (1.473 ms) : 1461, 1484 . : milestone, 1473, appsec (2.355 ms) : 2312, 2399 . : milestone, 2355, iast (2.131 ms) : 2076, 2187 . : milestone, 2131, iast_GLOBAL (2.178 ms) : 2122, 2234 . : milestone, 2178, profiling (1.972 ms) : 1929, 2016 . : milestone, 1972, tracing (1.965 ms) : 1923, 2007 . : milestone, 1965, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.465 ms, 1.488 ms] -
appsec 2.359 ms [2.315 ms, 2.402 ms] 882.136 µs (59.7%)
iast 2.144 ms [2.089 ms, 2.2 ms] 667.643 µs (45.2%)
iast_GLOBAL 2.169 ms [2.113 ms, 2.225 ms] 692.503 µs (46.9%)
profiling 1.978 ms [1.935 ms, 2.022 ms] 501.604 µs (34.0%)
tracing 1.96 ms [1.918 ms, 2.003 ms] 483.44 µs (32.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.355 ms [2.312 ms, 2.399 ms] 882.788 µs (59.9%)
iast 2.131 ms [2.076 ms, 2.187 ms] 658.769 µs (44.7%)
iast_GLOBAL 2.178 ms [2.122 ms, 2.234 ms] 705.547 µs (47.9%)
profiling 1.972 ms [1.929 ms, 2.016 ms] 499.595 µs (33.9%)
tracing 1.965 ms [1.923 ms, 2.007 ms] 492.333 µs (33.4%)
Execution time for biojava
gantt title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~786d17e3a3, baseline=1.49.0-SNAPSHOT~6b6cbf6499 dateFormat X axisFormat %s section baseline no_agent (14.937 s) : 14937000, 14937000 . : milestone, 14937000, appsec (14.898 s) : 14898000, 14898000 . : milestone, 14898000, iast (18.856 s) : 18856000, 18856000 . : milestone, 18856000, iast_GLOBAL (18.337 s) : 18337000, 18337000 . : milestone, 18337000, profiling (15.062 s) : 15062000, 15062000 . : milestone, 15062000, tracing (14.972 s) : 14972000, 14972000 . : milestone, 14972000, section candidate no_agent (14.977 s) : 14977000, 14977000 . : milestone, 14977000, appsec (15.269 s) : 15269000, 15269000 . : milestone, 15269000, iast (18.743 s) : 18743000, 18743000 . : milestone, 18743000, iast_GLOBAL (18.048 s) : 18048000, 18048000 . : milestone, 18048000, profiling (15.556 s) : 15556000, 15556000 . : milestone, 15556000, tracing (15.315 s) : 15315000, 15315000 . : milestone, 15315000, 
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.937 s [14.937 s, 14.937 s] -
appsec 14.898 s [14.898 s, 14.898 s] -39.0 ms (-0.3%)
iast 18.856 s [18.856 s, 18.856 s] 3.919 s (26.2%)
iast_GLOBAL 18.337 s [18.337 s, 18.337 s] 3.4 s (22.8%)
profiling 15.062 s [15.062 s, 15.062 s] 125.0 ms (0.8%)
tracing 14.972 s [14.972 s, 14.972 s] 35.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.977 s [14.977 s, 14.977 s] -
appsec 15.269 s [15.269 s, 15.269 s] 292.0 ms (1.9%)
iast 18.743 s [18.743 s, 18.743 s] 3.766 s (25.1%)
iast_GLOBAL 18.048 s [18.048 s, 18.048 s] 3.071 s (20.5%)
profiling 15.556 s [15.556 s, 15.556 s] 579.0 ms (3.9%)
tracing 15.315 s [15.315 s, 15.315 s] 338.0 ms (2.3%)
@jbachorik jbachorik force-pushed the jb/prof_startup_err branch from febaf43 to 19b6ee4 Compare April 22, 2025 18:53
Copy link

@MattAlp MattAlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. As an eventual follow-up, let's establish what kind of telemetry we want to collect (OS, vendor, runtime...) and standardize it for the "comprehensive picture" work discussed earlier on Slack

log.warn(e.getMessage());
log.debug(SEND_TELEMETRY, "Unsupported environment for Datadog profiler", e);
// no need to send telemetry for this aggregate message
// a detailed telemetry message has been sent from the attempts to enable the controllers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: was this indentation generated by Spotless?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This was manual. I find it a bit more readable when spotless kicks in and reformats my comments. It didn't happen this time, but you never know.

log.warn(SEND_TELEMETRY, msg, e);
}
} catch (IOException ignored) {
// should not happen, but let's ignore it anyway'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
LLM generated comment 😆
Will fix.

@jbachorik jbachorik force-pushed the jb/prof_startup_err branch from 19b6ee4 to 786d17e Compare April 23, 2025 09:43
@jbachorik jbachorik merged commit 52f61bb into master Apr 29, 2025
459 checks passed
@jbachorik jbachorik deleted the jb/prof_startup_err branch April 29, 2025 12:55
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 29, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request May 7, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.22.2` -> `3.22.3` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.28.0` -> `2.28.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.48.2` -> `1.49.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.36` -> `2.31.37` | --- ### Release Notes <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.22.3`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3223-2025-05-06) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.56.3 ([844f4fa](googleapis/java-logging@844f4fa)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.46.3 ([#&#8203;1801](googleapis/java-logging#1801)) ([d7aa7bc](googleapis/java-logging@d7aa7bc)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#&#8203;1803](googleapis/java-logging#1803)) ([5967ffe](googleapis/java-logging@5967ffe)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#&#8203;1804](googleapis/java-logging#1804)) ([e9a27ec](googleapis/java-logging@e9a27ec)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.28.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2281-2025-05-06) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.47.0 ([#&#8203;1841](googleapis/java-datastore#1841)) ([ac393e6](googleapis/java-datastore@ac393e6)) - Update googleapis/sdk-platform-java action to v2.57.0 ([#&#8203;1842](googleapis/java-datastore#1842)) ([0745906](googleapis/java-datastore@0745906)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.49.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.49.0): 1.49.0 ### Components #### Configuration at Runtime - ✨ Add process tags as list to remote config payload ([#&#8203;8705](DataDog/dd-trace-java#8705) - [@&#8203;amarziali](https://github.com/amarziali)) #### Continuous Integration Visibility - 🐛 Add span propagation for Pekko scheduled tasks ([#&#8203;8765](DataDog/dd-trace-java#8765) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Update test.retry_reason to use full name of the feature ([#&#8203;8689](DataDog/dd-trace-java#8689) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Remove unused TestEventsHandler methods ([#&#8203;8674](DataDog/dd-trace-java#8674) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) #### Dynamic Instrumentation - 🐛 Fix exclude identifiers normalization ([#&#8203;8742](DataDog/dd-trace-java#8742) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Make source file tracking asynchronous ([#&#8203;8684](DataDog/dd-trace-java#8684) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Add scope filtering for symbol extraction ([#&#8203;8676](DataDog/dd-trace-java#8676) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Add support for [@&#8203;key](https://github.com/key) and [@&#8203;value](https://github.com/value) for Map filtering ([#&#8203;8669](DataDog/dd-trace-java#8669) - [@&#8203;jpbempel](https://github.com/jpbempel)) #### Library Injection - ✨ Add system property to force injection of the tracing library even though multiple javaagents have been detected ([#&#8203;8697](DataDog/dd-trace-java#8697) - [@&#8203;cecile75](https://github.com/cecile75)) #### Metrics - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#&#8203;8693](DataDog/dd-trace-java#8693) - [@&#8203;randomanderson](https://github.com/randomanderson)) #### Profiling - ✨ Bump ddprof-java to 1.25.1 ([#&#8203;8750](DataDog/dd-trace-java#8750) - [@&#8203;jbachorik](https://github.com/jbachorik)) - 🐛 Remove cleanup-on-shutdown for temporary files ([#&#8203;8746](DataDog/dd-trace-java#8746) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨⚡ Replace a regex-based SMAP parser with a hand-crafted one ([#&#8203;8730](DataDog/dd-trace-java#8730) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Improve error reporting on profiler startup ([#&#8203;8714](DataDog/dd-trace-java#8714) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Exclude ProxyLeakTask exception from exception profiling ([#&#8203;8666](DataDog/dd-trace-java#8666) - [@&#8203;jbachorik](https://github.com/jbachorik)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#&#8203;8641](DataDog/dd-trace-java#8641) - [@&#8203;MattAlp](https://github.com/MattAlp)) #### Telemetry - ✨ Allow dogstatsd port to be configurable with DD_DOGSTATSD_PORT ([#&#8203;8693](DataDog/dd-trace-java#8693) - [@&#8203;randomanderson](https://github.com/randomanderson)) - 🐛 Fix appsec.waf.requests telemetry metric ([#&#8203;8644](DataDog/dd-trace-java#8644) - [@&#8203;jandro996](https://github.com/jandro996)) #### Tracer core - ✨ Exclude jackson afterburner dynamic classes from instrumentation ([#&#8203;8747](DataDog/dd-trace-java#8747) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Introduce Java 8 bytecode bridge for instrumentation API ([#&#8203;8736](DataDog/dd-trace-java#8736) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) - ⚡🧹 Use byte-buddy classes optimized for Java8+ ([#&#8203;8735](DataDog/dd-trace-java#8735) - [@&#8203;mcculls](https://github.com/mcculls)) - 🐛 Do not set the hibernate or datanucleus span service name when disabled ([#&#8203;8727](DataDog/dd-trace-java#8727) - [@&#8203;ygree](https://github.com/ygree)) - ✨ Update bytebuddy and ASM to support JDK 24 ([#&#8203;8720](DataDog/dd-trace-java#8720) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) - 🐛 Turn off JDK socket support by default ([#&#8203;8715](DataDog/dd-trace-java#8715) - [@&#8203;mcculls](https://github.com/mcculls)) - 🐛 Log warning when trace buffer overflow occurs ([#&#8203;8712](DataDog/dd-trace-java#8712) - [@&#8203;ygree](https://github.com/ygree)) - ✨🧪 Introducing an internal integration name ([#&#8203;8708](DataDog/dd-trace-java#8708) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Add process tags to client stats payload ([#&#8203;8704](DataDog/dd-trace-java#8704) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Collect process tags for tracing ([#&#8203;8698](DataDog/dd-trace-java#8698) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Stable Config file: target system properties in process_arguments and support template variables in YamlParser ([#&#8203;8690](DataDog/dd-trace-java#8690) - [@&#8203;mtoffl01](https://github.com/mtoffl01)) - ✨⚡ Use prefix trie for proxy ignores ([#&#8203;8678](DataDog/dd-trace-java#8678) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Allow agent to be automatically injected when running aside Log4J patch agent ([#&#8203;8648](DataDog/dd-trace-java#8648) - [@&#8203;paullegranddc](https://github.com/paullegranddc)) - ✨ Use jvmstat for JDKs 9+ programmatically ([#&#8203;8641](DataDog/dd-trace-java#8641) - [@&#8203;MattAlp](https://github.com/MattAlp)) #### Tracer internal logging - 🐛 Delete print line ([#&#8203;8686](DataDog/dd-trace-java#8686) - [@&#8203;sarahchen6](https://github.com/sarahchen6)) ### Instrumentations #### Akka instrumentation - 🐛 Handle reentrant scope cleanup in Akka/Pekko actor instrumentations ([#&#8203;8722](DataDog/dd-trace-java#8722) - [@&#8203;mcculls](https://github.com/mcculls)) #### Apache Spark instrumentation - ✨ Use OpenLineage root parent information to generate trace id ([#&#8203;8726](DataDog/dd-trace-java#8726) - [@&#8203;mobuchowski](https://github.com/mobuchowski)) - ✨ Spark job cancellation no longer marks application as failed ([#&#8203;8701](DataDog/dd-trace-java#8701) - [@&#8203;paul-laffon-dd](https://github.com/paul-laffon-dd)) #### JDBC instrumentation - 💡 Add support for sybase tds jdbc driver ([#&#8203;8764](DataDog/dd-trace-java#8764) - [@&#8203;amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - 🐛 Take defensive copy of parent scope stack when closing nested coroutines ([#&#8203;8749](DataDog/dd-trace-java#8749) - [@&#8203;mcculls](https://github.com/mcculls)) #### Reactor instrumentation - ✨⚡ Do not inspect reactor context when not needed ([#&#8203;8745](DataDog/dd-trace-java#8745) - [@&#8203;amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 795f347ae34d056efc1194c2f606cee7bca1beea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: profiling Profiling type: enhancement Enhancements and improvements

2 participants