Introduce cache for peer.hostname lookup #8601

mcculls · 2025-03-20T22:37:42Z

Motivation

Mitigates potential delays in mapping IP addresses back to their hostnames.

The peer.hostname tag feature can also be turned off completely by adding this JVM option:

-Ddd.trace.peer.hostname.enabled=false

or setting this environment variable:

DD_TRACE_PEER_HOSTNAME_ENABLED=false

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-15123

pr-commenter · 2025-03-20T23:14:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/peer-hostname-cache
git_commit_date	1742520091	1742553874
git_commit_sha	`fe9f968`	`3cf184d`
release_version	1.48.0-SNAPSHOT~fe9f968edb	1.48.0-SNAPSHOT~3cf184dece

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1742556965	1742556965
ci_job_id	858578893	858578893
ci_pipeline_id	59567514	59567514
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-hg2ss1eg-project-304-concurrent-2-oky0v8i6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-hg2ss1eg-project-304-concurrent-2-oky0v8i6 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank

gantt title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section tracing Agent [baseline] (1.047 s) : 0, 1047177 Total [baseline] (8.721 s) : 0, 8720709 Agent [candidate] (1.05 s) : 0, 1049813 Total [candidate] (8.661 s) : 0, 8661021 section iast Agent [baseline] (1.175 s) : 0, 1174662 Total [baseline] (9.241 s) : 0, 9240595 Agent [candidate] (1.172 s) : 0, 1172469 Total [candidate] (9.236 s) : 0, 9236169 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.175 s) : 0, 1174608 Total [baseline] (9.189 s) : 0, 9189170 Agent [candidate] (1.18 s) : 0, 1180368 Total [candidate] (9.237 s) : 0, 9236721 section iast_TELEMETRY_OFF Agent [baseline] (1.171 s) : 0, 1171123 Total [baseline] (9.235 s) : 0, 9234609 Agent [candidate] (1.17 s) : 0, 1170113 Total [candidate] (9.224 s) : 0, 9224106

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.175 s	127.484 ms (12.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.175 s	127.43 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.171 s	123.946 ms (11.8%)
Total	tracing	8.721 s	-
Total	iast	9.241 s	519.885 ms (6.0%)
Total	iast_HARDCODED_SECRET_DISABLED	9.189 s	468.46 ms (5.4%)
Total	iast_TELEMETRY_OFF	9.235 s	513.899 ms (5.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	iast	1.172 s	122.656 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.18 s	130.555 ms (12.4%)
Agent	iast_TELEMETRY_OFF	1.17 s	120.299 ms (11.5%)
Total	tracing	8.661 s	-
Total	iast	9.236 s	575.148 ms (6.6%)
Total	iast_HARDCODED_SECRET_DISABLED	9.237 s	575.7 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.224 s	563.085 ms (6.5%)

gantt title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (723.239 ms) : 0, 723239 BytebuddyAgent [candidate] (723.406 ms) : 0, 723406 GlobalTracer [baseline] (239.854 ms) : 0, 239854 GlobalTracer [candidate] (241.375 ms) : 0, 241375 AppSec [baseline] (54.586 ms) : 0, 54586 AppSec [candidate] (55.181 ms) : 0, 55181 Remote Config [baseline] (695.096 µs) : 0, 695 Remote Config [candidate] (701.355 µs) : 0, 701 Telemetry [baseline] (12.799 ms) : 0, 12799 Telemetry [candidate] (13.047 ms) : 0, 13047 section iast BytebuddyAgent [baseline] (839.96 ms) : 0, 839960 BytebuddyAgent [candidate] (838.2 ms) : 0, 838200 GlobalTracer [baseline] (230.311 ms) : 0, 230311 GlobalTracer [candidate] (230.491 ms) : 0, 230491 IAST [baseline] (23.033 ms) : 0, 23033 IAST [candidate] (22.755 ms) : 0, 22755 AppSec [baseline] (56.037 ms) : 0, 56037 AppSec [candidate] (55.779 ms) : 0, 55779 Remote Config [baseline] (618.334 µs) : 0, 618 Remote Config [candidate] (606.041 µs) : 0, 606 Telemetry [baseline] (8.749 ms) : 0, 8749 Telemetry [candidate] (8.669 ms) : 0, 8669 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (838.798 ms) : 0, 838798 BytebuddyAgent [candidate] (844.743 ms) : 0, 844743 GlobalTracer [baseline] (230.984 ms) : 0, 230984 GlobalTracer [candidate] (231.126 ms) : 0, 231126 IAST [baseline] (23.117 ms) : 0, 23117 IAST [candidate] (22.922 ms) : 0, 22922 AppSec [baseline] (56.353 ms) : 0, 56353 AppSec [candidate] (55.993 ms) : 0, 55993 Remote Config [baseline] (618.608 µs) : 0, 619 Remote Config [candidate] (601.874 µs) : 0, 602 Telemetry [baseline] (8.666 ms) : 0, 8666 Telemetry [candidate] (8.769 ms) : 0, 8769 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (835.893 ms) : 0, 835893 BytebuddyAgent [candidate] (835.699 ms) : 0, 835699 GlobalTracer [baseline] (230.831 ms) : 0, 230831 GlobalTracer [candidate] (230.829 ms) : 0, 230829 IAST [baseline] (22.734 ms) : 0, 22734 IAST [candidate] (22.296 ms) : 0, 22296 AppSec [baseline] (56.278 ms) : 0, 56278 AppSec [candidate] (56.083 ms) : 0, 56083 Remote Config [baseline] (613.839 µs) : 0, 614 Remote Config [candidate] (611.751 µs) : 0, 612 Telemetry [baseline] (8.624 ms) : 0, 8624 Telemetry [candidate] (8.538 ms) : 0, 8538

Startup time reports for petclinic

gantt title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section tracing Agent [baseline] (1.046 s) : 0, 1046341 Total [baseline] (10.485 s) : 0, 10484544 Agent [candidate] (1.044 s) : 0, 1044132 Total [candidate] (10.543 s) : 0, 10543018 section appsec Agent [baseline] (1.184 s) : 0, 1183678 Total [baseline] (10.756 s) : 0, 10755558 Agent [candidate] (1.192 s) : 0, 1192381 Total [candidate] (10.748 s) : 0, 10748443 section iast Agent [baseline] (1.173 s) : 0, 1173378 Total [baseline] (11.055 s) : 0, 11055468 Agent [candidate] (1.175 s) : 0, 1175330 Total [candidate] (11.067 s) : 0, 11067193 section profiling Agent [baseline] (1.26 s) : 0, 1259647 Total [baseline] (10.851 s) : 0, 10851265 Agent [candidate] (1.265 s) : 0, 1264561 Total [candidate] (10.876 s) : 0, 10875702

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	appsec	1.184 s	137.337 ms (13.1%)
Agent	iast	1.173 s	127.038 ms (12.1%)
Agent	profiling	1.26 s	213.306 ms (20.4%)
Total	tracing	10.485 s	-
Total	appsec	10.756 s	271.014 ms (2.6%)
Total	iast	11.055 s	570.925 ms (5.4%)
Total	profiling	10.851 s	366.722 ms (3.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.192 s	148.249 ms (14.2%)
Agent	iast	1.175 s	131.198 ms (12.6%)
Agent	profiling	1.265 s	220.429 ms (21.1%)
Total	tracing	10.543 s	-
Total	appsec	10.748 s	205.425 ms (1.9%)
Total	iast	11.067 s	524.175 ms (5.0%)
Total	profiling	10.876 s	332.684 ms (3.2%)

gantt title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (720.614 ms) : 0, 720614 BytebuddyAgent [candidate] (718.856 ms) : 0, 718856 GlobalTracer [baseline] (240.028 ms) : 0, 240028 GlobalTracer [candidate] (239.485 ms) : 0, 239485 AppSec [baseline] (54.701 ms) : 0, 54701 AppSec [candidate] (54.651 ms) : 0, 54651 Remote Config [baseline] (691.108 µs) : 0, 691 Remote Config [candidate] (706.996 µs) : 0, 707 Telemetry [baseline] (14.243 ms) : 0, 14243 Telemetry [candidate] (14.417 ms) : 0, 14417 section appsec BytebuddyAgent [baseline] (735.781 ms) : 0, 735781 BytebuddyAgent [candidate] (741.097 ms) : 0, 741097 GlobalTracer [baseline] (236.196 ms) : 0, 236196 GlobalTracer [candidate] (237.812 ms) : 0, 237812 AppSec [baseline] (176.039 ms) : 0, 176039 AppSec [candidate] (177.569 ms) : 0, 177569 Remote Config [baseline] (654.157 µs) : 0, 654 Remote Config [candidate] (664.025 µs) : 0, 664 Telemetry [baseline] (8.261 ms) : 0, 8261 Telemetry [candidate] (8.362 ms) : 0, 8362 IAST [baseline] (21.548 ms) : 0, 21548 IAST [candidate] (21.617 ms) : 0, 21617 section iast BytebuddyAgent [baseline] (838.5 ms) : 0, 838500 BytebuddyAgent [candidate] (839.81 ms) : 0, 839810 GlobalTracer [baseline] (230.294 ms) : 0, 230294 GlobalTracer [candidate] (230.664 ms) : 0, 230664 AppSec [baseline] (56.214 ms) : 0, 56214 AppSec [candidate] (56.91 ms) : 0, 56910 Remote Config [baseline] (606.112 µs) : 0, 606 Remote Config [candidate] (625.511 µs) : 0, 626 Telemetry [baseline] (8.806 ms) : 0, 8806 Telemetry [candidate] (8.766 ms) : 0, 8766 IAST [baseline] (22.891 ms) : 0, 22891 IAST [candidate] (22.66 ms) : 0, 22660 section profiling BytebuddyAgent [baseline] (709.067 ms) : 0, 709067 BytebuddyAgent [candidate] (711.514 ms) : 0, 711514 GlobalTracer [baseline] (349.166 ms) : 0, 349166 GlobalTracer [candidate] (351.08 ms) : 0, 351080 AppSec [baseline] (54.309 ms) : 0, 54309 AppSec [candidate] (53.875 ms) : 0, 53875 Remote Config [baseline] (709.88 µs) : 0, 710 Remote Config [candidate] (711.183 µs) : 0, 711 Telemetry [baseline] (8.911 ms) : 0, 8911 Telemetry [candidate] (9.031 ms) : 0, 9031 ProfilingAgent [baseline] (95.937 ms) : 0, 95937 ProfilingAgent [candidate] (96.708 ms) : 0, 96708 Profiling [baseline] (95.961 ms) : 0, 95961 Profiling [candidate] (96.732 ms) : 0, 96732

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-03-21T11:06:19	2025-03-21T11:14:03
git_branch	master	mcculls/peer-hostname-cache
git_commit_date	1742520091	1742553874
git_commit_sha	`fe9f968`	`3cf184d`
release_version	1.48.0-SNAPSHOT~fe9f968edb	1.48.0-SNAPSHOT~3cf184dece
start_time	2025-03-21T11:06:05	2025-03-21T11:13:49

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1742556040	1742556040
ci_job_id	858578895	858578895
ci_pipeline_id	59567514	59567514
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-hg2ss1eg-project-304-concurrent-3-foym5khm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-hg2ss1eg-project-304-concurrent-3-foym5khm 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section baseline no_agent (384.457 µs) : 364, 405 . : milestone, 384, iast (518.839 µs) : 497, 540 . : milestone, 519, iast_FULL (730.103 µs) : 708, 752 . : milestone, 730, iast_GLOBAL (561.972 µs) : 540, 584 . : milestone, 562, iast_HARDCODED_SECRET_DISABLED (515.06 µs) : 493, 537 . : milestone, 515, iast_INACTIVE (467.845 µs) : 445, 491 . : milestone, 468, iast_TELEMETRY_OFF (501.659 µs) : 479, 525 . : milestone, 502, tracing (464.06 µs) : 443, 486 . : milestone, 464, section candidate no_agent (380.918 µs) : 361, 401 . : milestone, 381, iast (515.896 µs) : 494, 538 . : milestone, 516, iast_FULL (730.561 µs) : 708, 753 . : milestone, 731, iast_GLOBAL (561.374 µs) : 540, 583 . : milestone, 561, iast_HARDCODED_SECRET_DISABLED (512.318 µs) : 491, 534 . : milestone, 512, iast_INACTIVE (468.808 µs) : 448, 490 . : milestone, 469, iast_TELEMETRY_OFF (508.58 µs) : 487, 531 . : milestone, 509, tracing (460.36 µs) : 439, 481 . : milestone, 460,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	384.457 µs [364.107 µs, 404.808 µs]	-
iast	518.839 µs [497.283 µs, 540.395 µs]	134.382 µs (35.0%)
iast_FULL	730.103 µs [708.205 µs, 752.001 µs]	345.645 µs (89.9%)
iast_GLOBAL	561.972 µs [539.64 µs, 584.303 µs]	177.514 µs (46.2%)
iast_HARDCODED_SECRET_DISABLED	515.06 µs [493.351 µs, 536.768 µs]	130.602 µs (34.0%)
iast_INACTIVE	467.845 µs [444.783 µs, 490.908 µs]	83.388 µs (21.7%)
iast_TELEMETRY_OFF	501.659 µs [478.632 µs, 524.687 µs]	117.202 µs (30.5%)
tracing	464.06 µs [442.549 µs, 485.571 µs]	79.602 µs (20.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	380.918 µs [361.302 µs, 400.534 µs]	-
iast	515.896 µs [494.161 µs, 537.63 µs]	134.978 µs (35.4%)
iast_FULL	730.561 µs [708.289 µs, 752.833 µs]	349.643 µs (91.8%)
iast_GLOBAL	561.374 µs [539.528 µs, 583.22 µs]	180.456 µs (47.4%)
iast_HARDCODED_SECRET_DISABLED	512.318 µs [490.952 µs, 533.685 µs]	131.4 µs (34.5%)
iast_INACTIVE	468.808 µs [447.59 µs, 490.026 µs]	87.89 µs (23.1%)
iast_TELEMETRY_OFF	508.58 µs [486.535 µs, 530.625 µs]	127.662 µs (33.5%)
tracing	460.36 µs [439.357 µs, 481.364 µs]	79.442 µs (20.9%)

Request duration reports for petclinic

gantt title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section baseline no_agent (1.352 ms) : 1332, 1372 . : milestone, 1352, appsec (1.718 ms) : 1694, 1741 . : milestone, 1718, appsec_no_iast (1.745 ms) : 1720, 1770 . : milestone, 1745, code_origins (1.679 ms) : 1652, 1707 . : milestone, 1679, iast (1.514 ms) : 1489, 1538 . : milestone, 1514, profiling (1.527 ms) : 1503, 1550 . : milestone, 1527, tracing (1.474 ms) : 1449, 1500 . : milestone, 1474, section candidate no_agent (1.364 ms) : 1344, 1384 . : milestone, 1364, appsec (1.728 ms) : 1705, 1752 . : milestone, 1728, appsec_no_iast (1.716 ms) : 1690, 1741 . : milestone, 1716, code_origins (1.673 ms) : 1646, 1701 . : milestone, 1673, iast (1.512 ms) : 1487, 1536 . : milestone, 1512, profiling (1.514 ms) : 1491, 1536 . : milestone, 1514, tracing (1.485 ms) : 1460, 1510 . : milestone, 1485,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.352 ms [1.332 ms, 1.372 ms]	-
appsec	1.718 ms [1.694 ms, 1.741 ms]	365.43 µs (27.0%)
appsec_no_iast	1.745 ms [1.72 ms, 1.77 ms]	393.22 µs (29.1%)
code_origins	1.679 ms [1.652 ms, 1.707 ms]	327.424 µs (24.2%)
iast	1.514 ms [1.489 ms, 1.538 ms]	161.813 µs (12.0%)
profiling	1.527 ms [1.503 ms, 1.55 ms]	174.606 µs (12.9%)
tracing	1.474 ms [1.449 ms, 1.5 ms]	122.264 µs (9.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.364 ms [1.344 ms, 1.384 ms]	-
appsec	1.728 ms [1.705 ms, 1.752 ms]	364.052 µs (26.7%)
appsec_no_iast	1.716 ms [1.69 ms, 1.741 ms]	351.682 µs (25.8%)
code_origins	1.673 ms [1.646 ms, 1.701 ms]	309.123 µs (22.7%)
iast	1.512 ms [1.487 ms, 1.536 ms]	147.521 µs (10.8%)
profiling	1.514 ms [1.491 ms, 1.536 ms]	149.455 µs (11.0%)
tracing	1.485 ms [1.46 ms, 1.51 ms]	120.931 µs (8.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/peer-hostname-cache
git_commit_date	1742520091	1742553874
git_commit_sha	`fe9f968`	`3cf184d`
release_version	1.48.0-SNAPSHOT~fe9f968edb	1.48.0-SNAPSHOT~3cf184dece

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1742556554	1742556554
ci_job_id	858578896	858578896
ci_pipeline_id	59567514	59567514
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-9zkhhzg4-project-304-concurrent-1-cvmb2s52 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-9zkhhzg4-project-304-concurrent-1-cvmb2s52 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section baseline no_agent (1.476 ms) : 1465, 1488 . : milestone, 1476, appsec (2.369 ms) : 2323, 2414 . : milestone, 2369, iast (2.14 ms) : 2083, 2197 . : milestone, 2140, iast_GLOBAL (2.184 ms) : 2126, 2241 . : milestone, 2184, profiling (2.263 ms) : 2120, 2407 . : milestone, 2263, tracing (1.965 ms) : 1921, 2008 . : milestone, 1965, section candidate no_agent (1.476 ms) : 1465, 1488 . : milestone, 1476, appsec (2.362 ms) : 2317, 2407 . : milestone, 2362, iast (2.145 ms) : 2087, 2202 . : milestone, 2145, iast_GLOBAL (2.181 ms) : 2124, 2238 . : milestone, 2181, profiling (1.983 ms) : 1938, 2028 . : milestone, 1983, tracing (1.954 ms) : 1910, 1997 . : milestone, 1954,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.369 ms [2.323 ms, 2.414 ms]	892.357 µs (60.5%)
iast	2.14 ms [2.083 ms, 2.197 ms]	663.718 µs (45.0%)
iast_GLOBAL	2.184 ms [2.126 ms, 2.241 ms]	707.538 µs (47.9%)
profiling	2.263 ms [2.12 ms, 2.407 ms]	787.293 µs (53.3%)
tracing	1.965 ms [1.921 ms, 2.008 ms]	488.393 µs (33.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.465 ms, 1.488 ms]	-
appsec	2.362 ms [2.317 ms, 2.407 ms]	885.356 µs (60.0%)
iast	2.145 ms [2.087 ms, 2.202 ms]	668.372 µs (45.3%)
iast_GLOBAL	2.181 ms [2.124 ms, 2.238 ms]	704.462 µs (47.7%)
profiling	1.983 ms [1.938 ms, 2.028 ms]	506.798 µs (34.3%)
tracing	1.954 ms [1.91 ms, 1.997 ms]	477.224 µs (32.3%)

Execution time for biojava

gantt title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~3cf184dece, baseline=1.48.0-SNAPSHOT~fe9f968edb dateFormat X axisFormat %s section baseline no_agent (15.306 s) : 15306000, 15306000 . : milestone, 15306000, appsec (15.202 s) : 15202000, 15202000 . : milestone, 15202000, iast (18.752 s) : 18752000, 18752000 . : milestone, 18752000, iast_GLOBAL (18.073 s) : 18073000, 18073000 . : milestone, 18073000, profiling (15.834 s) : 15834000, 15834000 . : milestone, 15834000, tracing (15.254 s) : 15254000, 15254000 . : milestone, 15254000, section candidate no_agent (15.59 s) : 15590000, 15590000 . : milestone, 15590000, appsec (15.033 s) : 15033000, 15033000 . : milestone, 15033000, iast (18.979 s) : 18979000, 18979000 . : milestone, 18979000, iast_GLOBAL (18.187 s) : 18187000, 18187000 . : milestone, 18187000, profiling (15.107 s) : 15107000, 15107000 . : milestone, 15107000, tracing (15.212 s) : 15212000, 15212000 . : milestone, 15212000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.306 s [15.306 s, 15.306 s]	-
appsec	15.202 s [15.202 s, 15.202 s]	-104.0 ms (-0.7%)
iast	18.752 s [18.752 s, 18.752 s]	3.446 s (22.5%)
iast_GLOBAL	18.073 s [18.073 s, 18.073 s]	2.767 s (18.1%)
profiling	15.834 s [15.834 s, 15.834 s]	528.0 ms (3.4%)
tracing	15.254 s [15.254 s, 15.254 s]	-52.0 ms (-0.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.59 s [15.59 s, 15.59 s]	-
appsec	15.033 s [15.033 s, 15.033 s]	-557.0 ms (-3.6%)
iast	18.979 s [18.979 s, 18.979 s]	3.389 s (21.7%)
iast_GLOBAL	18.187 s [18.187 s, 18.187 s]	2.597 s (16.7%)
profiling	15.107 s [15.107 s, 15.107 s]	-483.0 ms (-3.1%)
tracing	15.212 s [15.212 s, 15.212 s]	-378.0 ms (-2.4%)

mcculls · 2025-03-21T10:45:30Z

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/decorator/BaseDecorator.java

 },
 Functions.PrefixJoin.of("."));

+ private static final DDCache<String, String> HOSTNAME_CACHE = DDCaches.newFixedSizeCache(64);


@dougqh do you have any thoughts on sizing this cache?

ygree

LGTM

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | org.flywaydb.flyway | plugin | misk/gradle/libs.versions.toml | gradle | minor | `11.6.0` -> `11.7.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.10.2` -> `3.11.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.15.0` -> `2.16.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.47.3` -> `1.48.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.18` -> `2.31.20` | --- ### Release Notes <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.11.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3110) *2025-04-09* - Fix: Clear the deflater's byte array reference - New: Faster implementation of `String.decodeHex()` on Kotlin/JS. - New: Declare `EXACTLY_ONCE` execution for blocks like `Closeable.use {}` and `FileSystem.read {}`. - Upgrade: \[Kotlin 2.1.20]\[kotlin\_2\_1\_20]. </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.16.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-2160) - \[Feat]: support `com.android.test` projects. - \[Feat]: support typesafe project accessors with opt-in. ```kotlin dependencyAnalysis { useTypesafeProjectAccessors(true) // false by default } ``` </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.48.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.1): 1.48.1 ### Components #### Tracer internal logging - 🐛 Remove print line causing unnecessary logs ([#8687](DataDog/dd-trace-java#8687) - [@sarahchen6](https://github.com/sarahchen6)) ### [`v1.48.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.48.0): 1.48.0 ### Known Bugs > \[!NOTE] > If you are experiencing issues with spamming timeout logs, please update to the [latest version](https://github.com/DataDog/dd-trace-java/releases/latest) or set [JDK_SOCKET_ENABLED](https://github.com/DataDog/dd-trace-java/blob/33fc3c9a9b7cda3beda88b8b3e5224ae2b10764a/dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java#L98) to false. ### Components #### Application Security Management (IAST) - ✨ Fix vulnerability location org.jose4j.lang.HashUtil ([#8610](DataDog/dd-trace-java#8610) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness in oracle.ucp.util.OpaqueString ([#8609](DataDog/dd-trace-java#8609) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak hash false positive in oracle.security.o5logon.O5Logon ([#8608](DataDog/dd-trace-java#8608) - [@jandro996](https://github.com/jandro996)) - 🐛 Prevent before callsites targeting constructors in super calls ([#8549](DataDog/dd-trace-java#8549) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Application Security Management (WAF) - ✨ Update login events public SDK to V2 ([#8620](DataDog/dd-trace-java#8620) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#8573](DataDog/dd-trace-java#8573) - [@jandro996](https://github.com/jandro996)) - ✨ Improve detection of missing request end events ([#8510](DataDog/dd-trace-java#8510) - [@smola](https://github.com/smola)) - 🧹 Remove remote configuration for API Security sampling rate ([#8486](DataDog/dd-trace-java#8486) - [@smola](https://github.com/smola)) - ✨ Add setUser to user monitoring SDK ([#8482](DataDog/dd-trace-java#8482) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add missing address for signup event ([#8469](DataDog/dd-trace-java#8469) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Allow login events SDK to be used with appsec disabled ([#8464](DataDog/dd-trace-java#8464) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for endpoint discovery in spring mvc ([#8352](DataDog/dd-trace-java#8352) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ New API Security sampling algorithm ([#8178](DataDog/dd-trace-java#8178) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Build & Tooling - ✨ Add buffer size customizability to JDK UDS support ([#8629](DataDog/dd-trace-java#8629) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Add JDK built-in support for UDS on Java 16+ ([#8314](DataDog/dd-trace-java#8314) - [@sarahchen6](https://github.com/sarahchen6)) #### Configuration at Runtime - 🐛 Send RASP LFI capability only when AppSec is statically enabled ([#8573](DataDog/dd-trace-java#8573) - [@jandro996](https://github.com/jandro996)) #### Continuous Integration Visibility - 🐛 Prevent double reporting of Scalatest events when using SBT with test forking ([#8682](DataDog/dd-trace-java#8682) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Shutdown CI Visibility test event handlers before tracer ([#8677](DataDog/dd-trace-java#8677) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Do not apply JUnit 4 instrumentation to MUnit runners ([#8675](DataDog/dd-trace-java#8675), [#8683](DataDog/dd-trace-java#8683) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Remove error log when source path resolution fails on isModified check ([#8663](DataDog/dd-trace-java#8663) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement tests reordering for JUnit 4 ([#8650](DataDog/dd-trace-java#8650) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Set default Attempt to Fix retries if none provided from the backend ([#8615](DataDog/dd-trace-java#8615) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Allow to manually set PR info ([#8566](DataDog/dd-trace-java#8566) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Test Optimization init when repo root cannot be determined ([#8533](DataDog/dd-trace-java#8533) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add capabilities tagging ([#8499](DataDog/dd-trace-java#8499), [#8540](DataDog/dd-trace-java#8540) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Crash tracking - 🐛 Remove dependency on bash from crash/oome uploder scripts ([#8652](DataDog/dd-trace-java#8652) - [@jbachorik](https://github.com/jbachorik)) #### Data Streams Monitoring - ✨ e2e pipeline configuration when data jobs is enabled ([#8553](DataDog/dd-trace-java#8553) - [@kr-igor](https://github.com/kr-igor)) #### Dynamic Instrumentation - 🐛 Fix In-Product when config is empty ([#8679](DataDog/dd-trace-java#8679) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add support for filtering shaded third-party libs ([#8612](DataDog/dd-trace-java#8612) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add In-Product Enablement ([#8587](DataDog/dd-trace-java#8587) - [@jpbempel](https://github.com/jpbempel)) - ✨⚡ Reduce footprint of SourceFile tracking ([#8524](DataDog/dd-trace-java#8524) - [@jpbempel](https://github.com/jpbempel)) - ✨⚡ Optimize the SourceFile tracking ([#8520](DataDog/dd-trace-java#8520) - [@jpbempel](https://github.com/jpbempel)) #### OpenTracing - 🧹 Remove activeScope() use in OpenTracing shim ([#8478](DataDog/dd-trace-java#8478) - [@mcculls](https://github.com/mcculls)) #### Profiling - ✨ Add profiler env check command to AgentCLI ([#8671](DataDog/dd-trace-java#8671) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.23.0 ([#8668](DataDog/dd-trace-java#8668) - [@jbachorik](https://github.com/jbachorik)) - Fix a crash related to ElfParser::loadSymbolTable ([#191](DataDog/dd-trace-java#191)) by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#192 - Unwind String.indexOf intrinsic on AArch64 by [@MattAlp](https://github.com/MattAlp) in DataDog/java-profiler#193 - Fix Java 24 support by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#194 - A set of fixes related to clang, aarch64 and musl pecularities of vmstructs stack unwinder by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#199 - 🐛 Remove process information from JFR recording ([#8661](DataDog/dd-trace-java#8661) - [@r1viollet](https://github.com/r1viollet)) - 🐛 Make TempLocationManager USER aware ([#8605](DataDog/dd-trace-java#8605) - [@jbachorik](https://github.com/jbachorik)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#8561](DataDog/dd-trace-java#8561) - [@wmouchere](https://github.com/wmouchere)) #### Telemetry - 🐛 Fix appsec.rasp.error and appsec.waf.error telemetry metrics ([#8624](DataDog/dd-trace-java#8624) - [@jandro996](https://github.com/jandro996)) - ✨ Create metric: appsec.rasp.rule.skipped ([#8618](DataDog/dd-trace-java#8618) - [@jandro996](https://github.com/jandro996)) - ✨ Extract git tags from embedded git.properties and datadog_git.properties ([#8561](DataDog/dd-trace-java#8561) - [@wmouchere](https://github.com/wmouchere)) #### Testing - 🧹 Simplify ssi tests one-pipeline ([#8558](DataDog/dd-trace-java#8558) - [@robertomonteromiguel](https://github.com/robertomonteromiguel)) - ✨ Add smoke tests for java's concurrent API ([#8438](DataDog/dd-trace-java#8438) - [@sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - ✨ Adding Support for `TRACE_PROPAGATION_BEHAVIOR_EXTRACT` ([#8535](DataDog/dd-trace-java#8535) - [@mhlidd](https://github.com/mhlidd)) #### Tracer core - 🐛 Ensure shaded helpers have unique names ([#8559](DataDog/dd-trace-java#8559) - [@amarziali](https://github.com/amarziali)) - ✨ Support common config sources for user-provided git info ([#8547](DataDog/dd-trace-java#8547) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Make the default config sources more robust when a security manager is installed ([#8544](DataDog/dd-trace-java#8544) - [@mcculls](https://github.com/mcculls)) - ✨ Support targeting services with configurations in stable configuration file ([#8526](DataDog/dd-trace-java#8526) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Add new parser for `DD_TAGS` and prioritizing `DD_SERVICE` ([#8296](DataDog/dd-trace-java#8296) - [@mhlidd](https://github.com/mhlidd)) #### Tracer internal logging - 🐛 Add missing debug log for the cloudPayloadTaggingServices config ([#8600](DataDog/dd-trace-java#8600) - [@ygree](https://github.com/ygree)) - ✨ Add the possibility to output the logs of the Java tracer in JSON ([#8083](DataDog/dd-trace-java#8083) - [@cecile75](https://github.com/cecile75)) #### Tracer public API - ✨ Introducing `DD_TRACE_EXPERIMENTAL_FEATURES_ENABLED` Config ([#8536](DataDog/dd-trace-java#8536) - [@mhlidd](https://github.com/mhlidd)) - ✨ Config Consistency Round 2 ([#8489](DataDog/dd-trace-java#8489) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### - 🐛 Fix NPE in getMdcCopy of LoggingEventInstrumentation ([#8599](DataDog/dd-trace-java#8599) - [@ygree](https://github.com/ygree)) #### Apache Spark instrumentation - ✨ Instrument Runtime.exit() to finish spark application spans ([#8572](DataDog/dd-trace-java#8572) - [@paul-laffon-dd](https://github.com/paul-laffon-dd)) - ✨ Configure OpenLineage if present in Spark instrumentation ([#8541](DataDog/dd-trace-java#8541) - [@mobuchowski](https://github.com/mobuchowski)) #### Armeria Instrumentation - ✨ Support armeria grpc 1.32.3 ([#8606](DataDog/dd-trace-java#8606) - [@github-actions](https://github.com/github-actions)\[bot]) #### AWS DynamoDB Instrumentation - ✨ Create DynamoDB instrumentation + add span pointers for `updateItem` and `deleteItem` ([#8490](DataDog/dd-trace-java#8490) - [@nhulston](https://github.com/nhulston)) #### AWS SDK instrumentation - ✨ Add DynamoDB in DEFAULT_TRACE_CLOUD_PAYLOAD_TAGGING_SERVICES ([#8595](DataDog/dd-trace-java#8595) - [@joeyzhao2018](https://github.com/joeyzhao2018)) #### Azure Functions instrumentation - ✨ Enable tracer computed trace metrics by default for Azure Functions ([#8518](DataDog/dd-trace-java#8518) - [@duncanpharvey](https://github.com/duncanpharvey)) - 💡 Add azure-functions instrumentation ([#8432](DataDog/dd-trace-java#8432) - [@duncanpharvey](https://github.com/duncanpharvey)) #### Core Java language instrumentation - 🐛 Fix ForkJoinPool.execute() instrumentation on Java 21+ ([#8560](DataDog/dd-trace-java#8560) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Eclipse Vert.x instrumentation - ✨ Add vertx postgresql client instrumentation ([#8471](DataDog/dd-trace-java#8471) - [@vandonr](https://github.com/vandonr) - thanks for the contribution!) #### Kafka instrumentation - ✨ Support and test kafka-clients 4 ([#8581](DataDog/dd-trace-java#8581) - [@amarziali](https://github.com/amarziali)) #### Kotlin instrumentation - ✨ Avoid disconnected traces when using Kotlin flowOn ([#8651](DataDog/dd-trace-java#8651) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🧹 Migrate OtelContext wrapper to new internal Context API ([#8645](DataDog/dd-trace-java#8645) - [@mcculls](https://github.com/mcculls)) #### Spring instrumentation - 🐛 Support CompletableFuture on spring webmvc controllers ([#8659](DataDog/dd-trace-java#8659) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for endpoint discovery in spring mvc ([#8352](DataDog/dd-trace-java#8352) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### WebSocket Instrumentation - ✨ Instrument Jetty websocket pojo ([#8562](DataDog/dd-trace-java#8562) - [@amarziali](https://github.com/amarziali)) - 💡 Instrument Java Websocket API (JSR356) ([#8440](DataDog/dd-trace-java#8440) - [@amarziali](https://github.com/amarziali)) #### All other instrumentations - ✨ Introduce cache for peer.hostname lookup ([#8601](DataDog/dd-trace-java#8601) - [@mcculls](https://github.com/mcculls)) - ✨ Support pekko http 1.1 ([#8532](DataDog/dd-trace-java#8532) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 331314f71acaced3adc75ea5d7e855c248d593fc

mcculls added type: enhancement Enhancements and improvements inst: others All other instrumentations labels Mar 20, 2025

mcculls marked this pull request as ready for review March 20, 2025 23:43

mcculls requested a review from a team as a code owner March 20, 2025 23:43

mcculls requested review from dougqh and ygree March 20, 2025 23:43

amarziali approved these changes Mar 21, 2025

View reviewed changes

mcculls added 2 commits March 21, 2025 10:44

Introduce cache for peer.hostname lookup

20c6a3d

Add switch to turn off peer.hostname collection

3cf184d

mcculls force-pushed the mcculls/peer-hostname-cache branch from b992e6f to 3cf184d Compare March 21, 2025 10:44

mcculls commented Mar 21, 2025

View reviewed changes

ygree approved these changes Mar 21, 2025

View reviewed changes

mcculls mentioned this pull request Mar 24, 2025

🍒 8601 - Introduce cache for peer.hostname lookup #8611

Merged

mcculls merged commit b1c322b into master Mar 24, 2025
272 checks passed

mcculls deleted the mcculls/peer-hostname-cache branch March 24, 2025 10:35

github-actions bot added this to the 1.48.0 milestone Mar 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce cache for peer.hostname lookup #8601

Introduce cache for peer.hostname lookup #8601

Uh oh!

mcculls commented Mar 20, 2025 •

edited

Loading

pr-commenter bot commented Mar 20, 2025 •

edited

Loading

mcculls Mar 21, 2025

ygree left a comment

Uh oh!

Labels

3 participants

Introduce cache for peer.hostname lookup #8601

Introduce cache for peer.hostname lookup #8601

Uh oh!

Conversation

mcculls commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Contributor Checklist

pr-commenter bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

mcculls Mar 21, 2025

Choose a reason for hiding this comment

ygree left a comment

Choose a reason for hiding this comment

Uh oh!

Labels

3 participants

mcculls commented Mar 20, 2025 •

edited

Loading

pr-commenter bot commented Mar 20, 2025 •

edited

Loading