Skip to content

Improve crash tracking install logging #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Improve crash tracking install logging #8045

merged 1 commit into from
Dec 3, 2024

Conversation

PerfectSlayer
Copy link
Contributor

@PerfectSlayer PerfectSlayer commented Dec 2, 2024 •
edited
Loading

What Does This Do

This PR avoids logging stack trace when failing to clean up previous crash tracking configuration files.

Motivation

Avoid showing exception message to the customers for clean up operations

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]
@PerfectSlayer PerfectSlayer added type: enhancement Enhancements and improvements comp: crash tracking Crash tracking labels Dec 2, 2024
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner December 2, 2024 11:34
@PerfectSlayer
fix(crash-tracking): Remove exception logging
f81944e 
Only log exception in debug mode Decrease the log level
@PerfectSlayer PerfectSlayer enabled auto-merge (squash) December 2, 2024 11:58
@pr-commenter
Copy link

pr-commenter bot commented Dec 2, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1733140469 1733140653
git_commit_sha 722c8f7 f81944e
release_version 1.44.0-SNAPSHOT~722c8f7af5 1.44.0-SNAPSHOT~f81944e79f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733143093 1733143093
ci_job_id 724367698 724367698
ci_pipeline_id 50203567 50203567
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 10 unstable metrics.

Startup time reports for insecure-bank 
gantt title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section tracing Agent [baseline] (1.099 s) : 0, 1099471 Total [baseline] (8.679 s) : 0, 8678959 Agent [candidate] (1.087 s) : 0, 1086623 Total [candidate] (8.655 s) : 0, 8655388 section iast Agent [baseline] (1.219 s) : 0, 1218912 Total [baseline] (9.191 s) : 0, 9190518 Agent [candidate] (1.222 s) : 0, 1221512 Total [candidate] (9.217 s) : 0, 9216766 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.221 s) : 0, 1221212 Total [baseline] (9.203 s) : 0, 9202837 Agent [candidate] (1.219 s) : 0, 1218519 Total [candidate] (9.161 s) : 0, 9160935 section iast_TELEMETRY_OFF Agent [baseline] (1.22 s) : 0, 1220146 Total [baseline] (9.164 s) : 0, 9164480 Agent [candidate] (1.223 s) : 0, 1223351 Total [candidate] (9.232 s) : 0, 9231720
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.099 s -
Agent iast 1.219 s 119.441 ms (10.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.221 s 121.741 ms (11.1%)
Agent iast_TELEMETRY_OFF 1.22 s 120.675 ms (11.0%)
Total tracing 8.679 s -
Total iast 9.191 s 511.559 ms (5.9%)
Total iast_HARDCODED_SECRET_DISABLED 9.203 s 523.878 ms (6.0%)
Total iast_TELEMETRY_OFF 9.164 s 485.521 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent iast 1.222 s 134.889 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.219 s 131.895 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.223 s 136.728 ms (12.6%)
Total tracing 8.655 s -
Total iast 9.217 s 561.378 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.161 s 505.547 ms (5.8%)
Total iast_TELEMETRY_OFF 9.232 s 576.332 ms (6.7%) 
gantt title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (700.593 ms) : 0, 700593 BytebuddyAgent [candidate] (691.867 ms) : 0, 691867 GlobalTracer [baseline] (319.943 ms) : 0, 319943 GlobalTracer [candidate] (316.712 ms) : 0, 316712 AppSec [baseline] (55.324 ms) : 0, 55324 AppSec [candidate] (54.543 ms) : 0, 54543 Remote Config [baseline] (692.308 µs) : 0, 692 Remote Config [candidate] (669.838 µs) : 0, 670 Telemetry [baseline] (9.153 ms) : 0, 9153 Telemetry [candidate] (9.143 ms) : 0, 9143 section iast BytebuddyAgent [baseline] (812.393 ms) : 0, 812393 BytebuddyAgent [candidate] (813.549 ms) : 0, 813549 GlobalTracer [baseline] (305.702 ms) : 0, 305702 GlobalTracer [candidate] (307.145 ms) : 0, 307145 AppSec [baseline] (57.377 ms) : 0, 57377 AppSec [candidate] (57.409 ms) : 0, 57409 Remote Config [baseline] (621.889 µs) : 0, 622 Remote Config [candidate] (613.211 µs) : 0, 613 Telemetry [baseline] (7.464 ms) : 0, 7464 Telemetry [candidate] (7.471 ms) : 0, 7471 IAST [baseline] (21.675 ms) : 0, 21675 IAST [candidate] (21.603 ms) : 0, 21603 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (812.293 ms) : 0, 812293 BytebuddyAgent [candidate] (811.416 ms) : 0, 811416 GlobalTracer [baseline] (307.219 ms) : 0, 307219 GlobalTracer [candidate] (306.463 ms) : 0, 306463 AppSec [baseline] (56.219 ms) : 0, 56219 AppSec [candidate] (57.906 ms) : 0, 57906 Remote Config [baseline] (641.246 µs) : 0, 641 Remote Config [candidate] (632.875 µs) : 0, 633 Telemetry [baseline] (7.508 ms) : 0, 7508 Telemetry [candidate] (7.429 ms) : 0, 7429 IAST [baseline] (23.615 ms) : 0, 23615 IAST [candidate] (20.894 ms) : 0, 20894 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (813.02 ms) : 0, 813020 BytebuddyAgent [candidate] (814.423 ms) : 0, 814423 GlobalTracer [baseline] (306.47 ms) : 0, 306470 GlobalTracer [candidate] (307.965 ms) : 0, 307965 AppSec [baseline] (58.305 ms) : 0, 58305 AppSec [candidate] (58.435 ms) : 0, 58435 Remote Config [baseline] (631.226 µs) : 0, 631 Remote Config [candidate] (624.663 µs) : 0, 625 Telemetry [baseline] (7.434 ms) : 0, 7434 Telemetry [candidate] (7.494 ms) : 0, 7494 IAST [baseline] (20.564 ms) : 0, 20564 IAST [candidate] (20.6 ms) : 0, 20600
Loading
Startup time reports for petclinic 
gantt title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section tracing Agent [baseline] (1.097 s) : 0, 1096514 Total [baseline] (10.526 s) : 0, 10525593 Agent [candidate] (1.097 s) : 0, 1096579 Total [candidate] (10.53 s) : 0, 10530035 section appsec Agent [baseline] (1.227 s) : 0, 1227023 Total [baseline] (10.748 s) : 0, 10748261 Agent [candidate] (1.233 s) : 0, 1233318 Total [candidate] (10.817 s) : 0, 10816734 section iast Agent [baseline] (1.223 s) : 0, 1223415 Total [baseline] (11.045 s) : 0, 11044501 Agent [candidate] (1.218 s) : 0, 1218251 Total [candidate] (10.97 s) : 0, 10969814 section profiling Agent [baseline] (1.313 s) : 0, 1312769 Total [baseline] (10.818 s) : 0, 10818120 Agent [candidate] (1.316 s) : 0, 1316135 Total [candidate] (10.805 s) : 0, 10804980
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.227 s 130.51 ms (11.9%)
Agent iast 1.223 s 126.902 ms (11.6%)
Agent profiling 1.313 s 216.256 ms (19.7%)
Total tracing 10.526 s -
Total appsec 10.748 s 222.667 ms (2.1%)
Total iast 11.045 s 518.908 ms (4.9%)
Total profiling 10.818 s 292.527 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.097 s -
Agent appsec 1.233 s 136.739 ms (12.5%)
Agent iast 1.218 s 121.673 ms (11.1%)
Agent profiling 1.316 s 219.556 ms (20.0%)
Total tracing 10.53 s -
Total appsec 10.817 s 286.699 ms (2.7%)
Total iast 10.97 s 439.78 ms (4.2%)
Total profiling 10.805 s 274.946 ms (2.6%) 
gantt title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (696.807 ms) : 0, 696807 BytebuddyAgent [candidate] (699.06 ms) : 0, 699060 GlobalTracer [baseline] (318.836 ms) : 0, 318836 GlobalTracer [candidate] (318.643 ms) : 0, 318643 AppSec [baseline] (54.971 ms) : 0, 54971 AppSec [candidate] (55.145 ms) : 0, 55145 Remote Config [baseline] (682.473 µs) : 0, 682 Remote Config [candidate] (687.753 µs) : 0, 688 Telemetry [baseline] (11.43 ms) : 0, 11430 Telemetry [candidate] (9.231 ms) : 0, 9231 section appsec BytebuddyAgent [baseline] (713.165 ms) : 0, 713165 BytebuddyAgent [candidate] (718.173 ms) : 0, 718173 GlobalTracer [baseline] (314.786 ms) : 0, 314786 GlobalTracer [candidate] (315.201 ms) : 0, 315201 AppSec [baseline] (166.718 ms) : 0, 166718 AppSec [candidate] (167.176 ms) : 0, 167176 Remote Config [baseline] (644.374 µs) : 0, 644 Remote Config [candidate] (645.609 µs) : 0, 646 Telemetry [baseline] (8.165 ms) : 0, 8165 Telemetry [candidate] (8.647 ms) : 0, 8647 IAST [baseline] (19.669 ms) : 0, 19669 IAST [candidate] (19.298 ms) : 0, 19298 section iast BytebuddyAgent [baseline] (813.557 ms) : 0, 813557 BytebuddyAgent [candidate] (811.371 ms) : 0, 811371 GlobalTracer [baseline] (307.834 ms) : 0, 307834 GlobalTracer [candidate] (306.016 ms) : 0, 306016 AppSec [baseline] (57.862 ms) : 0, 57862 AppSec [candidate] (58.053 ms) : 0, 58053 Remote Config [baseline] (642.444 µs) : 0, 642 Remote Config [candidate] (618.748 µs) : 0, 619 Telemetry [baseline] (7.592 ms) : 0, 7592 Telemetry [candidate] (7.516 ms) : 0, 7516 IAST [baseline] (22.227 ms) : 0, 22227 IAST [candidate] (20.973 ms) : 0, 20973 section profiling BytebuddyAgent [baseline] (686.322 ms) : 0, 686322 BytebuddyAgent [candidate] (688.14 ms) : 0, 688140 GlobalTracer [baseline] (431.846 ms) : 0, 431846 GlobalTracer [candidate] (433.035 ms) : 0, 433035 AppSec [baseline] (53.677 ms) : 0, 53677 AppSec [candidate] (53.763 ms) : 0, 53763 Remote Config [baseline] (654.283 µs) : 0, 654 Remote Config [candidate] (668.669 µs) : 0, 669 Telemetry [baseline] (7.703 ms) : 0, 7703 Telemetry [candidate] (7.777 ms) : 0, 7777 ProfilingAgent [baseline] (93.627 ms) : 0, 93627 ProfilingAgent [candidate] (93.716 ms) : 0, 93716 Profiling [baseline] (93.651 ms) : 0, 93651 Profiling [candidate] (93.74 ms) : 0, 93740
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-12-02T12:07:56 2024-12-02T12:14:55
git_branch master bbujon/crashtracking
git_commit_date 1733140469 1733140653
git_commit_sha 722c8f7 f81944e
release_version 1.44.0-SNAPSHOT~722c8f7af5 1.44.0-SNAPSHOT~f81944e79f
start_time 2024-12-02T12:07:42 2024-12-02T12:14:42
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1733142049 1733142049
ci_job_id 724367699 724367699
ci_pipeline_id 50203567 50203567
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section baseline no_agent (1.365 ms) : 1346, 1384 . : milestone, 1365, appsec (1.743 ms) : 1718, 1769 . : milestone, 1743, appsec_no_iast (1.753 ms) : 1727, 1778 . : milestone, 1753, iast (1.507 ms) : 1483, 1530 . : milestone, 1507, profiling (1.533 ms) : 1509, 1556 . : milestone, 1533, tracing (1.493 ms) : 1467, 1518 . : milestone, 1493, section candidate no_agent (1.36 ms) : 1338, 1381 . : milestone, 1360, appsec (1.78 ms) : 1756, 1804 . : milestone, 1780, appsec_no_iast (1.734 ms) : 1710, 1759 . : milestone, 1734, iast (1.502 ms) : 1479, 1525 . : milestone, 1502, profiling (1.546 ms) : 1521, 1571 . : milestone, 1546, tracing (1.478 ms) : 1453, 1503 . : milestone, 1478,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.384 ms] -
appsec 1.743 ms [1.718 ms, 1.769 ms] 378.506 µs (27.7%)
appsec_no_iast 1.753 ms [1.727 ms, 1.778 ms] 387.649 µs (28.4%)
iast 1.507 ms [1.483 ms, 1.53 ms] 141.684 µs (10.4%)
profiling 1.533 ms [1.509 ms, 1.556 ms] 167.835 µs (12.3%)
tracing 1.493 ms [1.467 ms, 1.518 ms] 127.663 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.338 ms, 1.381 ms] -
appsec 1.78 ms [1.756 ms, 1.804 ms] 420.824 µs (31.0%)
appsec_no_iast 1.734 ms [1.71 ms, 1.759 ms] 374.963 µs (27.6%)
iast 1.502 ms [1.479 ms, 1.525 ms] 142.491 µs (10.5%)
profiling 1.546 ms [1.521 ms, 1.571 ms] 186.374 µs (13.7%)
tracing 1.478 ms [1.453 ms, 1.503 ms] 118.62 µs (8.7%)
Request duration reports for insecure-bank 
gantt title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section baseline no_agent (383.388 µs) : 363, 403 . : milestone, 383, iast (491.726 µs) : 470, 513 . : milestone, 492, iast_FULL (655.061 µs) : 633, 677 . : milestone, 655, iast_GLOBAL (525.877 µs) : 504, 548 . : milestone, 526, iast_HARDCODED_SECRET_DISABLED (498.433 µs) : 477, 520 . : milestone, 498, iast_INACTIVE (456.193 µs) : 435, 478 . : milestone, 456, iast_TELEMETRY_OFF (489.733 µs) : 468, 512 . : milestone, 490, tracing (452.196 µs) : 431, 473 . : milestone, 452, section candidate no_agent (377.184 µs) : 357, 397 . : milestone, 377, iast (495.586 µs) : 474, 517 . : milestone, 496, iast_FULL (651.681 µs) : 630, 673 . : milestone, 652, iast_GLOBAL (517.432 µs) : 496, 539 . : milestone, 517, iast_HARDCODED_SECRET_DISABLED (492.491 µs) : 471, 514 . : milestone, 492, iast_INACTIVE (459.706 µs) : 438, 481 . : milestone, 460, iast_TELEMETRY_OFF (481.766 µs) : 460, 503 . : milestone, 482, tracing (449.819 µs) : 429, 471 . : milestone, 450,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.388 µs [363.415 µs, 403.36 µs] -
iast 491.726 µs [470.438 µs, 513.015 µs] 108.338 µs (28.3%)
iast_FULL 655.061 µs [633.432 µs, 676.689 µs] 271.673 µs (70.9%)
iast_GLOBAL 525.877 µs [503.54 µs, 548.214 µs] 142.489 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 498.433 µs [477.1 µs, 519.765 µs] 115.045 µs (30.0%)
iast_INACTIVE 456.193 µs [434.694 µs, 477.692 µs] 72.805 µs (19.0%)
iast_TELEMETRY_OFF 489.733 µs [467.717 µs, 511.75 µs] 106.346 µs (27.7%)
tracing 452.196 µs [431.402 µs, 472.989 µs] 68.808 µs (17.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.184 µs [357.189 µs, 397.18 µs] -
iast 495.586 µs [473.927 µs, 517.246 µs] 118.402 µs (31.4%)
iast_FULL 651.681 µs [630.198 µs, 673.163 µs] 274.496 µs (72.8%)
iast_GLOBAL 517.432 µs [496.062 µs, 538.802 µs] 140.248 µs (37.2%)
iast_HARDCODED_SECRET_DISABLED 492.491 µs [471.363 µs, 513.618 µs] 115.306 µs (30.6%)
iast_INACTIVE 459.706 µs [438.358 µs, 481.055 µs] 82.522 µs (21.9%)
iast_TELEMETRY_OFF 481.766 µs [460.473 µs, 503.06 µs] 104.582 µs (27.7%)
tracing 449.819 µs [428.978 µs, 470.66 µs] 72.635 µs (19.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bbujon/crashtracking
git_commit_date 1733140469 1733140653
git_commit_sha 722c8f7 f81944e
release_version 1.44.0-SNAPSHOT~722c8f7af5 1.44.0-SNAPSHOT~f81944e79f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1733142456 1733142456
ci_job_id 724367700 724367700
ci_pipeline_id 50203567 50203567
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section baseline no_agent (15.587 s) : 15587000, 15587000 . : milestone, 15587000, appsec (15.08 s) : 15080000, 15080000 . : milestone, 15080000, iast (18.602 s) : 18602000, 18602000 . : milestone, 18602000, iast_GLOBAL (18.212 s) : 18212000, 18212000 . : milestone, 18212000, profiling (15.189 s) : 15189000, 15189000 . : milestone, 15189000, tracing (14.899 s) : 14899000, 14899000 . : milestone, 14899000, section candidate no_agent (14.766 s) : 14766000, 14766000 . : milestone, 14766000, appsec (14.911 s) : 14911000, 14911000 . : milestone, 14911000, iast (18.518 s) : 18518000, 18518000 . : milestone, 18518000, iast_GLOBAL (18.356 s) : 18356000, 18356000 . : milestone, 18356000, profiling (15.128 s) : 15128000, 15128000 . : milestone, 15128000, tracing (14.904 s) : 14904000, 14904000 . : milestone, 14904000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.587 s [15.587 s, 15.587 s] -
appsec 15.08 s [15.08 s, 15.08 s] -507.0 ms (-3.3%)
iast 18.602 s [18.602 s, 18.602 s] 3.015 s (19.3%)
iast_GLOBAL 18.212 s [18.212 s, 18.212 s] 2.625 s (16.8%)
profiling 15.189 s [15.189 s, 15.189 s] -398.0 ms (-2.6%)
tracing 14.899 s [14.899 s, 14.899 s] -688.0 ms (-4.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.766 s [14.766 s, 14.766 s] -
appsec 14.911 s [14.911 s, 14.911 s] 145.0 ms (1.0%)
iast 18.518 s [18.518 s, 18.518 s] 3.752 s (25.4%)
iast_GLOBAL 18.356 s [18.356 s, 18.356 s] 3.59 s (24.3%)
profiling 15.128 s [15.128 s, 15.128 s] 362.0 ms (2.5%)
tracing 14.904 s [14.904 s, 14.904 s] 138.0 ms (0.9%)
Execution time for tomcat 
gantt title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~f81944e79f, baseline=1.44.0-SNAPSHOT~722c8f7af5 dateFormat X axisFormat %s section baseline no_agent (1.473 ms) : 1462, 1485 . : milestone, 1473, appsec (2.348 ms) : 2306, 2389 . : milestone, 2348, iast (2.082 ms) : 2029, 2134 . : milestone, 2082, iast_GLOBAL (2.13 ms) : 2078, 2183 . : milestone, 2130, profiling (2.444 ms) : 2258, 2629 . : milestone, 2444, tracing (1.929 ms) : 1888, 1969 . : milestone, 1929, section candidate no_agent (1.469 ms) : 1458, 1481 . : milestone, 1469, appsec (2.344 ms) : 2303, 2386 . : milestone, 2344, iast (2.084 ms) : 2032, 2136 . : milestone, 2084, iast_GLOBAL (2.124 ms) : 2071, 2177 . : milestone, 2124, profiling (1.943 ms) : 1902, 1985 . : milestone, 1943, tracing (1.935 ms) : 1895, 1975 . : milestone, 1935,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.348 ms [2.306 ms, 2.389 ms] 874.364 µs (59.4%)
iast 2.082 ms [2.029 ms, 2.134 ms] 608.464 µs (41.3%)
iast_GLOBAL 2.13 ms [2.078 ms, 2.183 ms] 656.977 µs (44.6%)
profiling 2.444 ms [2.258 ms, 2.629 ms] 970.415 µs (65.9%)
tracing 1.929 ms [1.888 ms, 1.969 ms] 455.537 µs (30.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.458 ms, 1.481 ms] -
appsec 2.344 ms [2.303 ms, 2.386 ms] 874.977 µs (59.5%)
iast 2.084 ms [2.032 ms, 2.136 ms] 614.675 µs (41.8%)
iast_GLOBAL 2.124 ms [2.071 ms, 2.177 ms] 654.724 µs (44.6%)
profiling 1.943 ms [1.902 ms, 1.985 ms] 474.139 µs (32.3%)
tracing 1.935 ms [1.895 ms, 1.975 ms] 465.732 µs (31.7%)
@r1viollet
Copy link
Contributor

I will approve as this probably hurts our experience. Though I have a few extra questions as I am not too familiar with java side of things.
I assume the info level is not shown to customers by default ? Hence do we need the separate logging strategies ?
Why are we failing to do this cleanup ? Is there something else we should consider behind this failure ?
r1viollet
r1viollet approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking at this.
@PerfectSlayer PerfectSlayer merged commit a9708ea into master Dec 3, 2024
106 checks passed
@PerfectSlayer PerfectSlayer deleted the bbujon/crashtracking branch December 3, 2024 09:33
@github-actions github-actions bot added this to the 1.44.0 milestone Dec 3, 2024
@PerfectSlayer
Copy link
Contributor Author

I assume the info level is not shown to customers by default ?

The level is part of the log entry/event so customers are aware of it.
In addition, level is used for filtering and it helps when it is consistency across the whole client library.

Hence do we need the separate logging strategies ?

When debug is enabled (and it is usually enabled by the customers when support ask them to), you will have the full stack trace. When debug is disabled, you will only get the message / summary reason of the failure. (having a Throwable as last parameter of a log call implicitly capture the whole stack trace as part of the log event/entry)

Why are we failing to do this cleanup ? Is there something else we should consider behind this failure ?

The specific error was: java.nio.file.AccessDeniedException from the UnixFileSystemProvider. It can comes from multiples reasons (file lock, maybe already deleted if 2 cleaners are running in parallel, etc...). Exceptions are not uncommon with file I/O.
About failure recovery, I don’t think there is much to do. The cleaner will be run again next time an instrumented process will start. And worst case scenario, a bunch of cfg files will stay in the tmp folder.
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Dec 16, 2024
@github-cash-renovate-jvm-2 @svc-squareup-copybara
This PR contains the following updates:
b8572af 
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#&#8203;3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#&#8203;3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#&#8203;3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#&#8203;3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#&#8203;3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#&#8203;3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#&#8203;3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#&#8203;3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#&#8203;3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#&#8203;3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#&#8203;3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#&#8203;3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#&#8203;3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#&#8203;3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#&#8203;3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#&#8203;3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#&#8203;3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#&#8203;3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#&#8203;3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#&#8203;3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#&#8203;1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#&#8203;1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#&#8203;1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#&#8203;1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#&#8203;1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#&#8203;1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#&#8203;1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#&#8203;8089](DataDog/dd-trace-java#8089) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#&#8203;7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#&#8203;8044](DataDog/dd-trace-java#8044) - [@&#8203;smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#&#8203;8038](DataDog/dd-trace-java#8038) - [@&#8203;Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#&#8203;8026](DataDog/dd-trace-java#8026) - [@&#8203;Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#&#8203;8013](DataDog/dd-trace-java#8013) - [@&#8203;Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#&#8203;8010](DataDog/dd-trace-java#8010) - [@&#8203;Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#&#8203;7920](DataDog/dd-trace-java#7920) - [@&#8203;Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#&#8203;8004](DataDog/dd-trace-java#8004) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#&#8203;8078](DataDog/dd-trace-java#8078) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#&#8203;8055](DataDog/dd-trace-java#8055) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#&#8203;8033](DataDog/dd-trace-java#8033) - [@&#8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#&#8203;8030](DataDog/dd-trace-java#8030) - [@&#8203;daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#&#8203;8045](DataDog/dd-trace-java#8045) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#&#8203;8071](DataDog/dd-trace-java#8071) - [@&#8203;piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#&#8203;8051](DataDog/dd-trace-java#8051) - [@&#8203;kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#&#8203;7959](DataDog/dd-trace-java#7959) - [@&#8203;piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#&#8203;8039](DataDog/dd-trace-java#8039) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#&#8203;8021](DataDog/dd-trace-java#8021) - [@&#8203;jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#&#8203;8016](DataDog/dd-trace-java#8016) - [@&#8203;evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#&#8203;7942](DataDog/dd-trace-java#7942) - [@&#8203;evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#&#8203;8065](DataDog/dd-trace-java#8065) - [@&#8203;MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#&#8203;8036](DataDog/dd-trace-java#8036) - [@&#8203;mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#&#8203;8012](DataDog/dd-trace-java#8012) - [@&#8203;mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#&#8203;8058](DataDog/dd-trace-java#8058) - [@&#8203;mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#&#8203;8064](DataDog/dd-trace-java#8064) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#&#8203;8061](DataDog/dd-trace-java#8061) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#&#8203;8040](DataDog/dd-trace-java#8040) - [@&#8203;cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#&#8203;8028](DataDog/dd-trace-java#8028) - [@&#8203;mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#&#8203;7973](DataDog/dd-trace-java#7973) - [@&#8203;PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#&#8203;7946](DataDog/dd-trace-java#7946) - [@&#8203;smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#&#8203;7920](DataDog/dd-trace-java#7920) - [@&#8203;Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#&#8203;8043](DataDog/dd-trace-java#8043) - [@&#8203;amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#&#8203;7940](DataDog/dd-trace-java#7940) - [@&#8203;nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#&#8203;8062](DataDog/dd-trace-java#8062) - [@&#8203;amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#&#8203;7959](DataDog/dd-trace-java#7959) - [@&#8203;piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#&#8203;8019](DataDog/dd-trace-java#8019) - [@&#8203;mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#&#8203;8012](DataDog/dd-trace-java#8012) - [@&#8203;mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#&#8203;8005](DataDog/dd-trace-java#8005) - [@&#8203;amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#&#8203;8025](DataDog/dd-trace-java#8025) - [@&#8203;amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#&#8203;7981](DataDog/dd-trace-java#7981) - [@&#8203;amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: crash tracking Crash tracking type: enhancement Enhancements and improvements

2 participants

@PerfectSlayer @r1viollet