- Notifications
You must be signed in to change notification settings - Fork 313
Use lower priorities for grpc server errors #8043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3243261
to 9679eb3
Compare mcculls approved these changes Dec 2, 2024
b4aa9b9
to 822b3cb
Compare BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics. Startup time reports for petclinicgantt title petclinic - global startup overhead: candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section tracing Agent [baseline] (1.098 s) : 0, 1097987 Total [baseline] (10.499 s) : 0, 10499437 Agent [candidate] (1.098 s) : 0, 1097681 Total [candidate] (10.563 s) : 0, 10563158 section appsec Agent [baseline] (1.224 s) : 0, 1224157 Total [baseline] (10.82 s) : 0, 10819530 Agent [candidate] (1.225 s) : 0, 1225024 Total [candidate] (10.774 s) : 0, 10774271 section iast Agent [baseline] (1.229 s) : 0, 1228713 Total [baseline] (11.03 s) : 0, 11030231 Agent [candidate] (1.228 s) : 0, 1228352 Total [candidate] (10.965 s) : 0, 10964791 section profiling Agent [baseline] (1.314 s) : 0, 1314107 Total [baseline] (10.812 s) : 0, 10811890 Agent [candidate] (1.318 s) : 0, 1318066 Total [candidate] (10.862 s) : 0, 10861948
gantt title petclinic - break down per module: candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (698.526 ms) : 0, 698526 BytebuddyAgent [candidate] (698.549 ms) : 0, 698549 GlobalTracer [baseline] (319.379 ms) : 0, 319379 GlobalTracer [candidate] (320.287 ms) : 0, 320287 AppSec [baseline] (54.906 ms) : 0, 54906 AppSec [candidate] (55.212 ms) : 0, 55212 Remote Config [baseline] (680.319 µs) : 0, 680 Remote Config [candidate] (695.099 µs) : 0, 695 Telemetry [baseline] (10.665 ms) : 0, 10665 Telemetry [candidate] (9.184 ms) : 0, 9184 section appsec BytebuddyAgent [baseline] (710.355 ms) : 0, 710355 BytebuddyAgent [candidate] (710.185 ms) : 0, 710185 GlobalTracer [baseline] (314.415 ms) : 0, 314415 GlobalTracer [candidate] (314.947 ms) : 0, 314947 AppSec [baseline] (166.444 ms) : 0, 166444 AppSec [candidate] (167.494 ms) : 0, 167494 Remote Config [baseline] (653.213 µs) : 0, 653 Remote Config [candidate] (649.539 µs) : 0, 650 Telemetry [baseline] (8.9 ms) : 0, 8900 Telemetry [candidate] (8.518 ms) : 0, 8518 IAST [baseline] (19.322 ms) : 0, 19322 IAST [candidate] (18.99 ms) : 0, 18990 section iast BytebuddyAgent [baseline] (818.117 ms) : 0, 818117 BytebuddyAgent [candidate] (818.127 ms) : 0, 818127 GlobalTracer [baseline] (309.331 ms) : 0, 309331 GlobalTracer [candidate] (308.719 ms) : 0, 308719 AppSec [baseline] (57.34 ms) : 0, 57340 AppSec [candidate] (58.268 ms) : 0, 58268 Remote Config [baseline] (629.441 µs) : 0, 629 Remote Config [candidate] (641.804 µs) : 0, 642 Telemetry [baseline] (7.569 ms) : 0, 7569 Telemetry [candidate] (7.605 ms) : 0, 7605 IAST [baseline] (21.93 ms) : 0, 21930 IAST [candidate] (21.113 ms) : 0, 21113 section profiling ProfilingAgent [baseline] (93.356 ms) : 0, 93356 ProfilingAgent [candidate] (93.908 ms) : 0, 93908 BytebuddyAgent [baseline] (687.213 ms) : 0, 687213 BytebuddyAgent [candidate] (688.056 ms) : 0, 688056 GlobalTracer [baseline] (432.511 ms) : 0, 432511 GlobalTracer [candidate] (434.513 ms) : 0, 434513 AppSec [baseline] (53.646 ms) : 0, 53646 AppSec [candidate] (54.122 ms) : 0, 54122 Remote Config [baseline] (663.015 µs) : 0, 663 Remote Config [candidate] (671.833 µs) : 0, 672 Telemetry [baseline] (7.706 ms) : 0, 7706 Telemetry [candidate] (7.732 ms) : 0, 7732 Profiling [baseline] (93.378 ms) : 0, 93378 Profiling [candidate] (93.932 ms) : 0, 93932 Startup time reports for insecure-bankgantt title insecure-bank - global startup overhead: candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section tracing Agent [baseline] (1.091 s) : 0, 1090764 Total [baseline] (8.693 s) : 0, 8692871 Agent [candidate] (1.094 s) : 0, 1094377 Total [candidate] (8.694 s) : 0, 8693984 section iast Agent [baseline] (1.217 s) : 0, 1217037 Total [baseline] (9.218 s) : 0, 9217748 Agent [candidate] (1.23 s) : 0, 1230353 Total [candidate] (9.298 s) : 0, 9297580 section iast_HARDCODED_SECRET_DISABLED Agent [baseline] (1.217 s) : 0, 1217247 Total [baseline] (9.21 s) : 0, 9209767 Agent [candidate] (1.219 s) : 0, 1219011 Total [candidate] (9.268 s) : 0, 9268030 section iast_TELEMETRY_OFF Agent [baseline] (1.22 s) : 0, 1219503 Total [baseline] (9.188 s) : 0, 9188099 Agent [candidate] (1.24 s) : 0, 1239806 Total [candidate] (9.317 s) : 0, 9316931
gantt title insecure-bank - break down per module: candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section tracing BytebuddyAgent [baseline] (694.352 ms) : 0, 694352 BytebuddyAgent [candidate] (694.895 ms) : 0, 694895 GlobalTracer [baseline] (317.355 ms) : 0, 317355 GlobalTracer [candidate] (318.795 ms) : 0, 318795 AppSec [baseline] (54.741 ms) : 0, 54741 AppSec [candidate] (54.922 ms) : 0, 54922 Remote Config [baseline] (678.48 µs) : 0, 678 Remote Config [candidate] (682.301 µs) : 0, 682 Telemetry [baseline] (9.886 ms) : 0, 9886 Telemetry [candidate] (11.314 ms) : 0, 11314 section iast BytebuddyAgent [baseline] (810.594 ms) : 0, 810594 BytebuddyAgent [candidate] (818.035 ms) : 0, 818035 GlobalTracer [baseline] (306.024 ms) : 0, 306024 GlobalTracer [candidate] (310.196 ms) : 0, 310196 AppSec [baseline] (56.189 ms) : 0, 56189 AppSec [candidate] (57.893 ms) : 0, 57893 IAST [baseline] (22.436 ms) : 0, 22436 IAST [candidate] (22.072 ms) : 0, 22072 Remote Config [baseline] (634.378 µs) : 0, 634 Remote Config [candidate] (650.73 µs) : 0, 651 Telemetry [baseline] (7.456 ms) : 0, 7456 Telemetry [candidate] (7.666 ms) : 0, 7666 section iast_HARDCODED_SECRET_DISABLED BytebuddyAgent [baseline] (810.659 ms) : 0, 810659 BytebuddyAgent [candidate] (811.255 ms) : 0, 811255 GlobalTracer [baseline] (306.132 ms) : 0, 306132 GlobalTracer [candidate] (306.65 ms) : 0, 306650 AppSec [baseline] (57.659 ms) : 0, 57659 AppSec [candidate] (57.257 ms) : 0, 57257 IAST [baseline] (20.943 ms) : 0, 20943 IAST [candidate] (21.916 ms) : 0, 21916 Remote Config [baseline] (641.118 µs) : 0, 641 Remote Config [candidate] (635.993 µs) : 0, 636 Telemetry [baseline] (7.505 ms) : 0, 7505 Telemetry [candidate] (7.53 ms) : 0, 7530 section iast_TELEMETRY_OFF BytebuddyAgent [baseline] (810.517 ms) : 0, 810517 BytebuddyAgent [candidate] (825.602 ms) : 0, 825602 GlobalTracer [baseline] (308.604 ms) : 0, 308604 GlobalTracer [candidate] (311.822 ms) : 0, 311822 AppSec [baseline] (58.103 ms) : 0, 58103 AppSec [candidate] (58.287 ms) : 0, 58287 IAST [baseline] (20.487 ms) : 0, 20487 IAST [candidate] (21.768 ms) : 0, 21768 Remote Config [baseline] (645.586 µs) : 0, 646 Remote Config [candidate] (669.193 µs) : 0, 669 Telemetry [baseline] (7.396 ms) : 0, 7396 Telemetry [candidate] (7.62 ms) : 0, 7620 LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt title insecure-bank - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section baseline no_agent (371.999 µs) : 352, 392 . : milestone, 372, iast (497.881 µs) : 476, 519 . : milestone, 498, iast_FULL (653.097 µs) : 632, 675 . : milestone, 653, iast_GLOBAL (517.491 µs) : 496, 539 . : milestone, 517, iast_HARDCODED_SECRET_DISABLED (497.274 µs) : 476, 519 . : milestone, 497, iast_INACTIVE (460.979 µs) : 439, 483 . : milestone, 461, iast_TELEMETRY_OFF (484.377 µs) : 463, 506 . : milestone, 484, tracing (450.947 µs) : 429, 473 . : milestone, 451, section candidate no_agent (382.481 µs) : 361, 404 . : milestone, 382, iast (498.825 µs) : 477, 521 . : milestone, 499, iast_FULL (652.572 µs) : 631, 674 . : milestone, 653, iast_GLOBAL (522.922 µs) : 501, 545 . : milestone, 523, iast_HARDCODED_SECRET_DISABLED (494.543 µs) : 473, 516 . : milestone, 495, iast_INACTIVE (457.874 µs) : 436, 480 . : milestone, 458, iast_TELEMETRY_OFF (485.762 µs) : 464, 508 . : milestone, 486, tracing (454.162 µs) : 433, 476 . : milestone, 454,
Request duration reports for petclinicgantt title petclinic - request duration [CI 0.99] : candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section baseline no_agent (1.376 ms) : 1357, 1396 . : milestone, 1376, appsec (1.787 ms) : 1762, 1812 . : milestone, 1787, appsec_no_iast (1.757 ms) : 1732, 1782 . : milestone, 1757, iast (1.512 ms) : 1489, 1535 . : milestone, 1512, profiling (1.51 ms) : 1487, 1532 . : milestone, 1510, tracing (1.51 ms) : 1484, 1536 . : milestone, 1510, section candidate no_agent (1.364 ms) : 1344, 1384 . : milestone, 1364, appsec (1.76 ms) : 1736, 1784 . : milestone, 1760, appsec_no_iast (1.749 ms) : 1724, 1773 . : milestone, 1749, iast (1.516 ms) : 1494, 1538 . : milestone, 1516, profiling (1.547 ms) : 1522, 1572 . : milestone, 1547, tracing (1.503 ms) : 1479, 1528 . : milestone, 1503,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt title biojava - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section baseline no_agent (15.444 s) : 15444000, 15444000 . : milestone, 15444000, appsec (14.656 s) : 14656000, 14656000 . : milestone, 14656000, iast (18.776 s) : 18776000, 18776000 . : milestone, 18776000, iast_GLOBAL (18.009 s) : 18009000, 18009000 . : milestone, 18009000, profiling (15.009 s) : 15009000, 15009000 . : milestone, 15009000, tracing (15.365 s) : 15365000, 15365000 . : milestone, 15365000, section candidate no_agent (14.996 s) : 14996000, 14996000 . : milestone, 14996000, appsec (14.808 s) : 14808000, 14808000 . : milestone, 14808000, iast (18.772 s) : 18772000, 18772000 . : milestone, 18772000, iast_GLOBAL (17.655 s) : 17655000, 17655000 . : milestone, 17655000, profiling (15.568 s) : 15568000, 15568000 . : milestone, 15568000, tracing (15.049 s) : 15049000, 15049000 . : milestone, 15049000,
Execution time for tomcatgantt title tomcat - execution time [CI 0.99] : candidate=1.44.0-SNAPSHOT~822b3cbcb4, baseline=1.44.0-SNAPSHOT~9f01834ab7 dateFormat X axisFormat %s section baseline no_agent (1.473 ms) : 1462, 1485 . : milestone, 1473, appsec (2.359 ms) : 2318, 2401 . : milestone, 2359, iast (2.098 ms) : 2045, 2150 . : milestone, 2098, iast_GLOBAL (2.138 ms) : 2085, 2191 . : milestone, 2138, profiling (1.959 ms) : 1917, 2002 . : milestone, 1959, tracing (1.936 ms) : 1895, 1976 . : milestone, 1936, section candidate no_agent (1.475 ms) : 1463, 1486 . : milestone, 1475, appsec (2.357 ms) : 2316, 2399 . : milestone, 2357, iast (2.104 ms) : 2052, 2157 . : milestone, 2104, iast_GLOBAL (2.142 ms) : 2089, 2194 . : milestone, 2142, profiling (1.973 ms) : 1929, 2016 . : milestone, 1973, tracing (1.935 ms) : 1895, 1975 . : milestone, 1935,
|
822b3cb
to 21ee8b5
Compare svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Dec 16, 2024
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-common-protos](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.49.0` -> `2.50.0` | | [com.google.cloud:google-cloud-core-http](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.82.0` -> `6.83.0` | | [com.google.cloud:google-cloud-logging](https://github.com/googleapis/java-logging) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.20.7` -> `3.21.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.24.3` -> `2.25.1` | | [com.google.cloud:google-cloud-core](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.48.0` -> `2.49.0` | | [com.google.api:gax](https://github.com/googleapis/sdk-platform-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.58.0` -> `2.59.0` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | patch | `2.6.0` -> `2.6.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.43.0` -> `1.44.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.32` -> `2.29.34` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.779` -> `1.12.780` | --- ### Release Notes <details> <summary>googleapis/sdk-platform-java (com.google.api.grpc:proto-google-common-protos)</summary> ### [`v2.50.0`](https://github.com/googleapis/sdk-platform-java/blob/HEAD/CHANGELOG.md#2500-2024-11-14) ##### Features - Add experimental S2A integration in client libraries grpc transport ([#​3326](googleapis/sdk-platform-java#3326)) ([1138ca6](googleapis/sdk-platform-java@1138ca6)) - enable selective generation based on service config include list ([#​3323](googleapis/sdk-platform-java#3323)) ([0cddadb](googleapis/sdk-platform-java@0cddadb)) - introduce `java.time` to java-core ([#​3330](googleapis/sdk-platform-java#3330)) ([f202c3b](googleapis/sdk-platform-java@f202c3b)) - Update Gapic-Generator to generate libraries using `java.time` methods ([#​3321](googleapis/sdk-platform-java#3321)) ([b21c9a4](googleapis/sdk-platform-java@b21c9a4)) ##### Bug Fixes - Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#​3335](googleapis/sdk-platform-java#3335)) ([e73740d](googleapis/sdk-platform-java@e73740d)) - httpjson callables to trace attempts (started, failed) ([#​3300](googleapis/sdk-platform-java#3300)) ([15a64ee](googleapis/sdk-platform-java@15a64ee)) - instantiate GaxProperties at build time to ensure we get the protobuf version ([#​3365](googleapis/sdk-platform-java#3365)) ([bb2a3be](googleapis/sdk-platform-java@bb2a3be)) - protobuf version not always getting set in headers ([#​3322](googleapis/sdk-platform-java#3322)) ([7f6e470](googleapis/sdk-platform-java@7f6e470)) - use BuildKit instead of legacy builder to build the Hermetic Build images ([#​3338](googleapis/sdk-platform-java#3338)) ([222fb45](googleapis/sdk-platform-java@222fb45)) ##### Dependencies - update google auth library dependencies to v1.30.0 ([#​3367](googleapis/sdk-platform-java#3367)) ([a31c682](googleapis/sdk-platform-java@a31c682)) - update grpc dependencies to v1.68.1 ([#​3240](googleapis/sdk-platform-java#3240)) ([c8e3941](googleapis/sdk-platform-java@c8e3941)) ##### Documentation - fix list num ([#​3356](googleapis/sdk-platform-java#3356)) ([b7d6296](googleapis/sdk-platform-java@b7d6296)) - **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#​3337](googleapis/sdk-platform-java#3337)) ([01e742d](googleapis/sdk-platform-java@01e742d)) - modify hermetic build docs ([#​3331](googleapis/sdk-platform-java#3331)) ([25023af](googleapis/sdk-platform-java@25023af)) </details> <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.83.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6830-2024-12-13) ##### Features - Add Metrics host for built in metrics ([#​3519](googleapis/java-spanner#3519)) ([4ed455a](googleapis/java-spanner@4ed455a)) - Add opt-in for using multiplexed sessions for blind writes ([#​3540](googleapis/java-spanner#3540)) ([216f53e](googleapis/java-spanner@216f53e)) - Add UUID in Spanner TypeCode enum ([41f83dc](googleapis/java-spanner@41f83dc)) - Introduce java.time variables and methods ([#​3495](googleapis/java-spanner#3495)) ([8a7d533](googleapis/java-spanner@8a7d533)) - **spanner:** Support multiplexed session for Partitioned operations ([#​3231](googleapis/java-spanner#3231)) ([4501a3e](googleapis/java-spanner@4501a3e)) - Support 'set local' for retry_aborts_internally ([#​3532](googleapis/java-spanner#3532)) ([331942f](googleapis/java-spanner@331942f)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([41f83dc](googleapis/java-spanner@41f83dc)) ##### Dependencies - Update sdk platform java dependencies ([#​3549](googleapis/java-spanner#3549)) ([6235f0f](googleapis/java-spanner@6235f0f)) </details> <details> <summary>googleapis/java-logging (com.google.cloud:google-cloud-logging)</summary> ### [`v3.21.0`](https://github.com/googleapis/java-logging/blob/HEAD/CHANGELOG.md#3210-2024-12-13) ##### Features - Introduce `java.time` methods ([#​1729](googleapis/java-logging#1729)) ([323eb33](googleapis/java-logging@323eb33)) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([04d8868](googleapis/java-logging@04d8868)) ##### Dependencies - Update dependency io.opentelemetry:opentelemetry-bom to v1.45.0 ([#​1638](googleapis/java-logging#1638)) ([7e007d4](googleapis/java-logging@7e007d4)) - Update sdk platform java dependencies ([#​1736](googleapis/java-logging#1736)) ([88b4cdf](googleapis/java-logging@88b4cdf)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2251-2024-12-13) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.0 ([106ee4d](googleapis/java-datastore@106ee4d)) ##### Dependencies - Update sdk platform java dependencies ([#​1685](googleapis/java-datastore#1685)) ([4372350](googleapis/java-datastore@4372350)) ### [`v2.25.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2250-2024-12-11) ##### Features - Introduce `java.time` methods and variables ([#​1671](googleapis/java-datastore#1671)) ([5a78a80](googleapis/java-datastore@5a78a80)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.48.0 ([#​1605](googleapis/java-datastore#1605)) ([5c6a678](googleapis/java-datastore@5c6a678)) ##### Documentation - Update gapic upgrade installation instructions ([#​1677](googleapis/java-datastore#1677)) ([b3fbfcc](googleapis/java-datastore@b3fbfcc)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.6.1`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-261) - \[Fix]: `superClassName` can be null (Object has no superclass). </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.44.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.1): 1.44.1 ##### Components ##### Continuous Integration Visibility - 🐛 Fix tracing JUnit5 tests in Maven projects with multiple forks ([#​8089](DataDog/dd-trace-java#8089) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ### [`v1.44.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.44.0): 1.44.0 ##### Known Issues > \[!WARNING]\ > This release contains a known issue that causes failures when using Test Optimization to trace JUnit 5 tests in a Maven project where Maven Surefire is configured with `forkCount` > 1. > The issue is fixed in v1.44.1 ##### Breaking Changes > \[!WARNING]\ > Support for `X-Forwarded` header is dropped from default client IP resolution. > It can still be re-activated using the `dd.trace.client-ip-header=x-forwarded` system property, or the `DD_TRACE_CLIENT_IP_HEADER=x-forwarded` environment variable. See [#​7946](DataDog/dd-trace-java#7946). ##### Components ##### Application Security Management (IAST) - ✨ Set unexpected IAST exceptions to debug log level ([#​8044](DataDog/dd-trace-java#8044) - [@​smola](https://github.com/smola)) - ✨ Increase IAST propagation to StringBuffer subSequence ([#​8038](DataDog/dd-trace-java#8038) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder subSequence ([#​8026](DataDog/dd-trace-java#8026) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Add IAST propagation to String valueOf ([#​8013](DataDog/dd-trace-java#8013) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Increase IAST propagation to StringBuilder append ([#​8010](DataDog/dd-trace-java#8010) - [@​Mariovido](https://github.com/Mariovido)) - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#​7920](DataDog/dd-trace-java#7920) - [@​Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - ✨ Generate Muzzle classes for Groovy instrumentations ([#​8004](DataDog/dd-trace-java#8004) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Continuous Integration Visibility - ✨ Support distributed traces in tests ([#​8078](DataDog/dd-trace-java#8078) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement fail-fast tests ordering for JUnit 5 ([#​8055](DataDog/dd-trace-java#8055) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Mark JUnit 5 setup and teardown action spans as failed if there is an error ([#​8033](DataDog/dd-trace-java#8033) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tracing of setup and teardown actions in JUnit 4 ([#​8030](DataDog/dd-trace-java#8030) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Improve crash tracking install logging ([#​8045](DataDog/dd-trace-java#8045) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) ##### Data Streams Monitoring - 🐛 Add Data Streams support in AWS SQS without raw message delivery ([#​8071](DataDog/dd-trace-java#8071) - [@​piochelepiotr](https://github.com/piochelepiotr)) - ✨ Add new tag for enabled products / features to DSM checkpoints ([#​8051](DataDog/dd-trace-java#8051) - [@​kr-igor](https://github.com/kr-igor)) - 💡 Instrument self hosted Kafka connectors ([#​7959](DataDog/dd-trace-java#7959) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### Dynamic Instrumentation - ✨ Add Micronaut 4 support for code origin for spans ([#​8039](DataDog/dd-trace-java#8039) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Refactor probe matching for methods ([#​8021](DataDog/dd-trace-java#8021) - [@​jpbempel](https://github.com/jpbempel)) - ✨ Update the CodeOriginProbe fingerprint to not rely on a stack walk ([#​8016](DataDog/dd-trace-java#8016) - [@​evanchooly](https://github.com/evanchooly)) - ✨ Implement code origin support for grpc server entry spans ([#​7942](DataDog/dd-trace-java#7942) - [@​evanchooly](https://github.com/evanchooly)) ##### GraalVM native-image - 🐛 Update Graal build-time instrumentation config for TracePropagationStyle ([#​8065](DataDog/dd-trace-java#8065) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Fix NoClassDefFoundError: Could not initialize class DDSpanLink$EncoderHolder in Graal native-image ([#​8036](DataDog/dd-trace-java#8036) - [@​mcculls](https://github.com/mcculls)) - 🐛🧹 Fix native-image generation of reactive applications ([#​8012](DataDog/dd-trace-java#8012) - [@​mcculls](https://github.com/mcculls)) ##### OpenTracing - 🧹 Custom ScopeManagers are deprecated and will be removed in a future release of dd-trace-ot ([#​8058](DataDog/dd-trace-java#8058) - [@​mcculls](https://github.com/mcculls)) ##### Tracer core - ✨🧪 Service naming: split by jee deployment ([#​8064](DataDog/dd-trace-java#8064) - [@​amarziali](https://github.com/amarziali)) - ✨ Exclude jboss mdb proxies from instrumenting ([#​8061](DataDog/dd-trace-java#8061) - [@​amarziali](https://github.com/amarziali)) - ✨ Add a built-in trace interceptor for keeping traces depending of their latency ([#​8040](DataDog/dd-trace-java#8040) - [@​cecile75](https://github.com/cecile75)) - 💡 Introduce marker mechanism for eagerly initializing helpers ([#​8028](DataDog/dd-trace-java#8028) - [@​mcculls](https://github.com/mcculls)) - 💡 Add JSON component ([#​7973](DataDog/dd-trace-java#7973) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨⚠️ Remove support for X-Forwarded in client IP resolution ([#​7946](DataDog/dd-trace-java#7946) - [@​smola](https://github.com/smola)) ##### Instrumentations ##### Apache HttpComponents - ✨ Expand SSRF support in IAST to apache-httpclient-5 and apache-httpasyncclient-4 ([#​7920](DataDog/dd-trace-java#7920) - [@​Mariovido](https://github.com/Mariovido)) ##### gRPC instrumentation - 🐛 Use lower priorities for grpc server errors ([#​8043](DataDog/dd-trace-java#8043) - [@​amarziali](https://github.com/amarziali)) ##### JDBC instrumentation - ✨ Add trace injection for prepared statements in Postgres ([#​7940](DataDog/dd-trace-java#7940) - [@​nenadnoveljic](https://github.com/nenadnoveljic)) ##### JMS instrumentation - 🐛 Protect mdb from instrumenting multiple time the same event ([#​8062](DataDog/dd-trace-java#8062) - [@​amarziali](https://github.com/amarziali)) ##### Kafka instrumentation - 💡 Instrument self hosted Kafka connectors ([#​7959](DataDog/dd-trace-java#7959) - [@​piochelepiotr](https://github.com/piochelepiotr)) ##### OpenTelemetry instrumentation - 🐛 Support using OpenTelemetry Event API inside `@WithSpan` annotated method ([#​8019](DataDog/dd-trace-java#8019) - [@​mcculls](https://github.com/mcculls)) ##### Reactor instrumentation - 🐛🧹 Fix native-image generation of reactive applications ([#​8012](DataDog/dd-trace-java#8012) - [@​mcculls](https://github.com/mcculls)) ##### Spring instrumentation - 🐛 Avoid double instrumenting lambdas on latest spring scheduling ([#​8005](DataDog/dd-trace-java#8005) - [@​amarziali](https://github.com/amarziali)) ##### All other instrumentations - 🐛 Twilio: allow service name flattening ([#​8025](DataDog/dd-trace-java#8025) - [@​amarziali](https://github.com/amarziali)) - ✨ Instrument Mulesoft 4.5.0+ ([#​7981](DataDog/dd-trace-java#7981) - [@​amarziali](https://github.com/amarziali)) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.780`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112780-2024-12-11) [Compare Source](aws/aws-sdk-java@1.12.779...1.12.780) #### **Amazon Simple Storage Service** - ### Bugfixes - AWS SDK for Java 1.x now includes additional validation for Amazon S3 client APIs to handle scenarios where an empty string ('') is passed as the key argument to the following operations: PutObject, DeleteObject, ListObjects, GetObjectMetaData, ListObjectsV2, SetObjectTagging, GetObjectTagging, SetObjectAcl, GetObjectAcl, SetObjectLegalHold, GetObjectLegalHold, CopyObject, CopyPart, SelectObjectContent, SetObjectRetention, GetObjectRetention, AbortMultipartUpload, CompleteMultipartUpload, InitiateMultipartUpload, ListParts, UploadPart, RestoreObjectV2, and RestoreObject. The SDK will validate the key argument and throw an exception if it is an empty string, ensuring correct and expected behavior. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 69831bc62ea4d80cdcd42cef2aa9bd8eda28ae8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What Does This Do
Avoid overriding the error flag of grpc server spans if manually set. This leverage using a lower priority when setting the error flag by the decorator.
This solves #8042
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]