Skip to content

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025
Merged

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c43398e
refactor: 최소 설정으로 Sentry 연결
six-standard Jul 10, 2025
9c70935
refactor: 디버그 관련 코드 비활성화
six-standard Jul 12, 2025
bf33d9d
refactor: 릴리즈 타입 설정
six-standard Jul 12, 2025
39c91f4
refactor: 네이밍 이슈 관련 수정
six-standard Jul 12, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .env.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ POSTGRES_PASSWORD=vd2
POSTGRES_HOST=localhost
POSTGRES_PORT=5432

# ETC
# Slack Notification
SLACK_WEBHOOK_URL=https://hooks.slack.com/services
SLACK_CLIENT_SECRET=374708bedd34ae70f814471ff24db7dedc4b9bee06a7e8ef9255a4f6c8bd9049 # 실제 키를 사용하세요

# Sentry Hook
SENTRY_CLIENT_SECRET=374708bedd34ae70f814471ff24db7dedc4b9bee06a7e8ef9255a4f6c8bd9049 # 실제 키를 사용하세요
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 제가 배포 핫픽스 하면서 SENTRY_CLIENT_SECRET 로 바궛다고 생각했는데 아니엇나!! 이 부분을 말하신거군요!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 이 부분이 이상하다 싶어서 이번에 다 수정해두었는데, 지난번에 놓치신 부분이었나 봅니다.
사실 이런 식으로 분리하는게 필요하다 생각은 했었는데, 막상 실행을 못 했었네요;;
SENTRY_DSN=https://ingest.us.sentry.io
1 change: 1 addition & 0 deletions .github/workflows/test-ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ jobs:
echo "POSTGRES_PASSWORD=${{ secrets.POSTGRES_PASSWORD }}" >> .env
echo "POSTGRES_PORT=${{ secrets.POSTGRES_PORT }}" >> .env
echo "SENTRY_CLIENT_SECRET=${{ secrets.SENTRY_CLIENT_SECRET }}" >> .env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거봐! 내가 분명 바꿧는데! ㅋㅋㅋㅋ과거 코드도 ㅋㅋㅋ 실제 환경은 다 SENTRY_CLIENT_SECRET 쓰긴할거에유
echo "SENTRY_DSN=${{ secrets.SENTRY_DSN }}" >> .env
# AES 키들 추가 (테스트용 더미 키)
echo "AES_KEY_0=aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" >> .env
echo "AES_KEY_1=bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb" >> .env
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"author": "",
"license": "ISC",
"dependencies": {
"@sentry/node": "^9.36.0",
"axios": "^1.7.8",
"class-transformer": "^0.5.1",
"class-validator": "^0.14.1",
Expand Down
Loading
Loading