Skip to content

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 13, 2025
Merged

[25.07.12 / TASK-92] Refactor - API에 Sentry 추가 #40

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c43398e
refactor: 최소 설정으로 Sentry 연결
six-standard Jul 10, 2025
9c70935
refactor: 디버그 관련 코드 비활성화
six-standard Jul 12, 2025
bf33d9d
refactor: 릴리즈 타입 설정
six-standard Jul 12, 2025
39c91f4
refactor: 네이밍 이슈 관련 수정
six-standard Jul 12, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: 릴리즈 타입 설정
  • Loading branch information
@six-standard
six-standard committed Jul 12, 2025
commit bf33d9d644d8a8203ba8e43497353cba9ec3c512
2 changes: 1 addition & 1 deletion src/configs/sentry.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dotenv.config();
export const initSentry = () => {
Sentry.init({
dsn: process.env.SENTRY_DSN,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SENTRY_DSN vs SLACK_DSN ...
Copy link
Member Author

@six-standard six-standard Jul 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분을 제가 계속 놓치고 있었던 것 같네요;;
슬랙 쪽에서 발급받는 부분은 SLACK, 센트리 쪽에서 발급받는 부분은 SENTRY로 통일하는게 좋을 것 같습니다!
물론 두 값 사이에 줄바꿈은 넣어야 할 것 같네요

@Nuung 이전에도 제가 놓친 부분이 또 있었던 것으로 아는데, 이런 식으로 맞추는건 어떠신가요?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아뇨 이게 slack 이면 절대 안될 것 같아요.
슬랙 쪽에서 발급받는 부분은 SLACK 인데 지금 PR 은 slack 쪽에서 발급 받는게 하나도 없어요. dsn 값은 무조건 SENTRY 가 맞습니다. @six-standard
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분도 방금 말씀해주신대로 맞췄습니다.
release: 'production',
release: process.env.NODE_ENV,

// Define how likely traces are sampled. Adjust this value in production, or use tracesSampler for greater control.
tracesSampleRate: 0.1,
Expand Down
Loading