update example program #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the example code pointed to PWMOut, not PortOut, updated link accordingly
sg- suggested changes Sep 6, 2017
There was a problem hiding this comment.
Can tip be used instead?
https://developer.mbed.org/teams/mbed_example/code/PortOut_HelloWorld/file/tip/main.cpp
| @sg- no, we are not using tip. By using a specific version we ensure reproducability. By using tip it could be broken at some point. Given our history it would be safe to assume it will be broken at some point. So i prefer to stand on the side of caution. 'Cause murphy's law. |
AnotherButler approved these changes Sep 7, 2017
AnotherButler approved these changes Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
the example code pointed to PWMOut, not PortOut, updated link accordingly