Skip to content

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Apr 6, 2021

Add a migration guide to help show how to do things that Mbed CLI 1
could do using Mbed CLI 2.

Fixes ARMmbed/mbed-tools#227

@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch 5 times, most recently from f59b4f9 to 841ba5a Compare April 7, 2021 08:05
@LDong-Arm
Copy link
Contributor

Could add "Fixes #227" in the PR description to link to the issue

@Patater
Copy link
Contributor Author

Patater commented Apr 8, 2021

Could add "Fixes #227" in the PR description to link to the issue

Added Fixes ARMmbed/mbed-tools#227 to the commit message to make the link. Thanks.

@LDong-Arm
Copy link
Contributor

LDong-Arm commented Apr 8, 2021

Could add "Fixes #227" in the PR description to link to the issue

Added Fixes ARMmbed/mbed-tools#227 to the commit message to make the link. Thanks.

Ah I didn't realise it was a different project. It seems GitHub may not pick up links sometimes.

@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch from 841ba5a to 7b7dc0b Compare April 8, 2021 16:43
@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch from 7b7dc0b to 023a2be Compare April 9, 2021 12:52
Copy link
Contributor

@wernerlewis wernerlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LDong-Arm
Copy link
Contributor

^ A couple of last-minute comments

@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch from 023a2be to 793e32e Compare April 13, 2021 08:47
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch from 793e32e to 375ffd7 Compare April 16, 2021 13:40
Patater added 2 commits April 16, 2021 14:42
Add a migration guide to help show how to do things that Mbed CLI 1 could do using Mbed CLI 2. Fixes ARMmbed/mbed-tools#227
Add missing step to generate an `mbed_config.cmake` file. Without this, it wasn't possible to follow the instructions given. Update the CMake build directory to match the path naming convention that Mbed CLI 2 uses, so that manually moving around the `configure` subcommand generated `mbed_config.cmake` isn't necessary. Matching path conventions isn't required and the path can be any valid path that contains a valid `mbed_config.cmake` file. Fixes ARMmbed/mbed-tools#263 Fixes ARMmbed/mbed-tools#260
@Patater Patater force-pushed the add-mbed-cli-2-migration-guide branch from 375ffd7 to 3fd85ee Compare April 16, 2021 13:43
Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants