- Notifications
You must be signed in to change notification settings - Fork 177
mbed_cli_2: Add migration guide #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbed_cli_2: Add migration guide #1441
Conversation
f59b4f9
to 841ba5a
Compare Could add "Fixes #227" in the PR description to link to the issue |
Added |
Ah I didn't realise it was a different project. It seems GitHub may not pick up links sometimes. |
841ba5a
to 7b7dc0b
Compare 7b7dc0b
to 023a2be
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
^ A couple of last-minute comments |
023a2be
to 793e32e
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
793e32e
to 375ffd7
Compare Add a migration guide to help show how to do things that Mbed CLI 1 could do using Mbed CLI 2. Fixes ARMmbed/mbed-tools#227
Add missing step to generate an `mbed_config.cmake` file. Without this, it wasn't possible to follow the instructions given. Update the CMake build directory to match the path naming convention that Mbed CLI 2 uses, so that manually moving around the `configure` subcommand generated `mbed_config.cmake` isn't necessary. Matching path conventions isn't required and the path can be any valid path that contains a valid `mbed_config.cmake` file. Fixes ARMmbed/mbed-tools#263 Fixes ARMmbed/mbed-tools#260
375ffd7
to 3fd85ee
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add a migration guide to help show how to do things that Mbed CLI 1
could do using Mbed CLI 2.
Fixes ARMmbed/mbed-tools#227