Skip to content

Conversation

@avanaur
Copy link
Contributor

@avanaur avanaur commented Jun 18, 2022

Changes

Support listing of file and not just directory.

The /v1/file/list/{allocation} now supports listing of a file. The result will be listing of its parent directory and only the file as result.

Fixes

Resolves #699

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2022

Codecov Report

Merging #730 (0b0e9e6) into staging (a2eaa88) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@ Coverage Diff @@ ## staging #730 +/- ## =========================================== - Coverage 24.19% 24.15% -0.05%  =========================================== Files 69 69 Lines 7898 7913 +15 =========================================== Hits 1911 1911 - Misses 5703 5718 +15  Partials 284 284 
Flag Coverage Δ
Unit-Tests 24.15% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../0chain.net/blobbercore/handler/storage_handler.go 23.77% <0.00%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2eaa88...0b0e9e6. Read the comment docs.

@avanaur avanaur marked this pull request as ready for review June 18, 2022 04:43
@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests feature/list-file
gosdk staging
zboxcli feature/list-file
zwalletcli staging
0chain staging
blobber feature/list-file
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging
@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests feature/list-file
gosdk staging
zboxcli feature/list-file
zwalletcli staging
0chain staging
blobber feature/list-file
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging
@cnlangzi cnlangzi requested a review from peterlimg June 20, 2022 02:10
Copy link
Contributor

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterlimg peterlimg merged commit 784fb36 into staging Jun 22, 2022
@cnlangzi cnlangzi deleted the feature/list-file branch January 29, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants