Skip to content

Commit 0b0e9e6

Browse files
authored
Merge branch 'staging' into feature/list-file
2 parents e1dc925 + a2eaa88 commit 0b0e9e6

File tree

10 files changed

+31
-45
lines changed

10 files changed

+31
-45
lines changed

code/go/0chain.net/blobber/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ func reloadConfig() error {
152152
}
153153

154154
config.Configuration.Capacity = viper.GetInt64("capacity")
155-
config.Configuration.ChallengeCompletionTime = viper.GetDuration("challenge_completion_time")
155+
156156
config.Configuration.MaxOfferDuration = viper.GetDuration("max_offer_duration")
157157
config.Configuration.MaxStake = int64(viper.GetFloat64("max_stake") * 1e10)
158158
config.Configuration.MinLockDemand = viper.GetFloat64("min_lock_demand")

code/go/0chain.net/blobbercore/config/config.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func SetupDefaultConfig() {
3232
viper.SetDefault("write_price", 0.0)
3333
viper.SetDefault("min_lock_demand", 0.0)
3434
viper.SetDefault("max_offer_duration", time.Duration(0))
35-
viper.SetDefault("challenge_completion_time", time.Duration(-1))
35+
3636
viper.SetDefault("read_lock_timeout", time.Duration(-1))
3737
viper.SetDefault("write_lock_timeout", time.Duration(-1))
3838
viper.SetDefault("write_marker_lock_timeout", time.Second*30)
@@ -120,12 +120,11 @@ type Config struct {
120120
MinioBucket string
121121
MinioRegion string
122122

123-
ReadPrice float64
124-
WritePrice float64
125-
PriceInUSD bool
126-
MinLockDemand float64
127-
MaxOfferDuration time.Duration
128-
ChallengeCompletionTime time.Duration
123+
ReadPrice float64
124+
WritePrice float64
125+
PriceInUSD bool
126+
MinLockDemand float64
127+
MaxOfferDuration time.Duration
129128

130129
ReadLockTimeout int64 // seconds
131130
WriteLockTimeout int64 // seconds

code/go/0chain.net/blobbercore/config/settings.go

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,17 @@ import (
1717
const TableNameSettings = "settings"
1818

1919
type Settings struct {
20-
ID string `gorm:"column:id;size:10;primaryKey"`
21-
Capacity int64 `gorm:"column:capacity;not null;default:0"`
22-
ChallengeCompletionTime string `gorm:"column:challenge_completion_time;size:30;default:'-1ns';not null"`
23-
MaxOfferDuration string `gorm:"column:max_offer_duration;size:30;default:'-1ns';not null"`
24-
MaxStake int64 `gorm:"column:max_stake;not null;default:100"`
25-
MinLockDemand float64 `gorm:"column:min_lock_demand;not null;default:0"`
26-
MinStake int64 `gorm:"column:min_stake;not null;default:1"`
27-
NumDelegates int `gorm:"column:num_delegates;not null;default:100"`
28-
ReadPrice float64 `gorm:"column:read_price;not null;default:0"`
29-
WritePrice float64 `gorm:"column:write_price;not null;default:0"`
30-
ServiceCharge float64 `gorm:"column:service_charge;not null;default:0"`
31-
UpdatedAt time.Time `gorm:"column:updated_at;not null;default:NOW()"`
20+
ID string `gorm:"column:id;size:10;primaryKey"`
21+
Capacity int64 `gorm:"column:capacity;not null;default:0"`
22+
MaxOfferDuration string `gorm:"column:max_offer_duration;size:30;default:'-1ns';not null"`
23+
MaxStake int64 `gorm:"column:max_stake;not null;default:100"`
24+
MinLockDemand float64 `gorm:"column:min_lock_demand;not null;default:0"`
25+
MinStake int64 `gorm:"column:min_stake;not null;default:1"`
26+
NumDelegates int `gorm:"column:num_delegates;not null;default:100"`
27+
ReadPrice float64 `gorm:"column:read_price;not null;default:0"`
28+
WritePrice float64 `gorm:"column:write_price;not null;default:0"`
29+
ServiceCharge float64 `gorm:"column:service_charge;not null;default:0"`
30+
UpdatedAt time.Time `gorm:"column:updated_at;not null;default:NOW()"`
3231
}
3332

3433
func (s Settings) TableName() string {
@@ -43,11 +42,6 @@ func (s *Settings) CopyTo(c *Config) error {
4342
}
4443

4544
c.Capacity = s.Capacity
46-
cct, err := time.ParseDuration(s.ChallengeCompletionTime)
47-
if err != nil {
48-
return errors.Throw(constants.ErrInvalidParameter, "ChallengeCompletionTime")
49-
}
50-
c.ChallengeCompletionTime = cct
5145

5246
maxOfferDuration, err := time.ParseDuration(s.MaxOfferDuration)
5347
if err != nil {
@@ -72,7 +66,6 @@ func (s *Settings) CopyFrom(c *Config) error {
7266
}
7367

7468
s.Capacity = c.Capacity
75-
s.ChallengeCompletionTime = c.ChallengeCompletionTime.String()
7669
s.MaxOfferDuration = c.MaxOfferDuration.String()
7770
s.MaxStake = c.MaxStake
7871
s.MinLockDemand = c.MinLockDemand
@@ -138,7 +131,6 @@ func ReloadFromChain(ctx context.Context, db *gorm.DB) (*zcncore.Blobber, error)
138131
}
139132

140133
Configuration.Capacity = int64(b.Capacity)
141-
Configuration.ChallengeCompletionTime = b.Terms.ChallengeCompletionTime
142134
Configuration.MaxOfferDuration = b.Terms.MaxOfferDuration
143135
Configuration.MaxStake = int64(b.StakePoolSettings.MaxStake)
144136
Configuration.MinLockDemand = b.Terms.MinLockDemand

code/go/0chain.net/blobbercore/handler/protocol.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ func getStorageNode() (*transaction.StorageNode, error) {
6868
sn.Terms.WritePrice = int64(zcncore.ConvertToValue(writePrice))
6969
sn.Terms.MinLockDemand = config.Configuration.MinLockDemand
7070
sn.Terms.MaxOfferDuration = config.Configuration.MaxOfferDuration
71-
sn.Terms.ChallengeCompletionTime = config.Configuration.ChallengeCompletionTime
7271

7372
sn.StakePoolSettings.DelegateWallet = config.Configuration.DelegateWallet
7473
sn.StakePoolSettings.MinStake = config.Configuration.MinStake

code/go/0chain.net/blobbercore/stats/blobberstats.go

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -81,14 +81,13 @@ type BlobberStats struct {
8181
AllocationListPagination *Pagination `json:"allocation_list_pagination,omitempty"`
8282

8383
// configurations
84-
Capacity int64 `json:"capacity"`
85-
ReadPrice float64 `json:"read_price"`
86-
WritePrice float64 `json:"write_price"`
87-
MinLockDemand float64 `json:"min_lock_demand"`
88-
MaxOfferDuration time.Duration `json:"max_offer_duration"`
89-
ChallengeCompletionTime time.Duration `json:"challnge_completion_time"`
90-
ReadLockTimeout Duration `json:"read_lock_timeout"`
91-
WriteLockTimeout Duration `json:"write_lock_timeout"`
84+
Capacity int64 `json:"capacity"`
85+
ReadPrice float64 `json:"read_price"`
86+
WritePrice float64 `json:"write_price"`
87+
MinLockDemand float64 `json:"min_lock_demand"`
88+
MaxOfferDuration time.Duration `json:"max_offer_duration"`
89+
ReadLockTimeout Duration `json:"read_lock_timeout"`
90+
WriteLockTimeout Duration `json:"write_lock_timeout"`
9291

9392
AllocationStats []*AllocationStats `json:"-"`
9493

@@ -121,7 +120,6 @@ func (bs *BlobberStats) loadBasicStats(ctx context.Context) {
121120
bs.WritePrice = config.Configuration.WritePrice
122121
bs.MinLockDemand = config.Configuration.MinLockDemand
123122
bs.MaxOfferDuration = config.Configuration.MaxOfferDuration
124-
bs.ChallengeCompletionTime = config.Configuration.ChallengeCompletionTime
125123
bs.ReadLockTimeout = Duration(config.Configuration.ReadLockTimeout)
126124
bs.WriteLockTimeout = Duration(config.Configuration.WriteLockTimeout)
127125
//

code/go/0chain.net/blobbercore/stats/handler.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,6 @@ const tpl = `
149149
<tr><td>Write price</td><td>{{ .WritePrice }}</td></tr>
150150
<tr><td>Min lock demand</td><td>{{ .MinLockDemand }}</td></tr>
151151
<tr><td>Max offer duration</td><td>{{ .MaxOfferDuration }}</td></tr>
152-
<tr><td>Challenge completion_time</td><td>{{ .ChallengeCompletionTime }}</td></tr>
153152
<tr><td>Read lock timeout</td><td>{{ .ReadLockTimeout }}</td></tr>
154153
<tr><td>Write lock timeout</td><td>{{ .WriteLockTimeout }}</td></tr>
155154
</table>

code/go/0chain.net/core/transaction/entity.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ type Terms struct {
5050
MinLockDemand float64 `json:"min_lock_demand"`
5151
// MaxOfferDuration with this prices and the demand.
5252
MaxOfferDuration time.Duration `json:"max_offer_duration"`
53-
// ChallengeCompletionTime is duration required to complete a
54-
// challenge.
55-
ChallengeCompletionTime time.Duration `json:"challenge_completion_time"`
5653
}
5754

5855
type StakePoolSettings struct {

config/0chain_blobber.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ min_lock_demand: 0.1
3838
# max_offer_duration restrict long contracts where,
3939
# in the future, prices can be changed
4040
max_offer_duration: 744h # 31 day
41-
challenge_completion_time: 2m # duration to complete a challenge
41+
4242
# these timeouts required by blobber to check client pools, perform
4343
# a task and redeem tokens, it should be big enough
4444
read_lock_timeout: 1m

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ go 1.18
44

55
require (
66
github.com/0chain/errors v1.0.3
7-
github.com/0chain/gosdk v1.8.5-0.20220617011132-aa10bcd8eaf5
7+
github.com/0chain/gosdk v1.8.5-0.20220616142527-4950deef2e5b
88
github.com/DATA-DOG/go-sqlmock v1.5.0
99
github.com/didip/tollbooth/v6 v6.1.2
1010
github.com/gorilla/handlers v1.5.1

go.sum

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,10 @@ collectd.org v0.3.0/go.mod h1:A/8DzQBkF6abtvrT2j/AU/4tiBgJWYyh0y/oB/4MlWE=
4242
dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7gZCb22OMCxBHrMx7a5I7Hp++hsVxbQ4BYO7hU=
4343
github.com/0chain/errors v1.0.3 h1:QQZPFxTfnMcRdt32DXbzRQIfGWmBsKoEdszKQDb0rRM=
4444
github.com/0chain/errors v1.0.3/go.mod h1:xymD6nVgrbgttWwkpSCfLLEJbFO6iHGQwk/yeSuYkIc=
45-
github.com/0chain/gosdk v1.8.5-0.20220617011132-aa10bcd8eaf5 h1:DUalOG9rNmgGVhU3e7gd8uOBspd8axvBApDqIPuUiw4=
46-
github.com/0chain/gosdk v1.8.5-0.20220617011132-aa10bcd8eaf5/go.mod h1:2paTmVrhhLCuhpXUbol9wLYbXl6RxcisrixIf45nFSA=
45+
github.com/0chain/gosdk v1.8.5-0.20220615000522-eb3ca6c70dea h1:HC7yfcjPHr2r4no/Fybt7kqtU9lE2/6mryUVYjGCr/s=
46+
github.com/0chain/gosdk v1.8.5-0.20220615000522-eb3ca6c70dea/go.mod h1:2paTmVrhhLCuhpXUbol9wLYbXl6RxcisrixIf45nFSA=
47+
github.com/0chain/gosdk v1.8.5-0.20220616142527-4950deef2e5b h1:iyNzc0FRLs54Sg9KdAm+2xjfYOkpQ+1qKtnF8l3hLlU=
48+
github.com/0chain/gosdk v1.8.5-0.20220616142527-4950deef2e5b/go.mod h1:2paTmVrhhLCuhpXUbol9wLYbXl6RxcisrixIf45nFSA=
4749
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.19.0/go.mod h1:h6H6c8enJmmocHUbLiiGY6sx7f9i+X3m1CHdd5c6Rdw=
4850
github.com/Azure/azure-sdk-for-go/sdk/azcore v0.21.1/go.mod h1:fBF9PQNqB8scdgpZ3ufzaLntG0AG7C1WjPMsiFOmfHM=
4951
github.com/Azure/azure-sdk-for-go/sdk/azidentity v0.11.0/go.mod h1:HcM1YX14R7CJcghJGOYCgdezslRSVzqwLf/q+4Y2r/0=

0 commit comments

Comments
 (0)