gitea/helm-gitea
Fork 169
Code Issues 54 Pull Requests 11 Actions Releases 103 Activity

Fix Ingress #70

Merged
lunny merged 2 commits from fix-ingress into master 2020-11-26 09:01:17 +00:00
Conversation 3 Commits 2 Files Changed 2 +6 -5
luhahn commented 2020-11-26 08:23:14 +00:00
Member
Copy Link

Since there was a little mess up with ingress
I've reworked the api check for which version we're running.

Also added pathType to ingress, since it is required in v1 and optional in v1beta1.

Tested on my clusters with ingress running. Both versions, v1beta1 and v1.

Since there was a little mess up with ingress I've reworked the api check for which version we're running. Also added pathType to ingress, since it is required in v1 and optional in v1beta1. Tested on my clusters with ingress running. Both versions, v1beta1 and v1.
luhahn added 2 commits 2020-11-26 08:23:15 +00:00
Fix Ingress 60e9d8ce34 
- Ingress uses now .Capabilities.APIVersions.Has to compare the api version available - Added pathType since it is required in v1 and optional in v1beta1
Bump chart version to 2.0.7
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
39faf8dc0d
zeripath approved these changes 2020-11-26 08:37:17 +00:00
Dismissed
lunny approved these changes 2020-11-26 09:00:57 +00:00
Dismissed
lunny merged commit 63bc10e393 into master 2020-11-26 09:01:17 +00:00
lunny referenced this issue from a commit 2020-11-26 09:01:17 +00:00
Fix Ingress (#70)
mjanser reviewed 2020-12-01 19:50:24 +00:00
Dismissed
templates/gitea/ingress.yaml Outdated
@@ -2,3 +2,3 @@
{{- $fullName := include "gitea.fullname" . -}}
{{- $httpPort := .Values.service.http.port -}}
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1" -}}
mjanser commented 2020-12-01 19:50:24 +00:00
First-time contributor
Copy Link

Shouldn't these checks be more explicit, something like .Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress"?

I currently get the following error on my cluster:

no matches for kind "Ingress" in version "networking.k8s.io/v1"

It seems I have networkpolicies in v1 but not ingress:

$ kubectl get networkpolicies.v1.networking.k8s.io No resources found. $ kubectl get ingress.v1.networking.k8s.io error: the server doesn't have a resource type "ingress" $ kubectl get ingress.v1beta1.networking.k8s.io No resources found.
Shouldn't these checks be more explicit, something like `.Capabilities.APIVersions.Has "networking.k8s.io/v1/Ingress"`? I currently get the following error on my cluster: > no matches for kind "Ingress" in version "networking.k8s.io/v1" It seems I have networkpolicies in v1 but not ingress: ``` $ kubectl get networkpolicies.v1.networking.k8s.io No resources found. $ kubectl get ingress.v1.networking.k8s.io error: the server doesn't have a resource type "ingress" $ kubectl get ingress.v1beta1.networking.k8s.io No resources found. ```
arcalys commented 2020-12-02 19:45:18 +00:00
First-time contributor
Copy Link

Encountered the same issue. That's because ingress has been moved to /v1 with Kubernetes 1.19+ but still in /v1beta1 in 1.18 (which I am running).

Still need to check the cluster version I guess.

Encountered the same issue. That's because ingress has been moved to /v1 with Kubernetes 1.19+ but still in /v1beta1 in 1.18 (which I am running). Still need to check the cluster version I guess.
luhahn commented 2020-12-02 20:50:15 +00:00
Author
Member
Copy Link

will have a look at it tomorrow, thanks for finding this.

will have a look at it tomorrow, thanks for finding this.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#70
No description provided.
Delete Branch "fix-ingress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?