gitea/helm-gitea
Fork 169
Code Issues 53 Pull Requests 11 Actions Releases 103 Activity

Breaking change to ingress in 2.0.4 #66

New Issue
Closed
opened 2020-11-25 13:10:30 +00:00 by onedr0p · 6 comments
onedr0p commented 2020-11-25 13:10:30 +00:00
Contributor
Copy Link

Breaking change due to the ingress spec changing in k8s 1.19. The chart will not work with ingress enabled if you are on 1.19.

Helm upgrade failed: error validating "": error validating data: [ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "serviceName" in io.k8s.api.networking.v1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "servicePort" in io.k8s.api.networking.v1.IngressBackend]

Discord conversation: https://discord.com/channels/322538954119184384/730458347928813581/780995708861284392

Breaking change due to the ingress spec changing in k8s 1.19. The chart will not work with ingress enabled if you are on 1.19. ``` Helm upgrade failed: error validating "": error validating data: [ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "serviceName" in io.k8s.api.networking.v1.IngressBackend, ValidationError(Ingress.spec.rules[0].http.paths[0].backend): unknown field "servicePort" in io.k8s.api.networking.v1.IngressBackend] ``` Discord conversation: https://discord.com/channels/322538954119184384/730458347928813581/780995708861284392
joelgallant commented 2020-11-25 14:32:59 +00:00
Contributor
Copy Link

fwiw 2.0.3 doesn't have this problem - this was my mistake (sorry!). fix is in PR.

fwiw 2.0.3 doesn't have this problem - this was my mistake (sorry!). fix is in PR.
jkroepke commented 2020-11-25 19:24:26 +00:00
Copy Link

Hi,

I tried 2.0.5 agist Kubernetes 1.19.4 with Helm 3.4.1 and its broken (while 2.0.3 works):

jkr@joe-nb charts % helm install --dry-run gitea gitea/gitea -f values/gitea.yaml -f ../.local/gitea.yaml --version 2.0.5 Error: template: gitea/templates/gitea/ingress.yaml:38:57: executing "gitea/templates/gitea/ingress.yaml" at <.Capabilities.KubeVersion.GitVersion>: can't evaluate field Capabilities in type interface {} jkr@joe-nb charts % helm install --dry-run gitea gitea/gitea -f values/gitea.yaml -f ../.local/gitea.yaml --version 2.0.3 W1125 20:22:01.779485 37789 warnings.go:67] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress NAME: gitea LAST DEPLOYED: Wed Nov 25 20:22:01 2020 NAMESPACE: default STATUS: pending-install REVISION: 1 HOOKS: ---

Looking at other charts, they using .Capabilities.APIVersions.Has "networking.k8s.io/v1 instead .Capabilities.KubeVersion.GitVersion which is working great.

Hi, I tried 2.0.5 agist Kubernetes 1.19.4 with Helm 3.4.1 and its broken (while 2.0.3 works): ``` jkr@joe-nb charts % helm install --dry-run gitea gitea/gitea -f values/gitea.yaml -f ../.local/gitea.yaml --version 2.0.5 Error: template: gitea/templates/gitea/ingress.yaml:38:57: executing "gitea/templates/gitea/ingress.yaml" at <.Capabilities.KubeVersion.GitVersion>: can't evaluate field Capabilities in type interface {} jkr@joe-nb charts % helm install --dry-run gitea gitea/gitea -f values/gitea.yaml -f ../.local/gitea.yaml --version 2.0.3 W1125 20:22:01.779485 37789 warnings.go:67] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress NAME: gitea LAST DEPLOYED: Wed Nov 25 20:22:01 2020 NAMESPACE: default STATUS: pending-install REVISION: 1 HOOKS: --- ``` Looking at other charts, they using `.Capabilities.APIVersions.Has "networking.k8s.io/v1` instead `.Capabilities.KubeVersion.GitVersion` which is working great.
joelgallant commented 2020-11-25 19:27:12 +00:00
Contributor
Copy Link

See gitea/helm-chart#67

See https://gitea.com/gitea/helm-chart/pulls/67
onedr0p commented 2020-11-26 02:00:52 +00:00
Author
Contributor
Copy Link

@joelgallant you didn't bump the version with that fix... we need a 2.0.6

@joelgallant you didn't bump the version with that fix... we need a 2.0.6
luhahn commented 2020-11-26 08:28:35 +00:00
Member
Copy Link

@jkroepke thanks for the suggestion I've added this into #70
Hopefully all issues in ingress are resolved with this PR. Finally had time to test it.

@jkroepke thanks for the suggestion I've added this into #70 Hopefully all issues in ingress are resolved with this PR. Finally had time to test it.
luhahn commented 2020-11-26 09:26:00 +00:00
Member
Copy Link

Fixed with #70

Fixed with #70
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#66
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?