gitea/helm-gitea
Fork 169
Code Issues 53 Pull Requests 11 Actions Releases 103 Activity

Fixes networking.k8s.io/v1 Ingress fields #65

Merged
techknowlogick merged 1 commits from joelgallant/helm-chart:v1-ingress into master 2020-11-25 15:28:53 +00:00
Conversation 5 Commits 1 Files Changed 1 +7
joelgallant commented 2020-11-24 23:11:39 +00:00
Contributor
Copy Link

Appologies - I was just trying out 2.0.4. I'm new to helm so I'm not entirely sure how I'd test this without doing a separate deployment. Fixes my mistake from !63.

Docs https://kubernetes.io/docs/concepts/services-networking/ingress/

Appologies - I was just trying out 2.0.4. I'm new to helm so I'm not entirely sure how I'd test this without doing a separate deployment. Fixes my mistake from !63. Docs https://kubernetes.io/docs/concepts/services-networking/ingress/
joelgallant added 1 commit 2020-11-24 23:11:39 +00:00
Use apiVersion v1 for Ingress in 1.19+
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cf51165ecb 
Currently, a warning is shown in newer versions of kubernetes: ``` W1120 10:04:16.194312 8003 warnings.go:67] networking.k8s.io/v1beta1 Ingress is deprecated in v1.19+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress ```
luhahn commented 2020-11-25 08:51:00 +00:00
Member
Copy Link

please resolve the conflicts in your branch

please resolve the conflicts in your branch
luhahn requested changes 2020-11-25 09:02:28 +00:00
Dismissed
templates/gitea/ingress.yaml Outdated
@@ -33,7 +35,14 @@ spec:
paths:
- path: /
backend:
{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.GitVersion -}}
luhahn commented 2020-11-25 09:02:22 +00:00
Member
Copy Link

isn't this logically wrong and should be <= ? Since serviceName and servicePort are the old values

isn't this logically wrong and should be <= ? Since serviceName and servicePort are the old values
joelgallant commented 2020-11-25 14:31:03 +00:00
Author
Contributor
Copy Link

You're right, thanks!

You're right, thanks!
joelgallant marked this conversation as resolved
onedr0p commented 2020-11-25 13:14:54 +00:00
Contributor
Copy Link

Closes gitea/helm-chart#66

Closes https://gitea.com/gitea/helm-chart/issues/66
joelgallant force-pushed v1-ingress from 044d36c92d to 40f8d4557a 2020-11-25 14:30:41 +00:00 Compare
joelgallant requested review from luhahn 2020-11-25 14:31:44 +00:00
luhahn approved these changes 2020-11-25 14:34:45 +00:00
Dismissed
techknowlogick approved these changes 2020-11-25 15:28:47 +00:00
Dismissed
techknowlogick merged commit a26b4e10d1 into master 2020-11-25 15:28:53 +00:00
joelgallant deleted branch v1-ingress 2020-11-25 15:31:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
has
backport
in progress
invalid
kind
breaking
kind
bug
kind
build
kind
dependency
kind
deployment
kind
docs
kind
enhancement
kind
feature
kind
lint
kind
proposal
kind
question
kind
refactor
kind
security
kind
testing
kind
translation
kind
ui
need
backport
priority
critical
priority
low
priority
maybe
priority
medium
reviewed
duplicate
reviewed
invalid
reviewed
wontfix
skip-changelog
status
blocked
status
needs-feedback
status
needs-reviews
status
wip
upstream
gitea
upstream
other
workaround
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
42wim 6543 a1012112796 Akkuman appleboy axifive betacat0 blumia bwko caicandong ChristopherHX DaanSelen davidsvantesson delvh denyskon fuxiaohei gary-kim garymoon giteabot guillep2k HesterG hiifong jaqra jolheiser jonasfranz jpraet kdumontnu kemzeb kerwin612 khmarbaise KN4CK3R kolaente lafriks lng2020 lotherk luhahn lunny mrsdizzie noerw pat-s puni9869 renovate-bot richmahn rossigee sapk screenshots sillyguodong silverwind smartclip_tim strk tboerger techknowlogick TheFox0x7 tobiasbp typeless volker.raschek wolfogre wxiaoguang yardenshoham yp05327 zeripath Zettat123
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: gitea/helm-gitea#65
No description provided.
Delete Branch "joelgallant/helm-chart:v1-ingress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?