gitea/go-sdk
Fork 95
Code Issues 25 Pull Requests 5 Actions Releases 23 Activity

ListIssues: add milestones filter #327

Merged
6543 merged 6 commits from 6543/go-sdk:ListIssues-add-milestones into master 2020-05-20 06:48:24 +00:00
Conversation 3 Commits 6 Files Changed 2 +28 -14
2 changed files with 28 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
gitea/issue.go
View File

@@ -56,10 +56,11 @@ type Issue struct {
// ListIssueOption list issue options
type ListIssueOption struct {
ListOptions
State StateType
Type IssueType
Labels []string
KeyWord string
State StateType
Type IssueType
Labels []string
Milestones []string
KeyWord string
}
// StateType issue state type
@@ -89,24 +90,25 @@ const (
// QueryEncode turns options into querystring argument
func (opt *ListIssueOption) QueryEncode() string {
query := opt.getURLQuery()
if len(opt.State) > 0 {
query.Add("state", string(opt.State))
}
if len(opt.Labels) > 0 {
var lq string
for _, l := range opt.Labels {
if len(lq) > 0 {
lq += ","
}
lq += l
}
query.Add("labels", lq)
query.Add("labels", strings.Join(opt.Labels, ","))
}
if len(opt.KeyWord) > 0 {
query.Add("q", opt.KeyWord)
}
6543 marked this conversation as resolved Outdated
zeripath commented 2020-05-19 06:33:01 +00:00
Outdated
Review
Copy Link

Why'd you change this?

Why'd you change this?
6543 commented 2020-05-19 07:20:05 +00:00
Outdated
Review
Copy Link

as the the related commit message tell: code formateion

to make it similar to milestone ones

and I choose for i := range objlist over for _, o := range objlist because of speed thoughts

as the the related commit message tell: code formateion to make it similar to milestone ones and I choose `for i := range objlist` over `for _, o := range objlist` because of speed thoughts
6543 commented 2020-05-19 10:28:02 +00:00
Outdated
Review
Copy Link

strings.Join 🎉

strings.Join :tada:
query.Add("type", string(opt.Type))
if len(opt.Milestones) > 0 {
query.Add("milestones", strings.Join(opt.Milestones, ","))
}
return query.Encode()
}

16
gitea/issue_test.go
View File

@@ -71,12 +71,12 @@ func listIssues(t *testing.T, c *Client) {
log.Println("== TestListIssues ==")
issues, err := c.ListRepoIssues("test01", "IssueTestsRepo", ListIssueOption{
Labels: []string{"Label2"},
Labels: []string{"Label1", "Label2"},
KeyWord: "",
State: "all",
})
assert.NoError(t, err)
assert.Len(t, issues, 2)
assert.Len(t, issues, 1)
issues, err = c.ListIssues(ListIssueOption{
Labels: []string{"Label2"},
@@ -86,6 +86,18 @@ func listIssues(t *testing.T, c *Client) {
assert.NoError(t, err)
assert.Len(t, issues, 1)
issues, err = c.ListRepoIssues("test01", "IssueTestsRepo", ListIssueOption{
Milestones: []string{"mile1"},
State: "all",
})
assert.NoError(t, err)
assert.Len(t, issues, 3)
for i := range issues {
if assert.NotNil(t, issues[i].Milestone) {
assert.EqualValues(t, "mile1", issues[i].Milestone.Title)
}
}
issues, err = c.ListRepoIssues("test01", "IssueTestsRepo", ListIssueOption{})
assert.NoError(t, err)
assert.Len(t, issues, 3)