ListIssues: add milestones filter #327

6543 · 2020-05-18T17:12:03Z

6543 commented

2020-05-18 17:12:03 +00:00

as title
close #322

as title close #322

6543 added the kind/enhancement label 2020-05-18 17:12:16 +00:00

6543 added this to the v0.12.0 milestone 2020-05-18 17:12:56 +00:00

zeripath reviewed 2020-05-19 06:33:01 +00:00

Dismissed

gitea/issue.go Outdated

              @@ -99,3 +102,3 @@  
     lq += ","  
     }  
     lq += l  
     lq += opt.Labels[i]  
  

zeripath commented

2020-05-19 06:33:01 +00:00

Why'd you change this?

6543 commented

2020-05-19 07:20:05 +00:00

as the the related commit message tell: code formateion

to make it similar to milestone ones

and I choose for i := range objlist over for _, o := range objlist because of speed thoughts

as the the related commit message tell: code formateion to make it similar to milestone ones and I choose `for i := range objlist` over `for _, o := range objlist` because of speed thoughts

6543 commented

2020-05-19 10:28:02 +00:00

strings.Join 🎉

strings.Join :tada:

6543 marked this conversation as resolved

zeripath approved these changes 2020-05-19 10:44:18 +00:00

Dismissed

lunny approved these changes 2020-05-20 05:00:20 +00:00

Dismissed

6543 referenced this issue from a commit

2020-05-20 06:48:11 +00:00

ListIssues: add milestones filter (#327) use string.Join Code Format add test case add Milestones to ListIssueOption Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: 6543 <6543@obermui.de> Reviewed-on: https://gitea.com/gitea/go-sdk/pulls/327 Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>

6543 merged commit f224b4e50c into master

2020-05-20 06:48:15 +00:00

6543 deleted branch ListIssues-add-milestones

2020-05-20 06:48:26 +00:00

Sign in to join this conversation.

3 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitea/go-sdk#327

Allow edits from maintainers