add I2S and EDMA support for IMX9 platform #97777
Conversation
| Hello @yananyang-nxp, and thank you very much for your first pull request to the Zephyr project! |
| The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions bot added manifest manifest-hal_nxp DNM (manifest) 
zephyrbot added area: Clock Control area: DMA zephyrbot requested review from EmilioCBen, JiafeiPan, MaochenWang1, PetervdPerk-NXP, ZhaoxiangJin, Zhiqiang-Hou, axelnxp, bperseghetti, dbaluta, decsny, dleach02, iuliana-prodan, manuargue, mmahadevan108 and yangbolu1991 
| @yananyang-nxp you don't need to reference the HAL PR in your initial comment. The automation in Zephyr automatically highlights this. Please address the CI failures |
JiafeiPan force-pushed the imx9_i2s_edma branch from a9b1f83 to ee01c55 Compare 
| Rebsed to fix twister issues not caused by this PR. |
| /* | ||
| * Copyright 2020-2024 NXP | ||
| * Copyright 2020-2025 NXP | ||
| * |
There was a problem hiding this comment.
Please explain in the commit message why this entire change is needed.
There was a problem hiding this comment.
No functionality change, just updated to use the device model MMIO APIs.
| case IMX_CCM_SAI3_CLK: | ||
| clock_root = kCLOCK_Root_Sai3; | ||
| clock_root = kCLOCK_Root_Sai3; | ||
| break; |
There was a problem hiding this comment.
Please don't mix code cleanups with new feature. Create a separate patch for cleanups.
There was a problem hiding this comment.
Fixed in the updated PR. Thanks!
| * Copyright 2021,2023-2025 NXP Semiconductor INC. | ||
| * Copyright 2021,2023-2025 NXP | ||
| * All rights reserved. | ||
| * |
There was a problem hiding this comment.
Please don't mix fixes with new features.
For example here the correction of DMA burst length should be in a separate patch.
Please read this
https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements
There was a problem hiding this comment.
Fixed in the updated PR, please help to have a review again. Thanks!
| }; | ||
| | ||
| edma4_2: edma@42000000 { | ||
| compatible = "nxp,mcux-edma"; |
There was a problem hiding this comment.
Please explain what is sai3_2 and edma4_2. Why such nodes are needed.
Update hal_nxp revision to pull/623. Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Enable MMIO mapping in dma_mcux_edma driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
add SAI clock support for i.MX9 platform Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com> Fix CI failure: LEADING_SPACE: please, no spaces at the start of a line Split code format fixing into a new patch Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Remove extra space between the '=' and rvalue. Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
The burst length should be initialized with 'word_size_bits'. Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Change to use device model MMIO mapping APIs. Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com> Fix CI failures: Clean unused code Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Correct the type of num_of_bufs to uint32_t. Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
When the platform has the Bit Clock Swap feature, enable it. Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Rework the driver to support i.MX9 platforms. Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com> Signed-off-by: Yanan Yang <yanan.yang@nxp.com> Signed-off-by: Jiafei Pan <Jiafei.Pan@nxp.com>
add add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
add sai3_2 and edma4_2 dts node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
add sai3_2 and edma4_2 node for use with i2s_mcux_sai driver Signed-off-by: Yanan Yang <yanan.yang@nxp.com>
Zhiqiang-Hou force-pushed the imx9_i2s_edma branch from ee01c55 to bac888f Compare 
| Updated:
|
|
8 participants
add I2S and EDMA support for IMX9 platform