Skip to content

Base types on generics, not global JSX namespace #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Base types on generics, not global JSX namespace #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cdaab93
Base types on generics, not global JSX namespace
remcohaszing Feb 13, 2024
c1e1119
Add test components param type annotations
remcohaszing Feb 20, 2024
ec61793
Move all `@template` tags on top
remcohaszing Feb 20, 2024
fde3379
Accept the JSX function type as a generic
remcohaszing Feb 16, 2024
c4ed721
Add missing inline docs
remcohaszing Mar 1, 2024
79ad7d1
Fix type-coverage issues
remcohaszing Mar 1, 2024
44edfb9
Fix type of self
remcohaszing Mar 8, 2024
9e01023
Revert unrelated changes
remcohaszing Mar 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move all @template tags on top
  • Loading branch information
@remcohaszing
remcohaszing committed Mar 1, 2024
commit ec61793f54a6d1f6cd799225be213c39af195a66
14 changes: 7 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,42 +10,42 @@
*/

/**
* @typedef {import('./lib/index.js').CreateEvaluater<JSXElementType>} CreateEvaluater
* @template JSXElementType
* @typedef {import('./lib/index.js').CreateEvaluater<JSXElementType>} CreateEvaluater
*/

/**
* @typedef {import('./lib/index.js').EvaluateExpression<JSXElementType>} EvaluateExpression
* @template JSXElementType
* @typedef {import('./lib/index.js').EvaluateExpression<JSXElementType>} EvaluateExpression
*/

/**
* @typedef {import('./lib/index.js').Evaluater<JSXElementType>} Evaluater
* @template JSXElementType
* @typedef {import('./lib/index.js').Evaluater<JSXElementType>} Evaluater
*/

/**
* @typedef {import('./lib/index.js').Jsx<JSXElementType, JSXElement>} Jsx
* @template JSXElementType
* @template JSXElement
* @typedef {import('./lib/index.js').Jsx<JSXElementType, JSXElement>} Jsx
*/

/**
* @typedef {import('./lib/index.js').JsxDev<JSXElementType, JSXElement>} JsxDev
* @template JSXElementType
* @template JSXElement
* @typedef {import('./lib/index.js').JsxDev<JSXElementType, JSXElement>} JsxDev
*/

/**
* @typedef {import('./lib/index.js').Options<JSXElementType, JSXElement>} Options
* @template JSXElementType
* @template JSXElement
* @typedef {import('./lib/index.js').Options<JSXElementType, JSXElement>} Options
*/

/**
* @typedef {import('./lib/index.js').Props<JSXElement>} Props
* @template JSXElementType
* @template JSXElement
* @typedef {import('./lib/index.js').Props<JSXElement>} Props
*/

export {toJsxRuntime} from './lib/index.js'
14 changes: 7 additions & 7 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
*/

/**
* @template JSXElementType
* @template JSXElement
* @callback Create
* Create something in development or production.
* @param {Nodes} node
Expand All @@ -48,8 +50,6 @@
* Key.
* @returns {JSXElement}
* Result.
* @template JSXElementType
* @template JSXElement
*/

/**
Expand Down Expand Up @@ -105,6 +105,8 @@
*/

/**
* @template JSXElementType
* @template JSXElement
* @callback Jsx
* Create a production element.
* @param {JSXElementType} type
Expand All @@ -115,11 +117,11 @@
* Dynamicly generated key to use.
* @returns {JSXElement}
* Element from your framework.
* @template JSXElementType
* @template JSXElement
*/

/**
* @template JSXElementType
* @template JSXElement
* @callback JsxDev
* Create a development element.
* @param {JSXElementType} type
Expand All @@ -137,17 +139,15 @@
* Nothing (this is used by frameworks that have components, we don’t).
* @returns {JSXElement}
* Element from your framework.
* @template JSXElementType
* @template JSXElement
*/

/**
* @template JSXElement
* @typedef {{
* children?: Array<Child<JSXElement>> | Child<JSXElement>, node?: Element | MdxJsxFlowElement | MdxJsxTextElement | undefined,
* [prop: string]: Array<Child<JSXElement>> | Child<JSXElement> | Element | MdxJsxFlowElement | MdxJsxTextElement | Value | undefined
* }} Props
* Properties and children.
* @template JSXElement
*/

/**
Expand Down