Skip to content

Base types on generics, not global JSX namespace #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Base types on generics, not global JSX namespace #6

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cdaab93
Base types on generics, not global JSX namespace
remcohaszing Feb 13, 2024
c1e1119
Add test components param type annotations
remcohaszing Feb 20, 2024
ec61793
Move all `@template` tags on top
remcohaszing Feb 20, 2024
fde3379
Accept the JSX function type as a generic
remcohaszing Feb 16, 2024
c4ed721
Add missing inline docs
remcohaszing Mar 1, 2024
79ad7d1
Fix type-coverage issues
remcohaszing Mar 1, 2024
44edfb9
Fix type of self
remcohaszing Mar 8, 2024
9e01023
Revert unrelated changes
remcohaszing Mar 18, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix type-coverage issues
  • Loading branch information
@remcohaszing
remcohaszing committed Mar 1, 2024
commit 79ad7d1d173afd0c284faeedfd44806cc09fcff1
8 changes: 6 additions & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,9 @@ function productionCreate(_, jsx, jsxs) {
/** @type {Create<JsxFunction>} */
function create(_, type, props, key) {
// Only an array when there are 2 or more children.
const isStaticChildren = Array.isArray(props.children)
const isStaticChildren = Array.isArray(
/** @type {Record<String, unknown>} */ (props).children
)
const fn = isStaticChildren ? jsxs : jsx
return key ? fn(type, props, key) : fn(type, props)
}
Expand All @@ -780,7 +782,9 @@ function developmentCreate(filePath, jsxDEV) {
/** @type {Create<JsxFunction>} */
function create(node, type, props, key) {
// Only an array when there are 2 or more children.
const isStaticChildren = Array.isArray(props.children)
const isStaticChildren = Array.isArray(
/** @type {Record<String, unknown>} */ (props).children
)
const point = pointStart(node)
return jsxDEV(
type,
Expand Down
7 changes: 7 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/**
* @typedef {import('estree').Program} Program
* @typedef {import('hast').Nodes} Nodes
*
* @typedef {import('hast-util-to-jsx-runtime').CreateEvaluater<typeof production.jsx>} CreateEvaluater
*
Expand Down Expand Up @@ -549,6 +550,9 @@ test('components', async function (t) {
...production,
passNode: true,
components: {
/**
* @param {{ node: Nodes }} props
*/
b(props) {
assert.ok(props.node)
return 'a'
Expand All @@ -567,6 +571,9 @@ test('components', async function (t) {
toJsxRuntime(h('b'), {
...production,
components: {
/**
* @param {{ node: Nodes }} props
*/
b(props) {
assert.equal(props.node, undefined)
return 'a'
Expand Down