Fix memory queue not blocking on Next #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jfontan approved these changes Sep 27, 2018
kuba-- approved these changes Sep 27, 2018
ajnavarro approved these changes Sep 28, 2018
mcarmonaa approved these changes Sep 28, 2018
erizocosmico approved these changes Sep 28, 2018
jfontan added a commit to jfontan/go-queue that referenced this pull request Oct 3, 2018
This adds the possibility to create memory queues that do not block when the queue EOFs. This mimics the behavior before src-d#13 that is expected by other projects. Signed-off-by: Javi Fontan <jfontan@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There is a bug in the memory queue. It does not block on
Next(), instead it returns aniljob.If
nextreturnsnil, nil, thisifcondition is never true andNextreturns aniljob, instead of blocking until the queue has a new job.Digging a bit I found these two commits, that as far as I can see can be safely reverted:
65798d3
6757b6d
cc @erizocosmico