Add finite memory queue #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds the possibility to create memory queues that do not block when the queue EOFs. This mimics the behavior before src-d#13 that is expected by other projects. Signed-off-by: Javi Fontan <jfontan@gmail.com>
| Personally, I would consider use channels here or pass context with cancel to consumer ( |
| I would also use a channel here. In fact the AMQP version uses a channel behind the scenes. The problem is that there's software already using this interface (rovers, borges and lookout). |
erizocosmico approved these changes Oct 3, 2018
mcarmonaa approved these changes Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds the possibility to create memory queues that do not block when the queue EOFs. This mimics the behavior before #13 that is expected by other projects.