Site performance optimizations. #199
Conversation
| Is |
.gitignore Outdated
There was a problem hiding this comment.
/.idea should not be there. If should be in your global gitignore file.
There was a problem hiding this comment.
Ah, true, I'll remove it here.
| With the potential rebase on top of #200, that's all. |
| assets/img/scala-js-site-logo.ai contains an editable version (where the text is real text, not just curves) of the logo. Needed for any changes in font etc. |
| I also fixed the problem with |
There was a problem hiding this comment.
Hum, so, if I understand this change correctly, this turns the top-left title text into an image. What motivated you to do this? To me, it seems this basically makes the user download two images instead of one.
There was a problem hiding this comment.
This was to get rid of a font used solely for the site logo. Also alignment and sizing of the icon + text is difficult to control for different devices (especially if people zoom in/out), so a single logo image is better.
| LGTM |
2 participants
Reduce the number of requests and optimize resources. Using googleapis.com seems to be blocked in China, so moved all fonts local with different variants to support all browsers.
Uses the jekyll-assets processing pipeline, so some assets were moved under _assets. Bundled CSS and JS are hashed to support forever caching.
Site colors are now configured in the style.scss file instead of Jekyll _config.yml.
Front page load went from 23 requests down to 11 requests.