Skip to content

Fix the style.css file so that it is not binary. #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix the style.css file so that it is not binary. #200

wants to merge 1 commit into from

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Nov 27, 2015 

sed -e 's/\x00\x00/ /'
@sjrd
Copy link
Member Author

sjrd commented Nov 27, 2015

Review by @ochrons
@ochrons
Copy link
Contributor

ochrons commented Nov 27, 2015

Github still shows it to me as binary, but maybe that's because of diffing to the old one?

Anyway, this is "rewritten" in my latest PR.
@sjrd
Copy link
Member Author

sjrd commented Nov 27, 2015

Yes it's the diff. If you click on View it shows it as text, now.

I saw that it's rewritten in your PR. Merging this one first would at least show the other rewrite as a Move instead of a file coming out of the blue. As you wish.
@sjrd sjrd mentioned this pull request Nov 27, 2015
Merged
@ochrons
Copy link
Contributor

ochrons commented Nov 27, 2015

I would just drop this, as the new version has the (S)CSS file in a different location (due to asset bundling) and with a different extension and basically every line is touched due to changes and cleanup.
@sjrd
Copy link
Member Author

sjrd commented Nov 27, 2015

OK.
@sjrd sjrd closed this Nov 27, 2015
@sjrd sjrd deleted the fix-style-css-binary branch November 27, 2015 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sjrd @ochrons