Rollup of 14 pull requests #87923
Merged
Rollup of 14 pull requests #87923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
to avoid passing `SymbolPrinter` by value.
- also clarifies how thread.join and detaching of threads works - the previous prose implied that there is a relationship between a spawning thread and the thread being spawned, and that "child" threads couldn't outlive their parents unless detached, which is incorrect.
Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing code to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
Change code blocks to Rust
Also moves the target into alphabetical order
…oticed that zip had no tests)
…literals/patterns - typeck/expr: don't suggest adding fields in struct literals with inaccessible fields - typeck/pat: suggest ignoring inaccessible fields in struct patterns
Constify implementations of `(Try)From` for int types I believe this to be one of the (many?) things blocking const (Range) iterators. ~~If this is to be merged maybe that should wait until `#![feature(const_trait_impl)]` no longer needs `#![allow(incomplete_features)]`?~~ - Done
…erister Implement `Printer` for `&mut SymbolPrinter` to avoid passing `SymbolPrinter` by value.
Added the `Option::unzip()` method * Adds the `Option::unzip()` method to turn an `Option<(T, U)>` into `(Option<T>, Option<U>)` under the `unzip_option` feature * Adds tests for both `Option::unzip()` and `Option::zip()`, I noticed that `.zip()` didn't have any * Adds `#[inline]` to a few of `Option`'s methods that were missing it
Expand explanation of E0530 The explanation didn't cover a puzzling case of enum variants missing fields.
Do not ICE on HIR based WF check when involving lifetimes Fix rust-lang#87549.
…ation-fix, r=joshtriplett removed references to parent/child from std::thread documentation - also clarifies how thread.join and detaching of threads works - the previous prose implied that there is a relationship between a spawning thread and the thread being spawned, and that "child" threads couldn't outlive their "parents" unless detached, which is incorrect.
correctly handle enum variants in `opt_const_param_of` Fixes rust-lang#87542 `opt_const_param_of` was returning `None` for args on an enum variant `Enum::Variant::<10>` because we called `generics_of` on the enum variant which has no generics. r? `@oli-obk`
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
Clarify terms in rustdoc book Fixes rust-lang#70898 I chose to completely remove the term directive over attribute because rustdoc has a lint called `invalid_codeblock_attributes` and the term attributes is used throughout the book. I slightly changed the introductory sentence to describe the relationship between annotations and attributes. I also moved the text explaining the example from below the blocks to above the blocks which is more in line with the rest of the book. I also changed the description for the `should_panic` attribute as I found it a little confusing. Finally, some of the blocks were `text` and some were `rust` so I changed them all to `text` which is in line with the rest of the book.
add `windows` count test cc rust-lang#87767
…d, r=LeSeulArtichaut Remove duplicate trait bounds in `rustc_data_structures::graph` Remove duplicate trait bounds in `rustc_data_structures::graph`.
… r=ehuss Proper table row formatting in platform support Also moves the target into alphabetical order
…r=oli-obk Use smaller spans when suggesting method call disambiguation Use smaller spans when suggesting method call disambiguation.
typeck: don't suggest inaccessible fields in struct literals and suggest ignoring inaccessible fields in struct patterns Fixes rust-lang#87872. This PR adjusts the missing field diagnostic logic in typeck so that when any of the missing fields in a struct literal or pattern is inaccessible then the error is less confusing, even if some of the missing fields are accessible. See also rust-lang#76524.
Member Author
| @bors r+ p=14 rollup=never |
Collaborator
| 📌 Commit 4be63b2 has been approved by |
bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions |
This was referenced Aug 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
(Try)Fromfor int types #86840 (Constify implementations of(Try)Fromfor int types)Printerfor&mut SymbolPrinter#87582 (ImplementPrinterfor&mut SymbolPrinter)Option::unzip()method #87636 (Added theOption::unzip()method)opt_const_param_of#87854 (correctly handle enum variants inopt_const_param_of)windowscount test #87876 (addwindowscount test)rustc_data_structures::graph#87880 (Remove duplicate trait bounds inrustc_data_structures::graph)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup