Fix heading colours in Ayu theme #87861
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing code to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
Contributor
| Some changes occurred in HTML/CSS/JS. |
Contributor
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive added the S-waiting-on-review 
Member
| Thanks! @bors: r+ rollup |
Collaborator
| 📌 Commit 9a78489 has been approved by |
bors added S-waiting-on-bors 
GuillaumeGomez approved these changes Aug 8, 2021
Contributor Author
| @GuillaumeGomez Sorry, I misclicked closing and reopening the pull request. This probably reset bors but I'm not sure how to check. |
Member
| You can check it on https://bors.rust-lang.org/queue/rust. And apparently it's still ok for bors. :) |
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 10, 2021
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Aug 10, 2021
Fix heading colours in Ayu theme Closes rust-lang#87828 The issue seems to stem from rust-lang#87210 where code headings were changed from a heading containing a `code` element to a heading with the `code-header` class. `rustdoc.css` was updated, but `ayu.css` was missed.
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2021
Rollup of 14 pull requests Successful merges: - rust-lang#86840 (Constify implementations of `(Try)From` for int types) - rust-lang#87582 (Implement `Printer` for `&mut SymbolPrinter`) - rust-lang#87636 (Added the `Option::unzip()` method) - rust-lang#87700 (Expand explanation of E0530) - rust-lang#87811 (Do not ICE on HIR based WF check when involving lifetimes) - rust-lang#87848 (removed references to parent/child from std::thread documentation) - rust-lang#87854 (correctly handle enum variants in `opt_const_param_of`) - rust-lang#87861 (Fix heading colours in Ayu theme) - rust-lang#87865 (Clarify terms in rustdoc book) - rust-lang#87876 (add `windows` count test) - rust-lang#87880 (Remove duplicate trait bounds in `rustc_data_structures::graph`) - rust-lang#87881 (Proper table row formatting in platform support) - rust-lang#87889 (Use smaller spans when suggesting method call disambiguation) - rust-lang#87895 (typeck: don't suggest inaccessible fields in struct literals and suggest ignoring inaccessible fields in struct patterns) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2021
…=notriddle Add rustdoc GUI test for headers Add test for rust-lang#87861. r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2021
…=notriddle Add rustdoc GUI test for headers Add test for rust-lang#87861. r? ``@notriddle``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #87828
The issue seems to stem from #87210 where code headings were changed from a heading containing a
codeelement to a heading with thecode-headerclass.rustdoc.csswas updated, butayu.csswas missed.