Addressed review feedback

test/JsonApiDotNetCoreExampleTests/IntegrationTests/ControllerActionResults/ActionResultTests.cs

@@ -46,7 +46,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
  public async Task Converts_empty_ActionResult_to_error_collection()
  {
  // Arrange
- var route = "/toothbrushes/11111111";
+ var route = "/toothbrushes/" + BaseToothbrushesController._emptyActionResultId;
 
  // Act
  var (httpResponse, responseDocument) = await _testContext.ExecuteGetAsync<ErrorDocument>(route);
@@ -64,7 +64,7 @@ public async Task Converts_empty_ActionResult_to_error_collection()
  public async Task Converts_ActionResult_with_error_object_to_error_collection()
  {
  // Arrange
- var route = "/toothbrushes/22222222";
+ var route = "/toothbrushes/" + BaseToothbrushesController._actionResultWithErrorObjectId;
 
  // Act
  var (httpResponse, responseDocument) = await _testContext.ExecuteGetAsync<ErrorDocument>(route);
@@ -82,7 +82,7 @@ public async Task Converts_ActionResult_with_error_object_to_error_collection()
  public async Task Cannot_convert_ActionResult_with_string_parameter_to_error_collection()
  {
  // Arrange
- var route = "/toothbrushes/33333333";
+ var route = "/toothbrushes/" + BaseToothbrushesController._actionResultWithStringParameter;
 
  // Act
  var (httpResponse, responseDocument) = await _testContext.ExecuteGetAsync<ErrorDocument>(route);
@@ -100,7 +100,7 @@ public async Task Cannot_convert_ActionResult_with_string_parameter_to_error_col
  public async Task Converts_ObjectResult_with_error_object_to_error_collection()
  {
  // Arrange
- var route = "/toothbrushes/44444444";
+ var route = "/toothbrushes/" + BaseToothbrushesController._objectResultWithErrorObjectId;
 
  // Act
  var (httpResponse, responseDocument) = await _testContext.ExecuteGetAsync<ErrorDocument>(route);
@@ -118,7 +118,7 @@ public async Task Converts_ObjectResult_with_error_object_to_error_collection()
  public async Task Converts_ObjectResult_with_error_objects_to_error_collection()
  {
  // Arrange
- var route = "/toothbrushes/55555555";
+ var route = "/toothbrushes/" + BaseToothbrushesController._objectResultWithErrorCollectionId;
 
  // Act
  var (httpResponse, responseDocument) = await _testContext.ExecuteGetAsync<ErrorDocument>(route);

test/JsonApiDotNetCoreExampleTests/IntegrationTests/ControllerActionResults/BaseToothbrushesController.cs

@@ -12,6 +12,12 @@ namespace JsonApiDotNetCoreExampleTests.IntegrationTests.ControllerActionResults
 {
  public abstract class BaseToothbrushesController : BaseJsonApiController<Toothbrush>
  {
+ public const int _emptyActionResultId = 11111111;
+ public const int _actionResultWithErrorObjectId = 22222222;
+ public const int _actionResultWithStringParameter = 33333333;
+ public const int _objectResultWithErrorObjectId = 44444444;
+ public const int _objectResultWithErrorCollectionId = 55555555;
+
  protected BaseToothbrushesController(IJsonApiOptions options, ILoggerFactory loggerFactory,
  IResourceService<Toothbrush> resourceService)
  : base(options, loggerFactory, resourceService)
@@ -20,30 +26,30 @@ protected BaseToothbrushesController(IJsonApiOptions options, ILoggerFactory log
 
  public override async Task<IActionResult> GetAsync(int id, CancellationToken cancellationToken)
  {
- if (id == 11111111)
+ if (id == _emptyActionResultId)
  {
  return NotFound();
  }
 
- if (id == 22222222)
+ if (id == _actionResultWithErrorObjectId)
  {
  return NotFound(new Error(HttpStatusCode.NotFound)
  {
  Title = "No toothbrush with that ID exists."
  });
  }
 
- if (id == 33333333)
+ if (id == _actionResultWithStringParameter)
  {
  return Conflict("Something went wrong.");
  }
 
- if (id == 44444444)
+ if (id == _objectResultWithErrorObjectId)
  {
  return Error(new Error(HttpStatusCode.BadGateway));
  }
 
- if (id == 55555555)
+ if (id == _objectResultWithErrorCollectionId)
  {
  var errors = new[]
  {
@@ -60,4 +66,4 @@ public override async Task<IActionResult> GetAsync(int id, CancellationToken can
  return await base.GetAsync(id, cancellationToken);
  }
  }
-}
+}

test/JsonApiDotNetCoreExampleTests/IntegrationTests/ControllerActionResults/Toothbrush.cs

@@ -1,8 +1,11 @@
 using JsonApiDotNetCore.Resources;
+using JsonApiDotNetCore.Resources.Annotations;
 
 namespace JsonApiDotNetCoreExampleTests.IntegrationTests.ControllerActionResults
 {
  public sealed class Toothbrush : Identifiable
  {
+ [Attr]
+ public bool IsElectric { get; set; }
  }
 }