Refactor tests #941
Merged
Refactor tests #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 30 commits January 26, 2021 11:21
…ome duplication and fixed an equality bug.
…se it has a strong dependency on EmptyStartup from JsonApiDotNetCoreExamples project.
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/RestrictedControllers/Table.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/NamingConventions/KebabCasingTests.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/NamingConventions/KebabCasingTests.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/ObjectAssertionsExtensions.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/ExceptionHandling/ExceptionHandlerTests.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
...otNetCoreExampleTests/IntegrationTests/RestrictedControllers/BlockingHttpDeleteController.cs Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTestConfiguration.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
.../JsonApiDotNetCoreExampleTests/IntegrationTests/ControllerActionResults/ActionResultTests.cs Outdated Show resolved Hide resolved
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/ControllerActionResults/Toothbrush.cs Show resolved Hide resolved
added 2 commits February 5, 2021 10:52
…yStrings subfolder and auto-adjusted namespaces.
maurei reviewed Feb 5, 2021
maurei reviewed Feb 5, 2021
maurei reviewed Feb 5, 2021
test/JsonApiDotNetCoreExampleTests/IntegrationTests/ResourceHooks/ResourceHookTests.cs Outdated Show resolved Hide resolved
maurei suggested changes Feb 5, 2021
added 4 commits February 6, 2021 01:56
…t, so they can share private models with integration tests for query strings. They are likely to evolve simultaneously, so I prefer not to make a copy of them. Renamed Blog to LegacyBlog in preparation for refactoring to make query string tests run against private models. LegacyBlog is going away at the end.
…ges: LegacyBlog -> Blog Title -> Title CompanyName -> PlatformName HasMany Articles -> Posts HasOne Owner -> Owner Article -> BlogPost Caption -> Caption Url -> Url HasOne Author -> Author + HasOne Reviewer HasManyThrough Tags -> Labels HasMany Revisions -> Comments HasOne Blog -> Parent Tag -> Label Name -> Name Color -> Color HasManyThrough Articles -> Posts Revision -> Comment + Text PublishTime -> CreatedAt HasOne Author -> Author HasOne Article -> Parent Author -> WebAccount FirstName/LastName -> UserName/DisplayName + Password DateOfBirth -> DateOfBirth BusinessEmail -> EmailAddress LivingAddress -> Preferences HasMany Articles -> Posts Address -> AccountPreferences + UseDarkTheme
maurei approved these changes Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #715. It's probably easiest to review per commit.
With the new infrastructure in place and all integration tests using them, we can now run them in parallel.
Running all tests on my machine (before): 56 sec
Running all tests on my machine (after): 23 sec
That's 60% faster than before!
Also fixed an invalid comparison of primitive values (due to boxing) when using
?defaults=falsequery string parameter, which resulted in some defaults still being rendered.