Skip to content

Conversation

@LukeShu
Copy link

@LukeShu LukeShu commented Apr 22, 2024

Before 324513b (2012-01-04) std "html" and what is now
"golang.org/x/net/html" were the same. Ever since then (well, since
4e0749a (2012-05-29)) the escape/unescape code that they share has
been drifting apart, each receiving separate improvements.

This CL cherry-picks over all of the changes that "x/net/html" has
seen.

This is the counterpart to https://golang.org/cl/580855, and so also
includes the de-duplication requested at
https://go-review.googlesource.com/c/net/+/580855/comment/8f8679a3_12b9ead1/

4e0749a :

Author: Andrew Balholm <andybalholm@gmail.com> Date: Wed May 30 15:50:12 2012 +1000 exp/html: Convert \r and \r\n to \n when tokenizing Also escape "\r" as "&#13;" when rendering HTML. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6260046 

golang/net@3d87fd6 :

Author: Dmitry Savintsev <dsavints@gmail.com> Date: Thu Feb 26 23:44:25 2015 +0100 x/net/html: Sync the html parser and atom with the current whatwg spec The current documentation as well as set of atoms and attributes has gotten slightly out of sync with the current state of the WHATWG html5 specification. The change adds and removes several of the atoms and attributes, updates the documentation (such as steps numbering in inBodyEndTagFormatting) and modifies the spec URLs to https:// Change-Id: I6dfa52785858c1521301b20b1e585e19a08b1e98 Reviewed-on: https://go-review.googlesource.com/6173 Reviewed-by: Nigel Tao <nigeltao@golang.org> 
@gopherbot
Copy link
Contributor

This PR (HEAD: af7627f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580896.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luke Shumaker:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luke Shumaker:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luke Shumaker:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nigel Tao:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

Before 324513b (2012-01-04) std "html" and what is now "golang.org/x/net/html" were the same. Ever since then (well, since 4e0749a (2012-05-29)) the escape/unescape code that they share has been drifting apart, each receiving separate improvements. This CL cherry-picks over all of the changes that "x/net/html" has seen. This is the counterpart to https://golang.org/cl/580855, and so also includes the de-duplication requested at https://go-review.googlesource.com/c/net/+/580855/comment/8f8679a3_12b9ead1/ golang@4e0749a : Author: Andrew Balholm <andybalholm@gmail.com> Date: Wed May 30 15:50:12 2012 +1000 exp/html: Convert \r and \r\n to \n when tokenizing Also escape "\r" as "&golang#13;" when rendering HTML. Pass 2 additional tests. R=nigeltao CC=golang-dev https://golang.org/cl/6260046 golang/net@3d87fd6 : Author: Dmitry Savintsev <dsavints@gmail.com> Date: Thu Feb 26 23:44:25 2015 +0100 x/net/html: Sync the html parser and atom with the current whatwg spec The current documentation as well as set of atoms and attributes has gotten slightly out of sync with the current state of the WHATWG html5 specification. The change adds and removes several of the atoms and attributes, updates the documentation (such as steps numbering in inBodyEndTagFormatting) and modifies the spec URLs to https:// Change-Id: I6dfa52785858c1521301b20b1e585e19a08b1e98 Reviewed-on: https://go-review.googlesource.com/6173 Reviewed-by: Nigel Tao <nigeltao@golang.org>
@LukeShu LukeShu force-pushed the lukeshu/html-sync branch from af7627f to c668d2e Compare July 8, 2024 19:36
@gopherbot
Copy link
Contributor

This PR (HEAD: c668d2e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580896.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Luke T. Shumaker:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/580896.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants