Skip to content

Feature/option specify msvc runtime library #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Feature/option specify msvc runtime library #160

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cde6800
cmake option to specify msvc runtime
vimanyu Oct 12, 2020
cde0375
fixed typo
vimanyu Oct 12, 2020
cd978a7
ending logical block
vimanyu Oct 12, 2020
8593746
Merge branch 'dev' into feature/option-specify-msvc-runtime-library
vimanyu Oct 13, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,16 @@ set(FIREBASE_GEN_FILE_DIR ${CMAKE_BINARY_DIR}/generated)
# Directory for any shared scripts.
set(FIREBASE_SCRIPT_DIR ${CMAKE_CURRENT_LIST_DIR})

if (MSVC AND MSVC_RUNTIME_LIBRARY_STATIC)
# Use Multithreaded static runtime libraries for MSVC
# if MSVC_RUNTIME_LIBRARY_STATIC is set.
# Default value if nothing is specified is /MD (dll dynamic runtime).
set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} /MTd")
set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} /MT")
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} /MTd")
set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} /MT")
endif()

if (FIREBASE_CPP_BUILD_TESTS AND MSVC)
# GoogleTest requires MSVC to compile with the static version of the runtime
# library, so define the appropriate runtime flag, before adding libraries.
Expand Down