Feature/option specify msvc runtime library #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding a new option "MSVC_RUNTIME_LIBRARY_STATIC" to cmake to compile with /MT. (If nothing is specified, the default behaviour is to use /MD)
jonsimantov approved these changes Oct 13, 2020
a-maurice approved these changes Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New option added to our cmake system to specify "/MT", instead of default value of "/MD".
cmake .. -DMSVC_RUNTIME_LIBRARY_STATIC=ONWhen we upgrade to CMake >3.15, we could use an inbuilt cmake variable
MSVC_RUNTIME_LIBRARYto achieve the same. For ease of use, I made this a toggle instead of a string option.Tested on Windows and confirmed that the final libs are being built respecting this option.