Skip to content

Update build_testapps script to log generated files. #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Update build_testapps script to log generated files. #1378

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
489b609
update build testapps script
AlmostMatt Jun 30, 2023
0c1988a
Don't log generated files for gha build
AlmostMatt Jun 30, 2023
6f07ba5
Merge branch 'main' into amatt-build-testapps
AlmostMatt Jul 4, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions scripts/gha/build_testapps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,11 @@ def main(argv):
short_output_paths=FLAGS.short_output_paths)
logging.info("END building for %s", testapp)

_collect_integration_tests(testapps, root_output_dir, output_dir, FLAGS.artifact_name)
integration_test_files = _collect_integration_tests(
testapps, root_output_dir, output_dir, FLAGS.artifact_name)

_summarize_results(testapps, platforms, failures, root_output_dir, FLAGS.artifact_name)
_summarize_results(
testapps, platforms, failures, root_output_dir, FLAGS.artifact_name, integration_test_files)
return 1 if failures else 0


Expand Down Expand Up @@ -434,19 +436,22 @@ def _collect_integration_tests(testapps, root_output_dir, output_dir, artifact_n
_rm_dir_safe(artifact_path)
for testapp in testapps:
os.makedirs(os.path.join(artifact_path, testapp))
generated_files = []
for path in testapp_paths:
for testapp in testapps:
if testapp in path:
generated_files.append(os.path.join(artifact_path, testapp, os.path.basename(path)))
if os.path.isfile(path):
shutil.copy(path, os.path.join(artifact_path, testapp))
if path.endswith(desktop_testapp_name) and testapp_google_services.get(testapp):
shutil.copy(testapp_google_services[testapp], os.path.join(artifact_path, testapp))
else:
dir_util.copy_tree(path, os.path.join(artifact_path, testapp, os.path.basename(path)))
break
return generated_files


def _summarize_results(testapps, platforms, failures, root_output_dir, artifact_name):
def _summarize_results(testapps, platforms, failures, root_output_dir, artifact_name, generated_files):
"""Logs a readable summary of the results of the build."""
file_name = "build-results-" + artifact_name + ".log"

Expand All @@ -461,6 +466,10 @@ def _summarize_results(testapps, platforms, failures, root_output_dir, artifact_
summary.append("SOME ERRORS OCCURRED:")
for i, failure in enumerate(failures, start=1):
summary.append("%d: %s" % (i, failure.describe()))
if generated_files:
summary.append("GENERATED FILES:")
summary.extend(generated_files)

summary = "\n".join(summary)

logging.info(summary)
Expand Down