Skip to content

Update build_testapps script to log generated files. #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 5, 2023
Merged

Update build_testapps script to log generated files. #1378

merged 3 commits into from
Jul 5, 2023

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented Jun 30, 2023 •
edited
Loading

Description

Update the build_testapps script to additionally log the generated files so that users of this script don't need to search in the generated folders to find the output.

Example:
python scripts/gha/build_testapps.py --p Desktop,Android --t auth,remote_config --output_directory build_folder

TRIED TO BUILD: auth,remote_config
ON PLATFORMS: Desktop,Android
ALL BUILDS SUCCEEDED
GENERATED FILES:
/Users/almostmatt/Documents/GitHub/firebase-cpp-sdk/build_folder/testapps-local-build/auth/integration_test
/Users/almostmatt/Documents/GitHub/firebase-cpp-sdk/build_folder/testapps-local-build/auth/integration_test-debug.apk
/Users/almostmatt/Documents/GitHub/firebase-cpp-sdk/build_folder/testapps-local-build/remote_config/integration_test
/Users/almostmatt/Documents/GitHub/firebase-cpp-sdk/build_folder/testapps-local-build/remote_config/integration_test-debug.apk

Testing

Ran locally for various platforms, Ran quick github integration tests.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@AlmostMatt AlmostMatt added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @AlmostMatt on commit 20891fd
Last updated: Wed Jul 5 14:41 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [ERROR] [iOS] [macos] [1/2 ios_device: ios_target]
messaging [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@AlmostMatt AlmostMatt requested review from a-maurice and jonsimantov and removed request for a-maurice June 30, 2023 20:59
jonsimantov
jonsimantov suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, but could you make it so that the list of generated files is not printed out if the --gha_build option is passed in? This will make it only print out the list if the script is manually being run - if it's running in CI, the list is not needed.
@AlmostMatt
Copy link
Contributor Author

AlmostMatt commented Jun 30, 2023

Done. (Added a check for FLAGS.gha_build)
@AlmostMatt AlmostMatt enabled auto-merge (squash) July 4, 2023 18:08
@AlmostMatt AlmostMatt disabled auto-merge July 5, 2023 18:43
@AlmostMatt AlmostMatt merged commit 20891fd into main Jul 5, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 5, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 5, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@AlmostMatt @tom-andersen
Update build_testapps script to log generated files. (#1378)
54493f2 
* log generated files for non-ghabuild testapps
@AlmostMatt AlmostMatt deleted the amatt-build-testapps branch August 1, 2023 19:37
@firebase firebase locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

2 participants

@AlmostMatt @jonsimantov