Skip to content

[Fix] Uncaught IllegalStateException #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Fix] Uncaught IllegalStateException #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions admob/src_java/com/google/firebase/admob/internal/cpp/InterstitialAdHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.google.android.gms.ads.AdRequest;
import com.google.android.gms.ads.InterstitialAd;

import java.lang.IllegalStateException;
/**
* Helper class to make interactions between the AdMob C++ wrapper and Java {@link InterstitialAd}
* objects cleaner. It's designed to wrap and adapt a single instance of {@link InterstitialAd},
Expand Down Expand Up @@ -91,15 +92,18 @@ public void initialize(final long callbackDataPtr, Activity activity, String adU
public void run() {
int errorCode;
String errorMessage;
errorCode = ConstantsHelper.CALLBACK_ERROR_ALREADY_INITIALIZED;
errorMessage = ConstantsHelper.CALLBACK_ERROR_MESSAGE_ALREADY_INITIALIZED;
if (mInterstitial == null) {
errorCode = ConstantsHelper.CALLBACK_ERROR_NONE;
errorMessage = ConstantsHelper.CALLBACK_ERROR_MESSAGE_NONE;
mInterstitial = new InterstitialAd(mActivity);
mInterstitial.setAdUnitId(mAdUnitId);
mInterstitial.setAdListener(new InterstitialAdListener());
} else {
errorCode = ConstantsHelper.CALLBACK_ERROR_ALREADY_INITIALIZED;
errorMessage = ConstantsHelper.CALLBACK_ERROR_MESSAGE_ALREADY_INITIALIZED;
try {
mInterstitial = new InterstitialAd(mActivity);
mInterstitial.setAdUnitId(mAdUnitId);
mInterstitial.setAdListener(new InterstitialAdListener());
errorCode = ConstantsHelper.CALLBACK_ERROR_NONE;
errorMessage = ConstantsHelper.CALLBACK_ERROR_MESSAGE_NONE;
} catch(IllegalStateException ise) {
Copy link
Contributor

@vimanyu vimanyu Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you seeing errors while creating a new ad too?
In this block of code, the only thing that can throw this exception is setAdUnitId. Also if that is the case, is the error message representative of the fact?
Copy link
Author

@berinhardt berinhardt Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it has something to do with using a wrong or changed AdUnitId. But by leaving a possible exception uncaught it ends up crashing JNI instead of failing the future
mInterstitial = null;
}
}

completeInterstitialAdFutureCallback(callbackDataPtr, errorCode, errorMessage);
Expand Down Expand Up @@ -152,7 +156,18 @@ public void run() {
mLoadAdCallbackDataPtr = CPP_NULLPTR;
}
} else {
mInterstitial.loadAd(request);
try {
mInterstitial.loadAd(request);
} catch (IllegalStateException ise) {
synchronized (mInterstitialLock) {
completeInterstitialAdFutureCallback(
mLoadAdCallbackDataPtr,
ConstantsHelper.CALLBACK_ERROR_UNINITIALIZED,
ConstantsHelper.CALLBACK_ERROR_MESSAGE_UNINITIALIZED);
mLoadAdCallbackDataPtr = CPP_NULLPTR;
mInterstitial = null;
}
}
}
}
});
Expand Down