Skip to content

[Fix] Uncaught IllegalStateException #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Fix] Uncaught IllegalStateException #122

wants to merge 1 commit into from

Conversation

@berinhardt
Copy link

@berinhardt berinhardt commented Aug 31, 2020

vimanyu
vimanyu reviewed Sep 18, 2020
View reviewed changes
admob/src_java/com/google/firebase/admob/internal/cpp/InterstitialAdHelper.java
mInterstitial.setAdListener(new InterstitialAdListener());
errorCode = ConstantsHelper.CALLBACK_ERROR_NONE;
errorMessage = ConstantsHelper.CALLBACK_ERROR_MESSAGE_NONE;
} catch(IllegalStateException ise) {
Copy link
Contributor

@vimanyu vimanyu Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you seeing errors while creating a new ad too?
In this block of code, the only thing that can throw this exception is setAdUnitId. Also if that is the case, is the error message representative of the fact?
Copy link
Author

@berinhardt berinhardt Sep 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, it has something to do with using a wrong or changed AdUnitId. But by leaving a possible exception uncaught it ends up crashing JNI instead of failing the future
@vimanyu
Copy link
Contributor

vimanyu commented Oct 5, 2020

Thanks for the suggested fix. We made this fix on our end and migrated it to Github. We are in the middle of migrating our workflows completely to github and will be able to accept contributions like this later.
@vimanyu vimanyu closed this Oct 5, 2020
@firebase firebase locked and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

3 participants

@berinhardt @vimanyu @googlebot