Skip to content

Fixed non string fields not rendering #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Fixed non string fields not rendering #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/containers/Results.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ function capitalizeFirstLetter(string) {
return string.charAt(0).toUpperCase() + string.slice(1);
}

function htmlEscape(str) {
return String(str)
.replace(/&/g, "&")
.replace(/"/g, """)
.replace(/'/g, "'")
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;");
}

/*
Our `Result` component expects result fields to be formatted in an object
like:
Expand All @@ -19,7 +28,9 @@ function capitalizeFirstLetter(string) {
*/
function formatResultFields(result) {
return Object.keys(result.data).reduce((acc, n) => {
let value = result.getSnippet(n);
// Fallback to raw values here, because non-string fields
// will not have a snippet fallback. Raw values MUST be html escaped.
let value = result.getSnippet(n) || htmlEscape(result.getRaw(n));
value = Array.isArray(value) ? value.join(", ") : value;
acc[`${capitalizeFirstLetter(n)}`] = value;
return acc;
Expand Down