Fixed non string fields not rendering #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We use snippet fallbacks and try to render everything by using snippet values. However, non-string fields will not have fallbacks. Because of this, we need to use raw values. Raw values must be html safe to be considered safe to use.
| LGTM. 👍 |
jgr approved these changes Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We use snippet fallbacks and try to render everything by using
snippet values. However, non-string fields will not have
fallbacks. Because of this, we need to use raw values. Raw values
must be html safe to be considered safe to use.