Skip to content

Fix crash when creating cyclic nodes #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Fix crash when creating cyclic nodes #3313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d597d14
Fix crash when creating cyclic nodes
0HyperCube Oct 26, 2025
273146c
Re-add the recursive set_input call
0HyperCube Oct 29, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions editor/src/messages/portfolio/document/utility_types/network_interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4262,11 +4262,6 @@ impl NodeNetworkInterface {
}
}

let previous_metadata = match &previous_input {
NodeInput::Node { node_id, .. } => self.position(node_id, network_path).map(|position| (*node_id, position)),
_ => None,
};

let Some(network) = self.network_mut(network_path) else {
log::error!("Could not get nested network in set_input");
return;
Expand Down Expand Up @@ -4303,6 +4298,12 @@ impl NodeNetworkInterface {
return;
}

// It is necessary to ensure the grpah is acyclic before calling `self.position` as it sometimes crashes with cyclic graphs #3227
let previous_metadata = match &previous_input {
NodeInput::Node { node_id, .. } => self.position(node_id, network_path).map(|position| (*node_id, position)),
_ => None,
};

self.transaction_modified();

// Ensure layer is toggled to non layer if it is no longer eligible to be a layer
Expand Down
Loading