Fix crash when creating cyclic nodes #3313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| !build |
|
Member
 I think the removal of the |
0HyperCube force-pushed the fix-crash-cyclic-nodes branch from fde691c to 383f5ce Compare 
Contributor Author
| @TrueDoctor I can't reproduce this, however I have reverted the change. I struggle to understand the control flow of this code since the |
Member
| !build |
Member
| @0HyperCube this seems to have fixed it, I can no longer reproduce the error |
TrueDoctor approved these changes Oct 29, 2025
|
Member
| @0HyperCube do you want to do the rebase, or should I do that? |
auto-merge was automatically disabled October 30, 2025 10:20
Head branch was pushed to by a user without write access
0HyperCube force-pushed the fix-crash-cyclic-nodes branch from 383f5ce to 273146c Compare Contributor Author
| @TrueDoctor I've rebased it. |
TrueDoctor pushed a commit to daniil-loban/Graphite that referenced this pull request Nov 2, 2025
* Fix crash when creating cyclic nodes * Re-add the recursive set_input call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #3227