add typescript typings #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Wow, thanks for the PR! I don't use TypeScript, so I don't have any easy way to verify that these type definitions are correct, so I guess I'll just assume they are. :) |
| @BigstickCarpet I've been using them to a limited extent in https://github.com/bcherny/json-schema-to-typescript. They're correct as far as I tested, and if there are errors (there's always something 😃 ) fixing them is as easy as updating them in this repo (typings have no caching layer besides NPM's, and are versioned along with the package they type). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It doesn't seem like you use TS (at least in your open source work), but it's TS best practice to commit typings directly to the repo they type.
If you would rather not do that, I can do the next best thing and commit these typings to DefinitelyTyped, the central typings repo for TypeScript.