Convert to TypeScript 💯 #100
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Initial pass
3, because I kept getting false negative tests due to bad internet connectivity.parcel. Browser tests seem to pass with it as well, but only ifindex.tsexports the class as es6 default, not cjs module that browserify needs, hence thesrc/parcel.tsfile.lib/are still the old handcrafted ones, which is why definitions aren't set to output.index.jsandparse.js, for example:index.js:
became
and likewise for the rest of the public methods.
parse.js
became
Only catching the error to decorate it, not re-resolving the success.
Becomes a linear function instead of using callbacks.