-
-
Couldn't load subscription status.
- Fork 19.2k
BUG: Take method of NumpyExtensionArray now returns another extension array with the correct dtype. #62502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aijams wants to merge 20 commits into pandas-dev:main Choose a base branch from aijams:aijams-take-function-invalid-dtype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
BUG: Take method of NumpyExtensionArray now returns another extension array with the correct dtype. #62502
Changes from 1 commit
Commits
Show all changes
20 commits Select commit Hold shift + click to select a range
7a72a06 Added test to check the dtype of the result of take method. Modified …
aijams 65511cd Added bug info to docs.
aijams 42898c6 Added conditional to handle integer arrays in take method as special …
aijams 333ba45 Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 3ca2e84 Added cases for smaller integer types to mixins take function.
aijams b6e45ac Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams e0ff0d0 Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams eeb3d85 Added note to take method.
aijams cd2f2aa Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 468de3f Added link to issue in test for take method.
aijams 91442a8 Moved changes to take method to NumpyExtensionArray class.
aijams aa3c228 Cleaned up work comments.
aijams 8bacb94 Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 56a329a Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 040c127 Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 1bdb1f8 Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams 3e5836c Tests for take method check against object dtype for boolean inputs.
aijams b4258f2 Removed TODO comment.
aijams e4c3a5b Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams acdfb62 Updated references to numpy.bool to include underscore.
aijams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added note to take method.
- Loading branch information
commit eeb3d8569c89e03511cb4c7327ca2bc6e752de6f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this on the NumpySemantics instead of this mixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean by "Numpy semantics". I changed the condition to check the
numpy_dtypeso it can be compared to a list of bare Numpy dtypes. I'm not sure if this is what you meant. Can you clarify?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, meant to write NumpyExtensionArray. Implement a take method there along the lines of