Skip to content

BUG: Take method of NumpyExtensionArray now returns another extension array with the correct dtype. #62502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

BUG: Take method of NumpyExtensionArray now returns another extension array with the correct dtype. #62502

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7a72a06
Added test to check the dtype of the result of take method. Modified …
aijams Sep 29, 2025
65511cd
Added bug info to docs.
aijams Sep 29, 2025
42898c6
Added conditional to handle integer arrays in take method as special …
aijams Oct 2, 2025
333ba45
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 2, 2025
3ca2e84
Added cases for smaller integer types to mixins take function.
aijams Oct 6, 2025
b6e45ac
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 6, 2025
e0ff0d0
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 7, 2025
eeb3d85
Added note to take method.
aijams Oct 9, 2025
cd2f2aa
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 14, 2025
468de3f
Added link to issue in test for take method.
aijams Oct 15, 2025
91442a8
Moved changes to take method to NumpyExtensionArray class.
aijams Oct 16, 2025
aa3c228
Cleaned up work comments.
aijams Oct 16, 2025
8bacb94
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 16, 2025
56a329a
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 17, 2025
040c127
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 20, 2025
1bdb1f8
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 21, 2025
3e5836c
Tests for take method check against object dtype for boolean inputs.
aijams Oct 21, 2025
b4258f2
Removed TODO comment.
aijams Oct 21, 2025
e4c3a5b
Merge remote-tracking branch 'upstream/main' into aijams-take-functio…
aijams Oct 22, 2025
acdfb62
Updated references to numpy.bool to include underscore.
aijams Oct 22, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into aijams-take-functio… 
…n-invalid-dtype
  • Loading branch information
@aijams
aijams committed Oct 17, 2025
commit 56a329a3dc0f232ee4e17d43c1dbaa0257c565dc

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.