ENH: improve DataFrame read_csv / to_csv for Index/MultiIndex #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| thanks a lot for doing this. after hemming/hawing i think it makes sense to have a default index header column. rebased into master I think it would be a good idea to make it so a regular Index can have a name attribute. Will create a separate github issue |
3 tasks
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2 issues for DataFrame.to_csv
1 ) If header and index are True, you should write something for an index header, even if index_level is None.
2) If given a MultiIndex, don't want to just call str() on each element.
Also fixed read_csv to take an iterable for index_col so that I could write tests.
I haven't looked at the similar methods in Series or the other to_* methods yet. This is all I needed at the moment.
Aside: it looks like in test_frame setUp isn't a classmethod and is called for each test method. Not a big deal, but might be a little heavy in the test suite.