-
- Notifications
You must be signed in to change notification settings - Fork 314
migrate to null safety #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Hey @viplifes, thanks a lot, It's really great 👍 . can you resolve the conflict? It seems to be caused by a different fork. |
| Conflicts have been resolved. |
| @viplifes bug on hangup |
| Thanks, fixed. You can upgrade and try again. |
| Solved, thank you! |
| @viplifes on the registering proces with the demo app (account tab) i get the error: I/flutter (15018): [2022-02-02 15:18:30.675] Level.error event_manager.dart:110 ::: type 'Null' is not a subtype of type 'bool' This stops the whole registering proces. With the non null-safety version i get a successful registration: I/flutter ( 8017): [2022-02-01 11:54:30.796] Level.debug digest_authentication.dart:178 ::: authenticate() | using qop=auth [a2:REGISTER:sip:weburl.nl] and after some seconds a registration succes: How can we resolve this failure? |
| @jongerenchaos Is there any way to reproduce this error? I guess it's a typical issue, I'll be merging this PR within the next week, but before that, I need to do a full test so that the merge will work, it's a big PR after all. |
| Yeps here are the steps that i try to do: First i downloaded the full null safety source from and use the demo application: The first registration failed (same error as on the topic #132 ) and after this invalid registration i get the error above. In the demo app without the null safety option the application will try to register again by himself and that registration is okey. I can make and receive calls.Without any reconfigurations on the asterisk application. |
| @jongerenchaos I fixed this and you can test it out, so we can move this PR forward. |
| Tnx! It works without any problem! |
* update. * chore: format and import short. * Add extended header support (#232) * hangup add the options hangup function increase self-determination option number of participants, expedient unity communication time notification * fix: Fix breaking changes. * Add extended header support Add extended header support, in order to carry custom information when calling Co-authored-by: cloudwebrtc <duanweiwei1982@gmail.com> Co-authored-by: 趙金元 <choukg.zw@gmail.com> * migrate to null safety (#247) * migrate to null safety * fix local_seqnum * support null safety for test folder * fix: fix issue for digest authentication. * chore: fix lints. Co-authored-by: cloudwebrtc <duanweiwei1982@gmail.com> * update. Co-authored-by: zi6xuan <zi6xuan@gmail.com> Co-authored-by: 趙金元 <choukg.zw@gmail.com> Co-authored-by: viplifes <viplifes@gmail.com>

I have updated all project files to support null safety.
This merge still needs to be checked and tested for errors.
But the project is already started and running.