Skip to content

Conversation

@viplifes
Copy link
Contributor

@viplifes viplifes commented Dec 1, 2021

I have updated all project files to support null safety.
This merge still needs to be checked and tested for errors.
But the project is already started and running.

@cloudwebrtc
Copy link
Member

cloudwebrtc commented Dec 2, 2021

Hey @viplifes, thanks a lot, It's really great 👍 . can you resolve the conflict? It seems to be caused by a different fork.
Then I can fully test it.

@viplifes
Copy link
Contributor Author

viplifes commented Dec 2, 2021

Conflicts have been resolved.

@viplifes viplifes mentioned this pull request Dec 2, 2021
@AlvaroVasconcelos
Copy link

@viplifes bug on hangup
image

@viplifes
Copy link
Contributor Author

viplifes commented Dec 8, 2021

Thanks, fixed. You can upgrade and try again.

@AlvaroVasconcelos
Copy link

Solved, thank you!

@jongerenchaos
Copy link

jongerenchaos commented Feb 2, 2022

@viplifes on the registering proces with the demo app (account tab) i get the error:

I/flutter (15018): [2022-02-02 15:18:30.675] Level.error event_manager.dart:110 ::: type 'Null' is not a subtype of type 'bool'
I/flutter (15018): #0 new Challenge.fromMap (package:sip_ua/src/digest_authentication.dart:10:27)
I/flutter (15018): #1 RequestSender._receiveResponse (package:sip_ua/src/request_sender.dart:122:23)
I/flutter (15018): #2 RequestSender.send. (package:sip_ua/src/request_sender.dart:57:7)
I/flutter (15018): #3 EventManager.emit. (package:sip_ua/src/event_manager/event_manager.dart:108:17)
I/flutter (15018): #4 List.forEach (dart:core-patch/growable_array.dart:433:8)
I/flutter (15018): #5 EventManager.emit (package:sip_ua/src/event_manager/event_manager.dart:105:12)
I/flutter (15018): #6 NonInviteClientTransaction.receiveResponse (package:sip_ua/src/transactions/non_invite_client.dart:96:28)
I/flutter (15018): #7 UA.onTransportData (package:sip_ua/src/ua.dart:882:25)
I/flutter (15018): #8 Transport._onData (package:sip_ua/src/transport.dart:316:11)
I/flutter (15018): #9 WebSocketInterface._onMessage (package:sip_ua/src/transports/websocket_interface.dart:172:16)
I/flutter (15018): #10 WebSocketInterface.connect. (package:sip_ua/src/transports/websocket_interface.dart:92:9)
I/flutter (15018): #11 WebSocketImpl.co

This stops the whole registering proces. With the non null-safety version i get a successful registration:

I/flutter ( 8017): [2022-02-01 11:54:30.796] Level.debug digest_authentication.dart:178 ::: authenticate() | using qop=auth [a2:REGISTER:sip:weburl.nl]
I/flutter ( 8017): [2022-02-01 11:54:30.801] Level.debug digest_authentication.dart:205 ::: authenticate() | response generated
I/flutter ( 8017): [2022-02-01 11:54:30.808] Level.debug transport.dart:168 ::: send()
I/flutter ( 8017): [2022-02-01 11:54:30.812] Level.debug websocket_interface.dart:131 ::: send()
I/flutter ( 8017): [2022-02-01 11:54:30.815] Level.debug websocket_dart_impl.dart:49 ::: send:

and after some seconds a registration succes:
I/flutter ( 8017): [2022-02-01 11:54:31.291] Level.debug sip_ua_helper.dart:144 ::: registered => Code: [200], Cause: registered, Reason: OK
I/flutter ( 8017): [2022-02-01 11:54:34.84] Level.debug websocket_interface.dart:169 ::: Received WebSocket message
I/flutter ( 8017): [2022-02-01 11:54:34.87] Level.debug websocket_interface.dart:174 ::: Received and ignored empty packet

How can we resolve this failure?

@cloudwebrtc
Copy link
Member

@jongerenchaos Is there any way to reproduce this error? I guess it's a typical issue, I'll be merging this PR within the next week, but before that, I need to do a full test so that the merge will work, it's a big PR after all.

@jongerenchaos
Copy link

jongerenchaos commented Feb 7, 2022

Yeps here are the steps that i try to do:

First i downloaded the full null safety source from and use the demo application:
https://github.com/viplifes/dart-sip-ua
I compile the android version and after starting the application i put some information in the account tab (with asterisk server information).

The first registration failed (same error as on the topic #132 ) and after this invalid registration i get the error above.

In the demo app without the null safety option the application will try to register again by himself and that registration is okey. I can make and receive calls.Without any reconfigurations on the asterisk application.
But with this new safety version it won't register again and i think the process stops.

@cloudwebrtc
Copy link
Member

@jongerenchaos I fixed this and you can test it out, so we can move this PR forward.

@jongerenchaos
Copy link

Tnx! It works without any problem!

@cloudwebrtc cloudwebrtc merged commit 9292f7f into flutter-webrtc:null-safety Feb 7, 2022
cloudwebrtc added a commit that referenced this pull request Feb 7, 2022
* update. * chore: format and import short. * Add extended header support (#232) * hangup add the options hangup function increase self-determination option number of participants, expedient unity communication time notification * fix: Fix breaking changes. * Add extended header support Add extended header support, in order to carry custom information when calling Co-authored-by: cloudwebrtc <duanweiwei1982@gmail.com> Co-authored-by: 趙金元 <choukg.zw@gmail.com> * migrate to null safety (#247) * migrate to null safety * fix local_seqnum * support null safety for test folder * fix: fix issue for digest authentication. * chore: fix lints. Co-authored-by: cloudwebrtc <duanweiwei1982@gmail.com> * update. Co-authored-by: zi6xuan <zi6xuan@gmail.com> Co-authored-by: 趙金元 <choukg.zw@gmail.com> Co-authored-by: viplifes <viplifes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants