Sip session timeout fix etc. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| LGTM |
This was referenced Dec 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
RTC.Session._runSessionTimer() was only firing the first time, as a result the sip session would expire at about 130 seconds.
Moved this._handleSessionTimersInIncomingResponse(response); above the return statement in RTCSession.dart @ line 2448 which now ensures that the Session Timer gets re-scheduled.
Also prevented handling of empty data packets in WebSocketInterface.dart _onMessage(data) which was causing parser errors.
Inferred types where relevant and possible.