Skip to content

TicTacToe demo cocos2dx functionality #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 12, 2020
Merged

TicTacToe demo cocos2dx functionality #46

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a1d7ea7
Changed database testapp to run Tic-Tac-Toe
Grant-Postma May 26, 2020
fe6b14f
Changing pointers alignment back
Grant-Postma May 27, 2020
a6e9567
Class and resource files required for cocos2dx
Grant-Postma May 28, 2020
441998b
Merge pull request #1 from Grant-Postma/cocos2dx-init
Grant-Postma May 28, 2020
1826d7d
Cocos basic functionality for placing sprites
Grant-Postma May 31, 2020
9d0c311
Reverting common_main TicTacToe changes
Grant-Postma May 31, 2020
eedf812
Clang-format corrections
Grant-Postma May 31, 2020
1777aff
Suggested changes from @alexames review
Grant-Postma Jun 1, 2020
12d03ce
Suggested changes from @DellaBitta.
Grant-Postma Jun 3, 2020
11aed62
freeing allocations and exiting on nullptrs
Grant-Postma Jun 4, 2020
7322220
AppDelagate free glview & director + return false
Grant-Postma Jun 4, 2020
5caac8a
Removing nullptr checks & pragma once statements
Grant-Postma Jun 5, 2020
2b8b2b9
Replacing pragma with header guards
Grant-Postma Jun 5, 2020
c6be411
adding header guards
Grant-Postma Jun 5, 2020
3ce4079
Moving touchListener Comment up; snake_case fix
Grant-Postma Jun 5, 2020
78775cf
Comment change for more professional readablity
Grant-Postma Jun 8, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clang-format corrections
  • Loading branch information
@Grant-Postma
Grant-Postma committed May 31, 2020
commit eedf812896ec2dd35695c41128c7d17ca8ae7936
1 change: 0 additions & 1 deletion database/testapp/src/common_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "firebase/future.h"
#include "firebase/util.h"


// Thin OS abstraction layer.
#include "main.h" // NOLINT

Expand Down
15 changes: 7 additions & 8 deletions demos/TicTacToe/Classes/AppDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@

#include "cocos2d.h"

class AppDelegate : private cocos2d::Application
{
public:
AppDelegate();
virtual ~AppDelegate();
class AppDelegate : private cocos2d::Application {
public:
AppDelegate();
virtual ~AppDelegate();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of virtual, use override.

https://en.cppreference.com/w/cpp/language/override

virtual bool applicationDidFinishLaunching();
virtual void applicationDidEnterBackground();
virtual void applicationWillEnterForeground();
virtual bool applicationDidFinishLaunching();
virtual void applicationDidEnterBackground();
virtual void applicationWillEnterForeground();
};
18 changes: 7 additions & 11 deletions demos/TicTacToe/Classes/TicTacToeScene.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,14 @@
#pragma once
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pragma once, use header guard:

https://google.github.io/styleguide/cppguide.html#The__define_Guard

#include "cocos2d.h"
#include <array>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need any of these in the header. None of them are needed for what is exposed in this header.
#include <iostream>
#include <cstdlib>
#include <iostream>

#include "cocos2d.h"


class TicTacToe : public cocos2d::Layer
{
public:
static cocos2d::Scene* createScene();
virtual bool init();
CREATE_FUNC(TicTacToe);


class TicTacToe : public cocos2d::Layer {
public:
static cocos2d::Scene* createScene();
virtual bool init();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

override
CREATE_FUNC(TicTacToe);
};