TicTacToe demo cocos2dx functionality #46
Conversation
Class and resource files required for cocos2dx
database/testapp/src/common_main.cc Outdated
| | ||
| #include <algorithm> | ||
| #include <ctime> | ||
| |
There was a problem hiding this comment.
Since you're not really touching this file, can you just revert this change completely?
| | ||
| const int kNumberOfTiles = 9; | ||
| const int kMaxMovesPerPlayer = 1 + kNumberOfTiles / 2; | ||
| const int kTilesX = std::sqrt(kNumberOfTiles); |
There was a problem hiding this comment.
I would do this the other way:
kTilesX = 3
kTilesY = 3
kNumberOfTiles = kTilesX * kTilesY;
| | ||
| USING_NS_CC; | ||
| | ||
| const int kNumberOfTiles = 9; |
| const double kTileWidth = (kScreenWidth / kTilesX); | ||
| const double kTileHeight = (kScreenHeight / kTilesY); | ||
| const int kNumberOfPlayers = 2; | ||
| std::array<std::string, kNumberOfPlayers> kMoveImageFileNames = { |
There was a problem hiding this comment.
We can't have std::strings as global variables according to the C++ style guide.
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
strings do dynamic allocation and then delete on destruction, which is against the style guide rules.
Instead either use const char* here, or make it a string* and initialize the value at startup.
| class AppDelegate : private cocos2d::Application { | ||
| public: | ||
| AppDelegate(); | ||
| virtual ~AppDelegate(); |
There was a problem hiding this comment.
Instead of virtual, use override.
| // kScreenWidth = Director::getInstance()->getWinSize().width; auto | ||
| // kScreenHeight = Director::getInstance()->getWinSize().height; | ||
| | ||
| auto board_sprite = Sprite::create("tic_tac_toe_board.png"); |
There was a problem hiding this comment.
Put "tic_tac_toe_board.png" in a constant
| board_sprite->setAnchorPoint(Vec2(0.0, 0.0)); | ||
| | ||
| auto touchListener = EventListenerTouchOneByOne::create(); | ||
| touchListener->onTouchBegan = [=](Touch* touch, |
There was a problem hiding this comment.
https://google.github.io/styleguide/cppguide.html#Lambda_expressions
Prefer explicit captures when the lambda will escape the current scope.
Only capture the variables you need in the lambda.
3 participants
No description provided.