Skip to content

Continue work on C++ packaging #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 22, 2020
Merged

Continue work on C++ packaging #97

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c2b4edc
After building packaging tools, upload them into an artifact so the r…
jonsimantov Jul 21, 2020
92cba25
Add basic iOS and Android build and prereq scripts, and run them
jonsimantov Jul 22, 2020
f3b7e0b
Fix indentation.
jonsimantov Jul 22, 2020
8e41f7d
Fix yaml syntax error.
jonsimantov Jul 22, 2020
31ddbbc
Add missing 'steps:' line.
jonsimantov Jul 22, 2020
430307e
Change naming of builds.
jonsimantov Jul 22, 2020
8f069d6
Rename builds again.
jonsimantov Jul 22, 2020
b86b304
Fix OS check.
jonsimantov Jul 22, 2020
376e640
Tweak prerequisites scripts.
jonsimantov Jul 22, 2020
0065051
Fixes to build
jonsimantov Jul 22, 2020
1966711
Removed tabs.
jonsimantov Jul 22, 2020
715d578
Hyphens not underscores.
jonsimantov Jul 22, 2020
4bf8cb8
Set ios build to use Xcode cmake generator.
jonsimantov Jul 22, 2020
141a615
Fix android prereqs and build command.
jonsimantov Jul 22, 2020
ed2dab0
Add python packages to prereqs install
jonsimantov Jul 22, 2020
82aa231
Fix CMake toolchain path.
jonsimantov Jul 22, 2020
f427975
Add platform checking. Windows will require a .bat file instead of th…
jonsimantov Jul 22, 2020
3288599
Fix binutils packaging.
jonsimantov Jul 22, 2020
41cb635
Add Android build artifact upload
jonsimantov Jul 22, 2020
9f37af9
Fix packaging artifacts.
jonsimantov Jul 22, 2020
206a7d8
Packaging script tweaks
jonsimantov Jul 22, 2020
3701cb3
Remove tabs.
jonsimantov Jul 22, 2020
77d1dda
Renamed nm-new to nm
jonsimantov Jul 22, 2020
4bc0f71
Moved artifacts back to .tgz files.
jonsimantov Jul 22, 2020
0b83581
Removed tabs again.
jonsimantov Jul 22, 2020
1053eea
Merge branch 'dev' into feature/cpp-packaging2
jonsimantov Jul 22, 2020
ada0df2
Some small workflow fixes.
jonsimantov Jul 22, 2020
d291b90
Merge branch 'dev' into feature/cpp-packaging2
jonsimantov Jul 22, 2020
6a53c9c
Merge branch 'dev' into feature/cpp-packaging2
jonsimantov Jul 22, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix indentation.
  • Loading branch information
@jonsimantov
jonsimantov committed Jul 22, 2020
commit f3b7e0b32c666d80f0252f6e3940f51b01bde3df
40 changes: 20 additions & 20 deletions .github/workflows/cpp-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,33 +56,33 @@ jobs:
architecture: [arm64, x86_64]
steps:
- name: fetch SDK
uses: actions/checkout@v2.3.1
with:
path: sdk-src
ref: ${{ github.event.inputs.commitId }}
uses: actions/checkout@v2.3.1
with:
path: sdk-src
ref: ${{ github.event.inputs.commitId }}
- name: install prerequisites
run: sdk-src/build_scripts/ios/install_prereqs.sh
run: sdk-src/build_scripts/ios/install_prereqs.sh
- name: build sdk
run |
build_scripts/ios/build.sh firebase-cpp-sdk-ios-${{ matrix.architecture }} sdk-src ${{ matrix.architecture }}
tar -cvzf firebase-cpp-sdk-ios-${{ matrix.architecture }}.tgz firebase-cpp-sdk-ios-${{ matrix.architecture }}
run |
build_scripts/ios/build.sh firebase-cpp-sdk-ios-${{ matrix.architecture }} sdk-src ${{ matrix.architecture }}
tar -cvzf firebase-cpp-sdk-ios-${{ matrix.architecture }}.tgz firebase-cpp-sdk-ios-${{ matrix.architecture }}
- name: upload artifacts
uses: actions/upload-artifact@v2
with:
name: firebase-cpp-sdk-ios-${{ matrix.architecture }}
path: firebase-cpp-sdk-ios-${{ matrix.architecture }}.tgz
uses: actions/upload-artifact@v2
with:
name: firebase-cpp-sdk-ios-${{ matrix.architecture }}
path: firebase-cpp-sdk-ios-${{ matrix.architecture }}.tgz
Copy link
Contributor

@vimanyu vimanyu Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By any chance, will we need a version number for these artifacts?
Copy link
Contributor Author

@jonsimantov jonsimantov Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK these artifacts are local to the workflow? So I don't think they need versioning. Later on in the workflow, all of these will be joined together into a single binary SDK artifact, and that will be versioned.
Copy link
Contributor

@DellaBitta DellaBitta Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can confirm - they're scoped by the workflow.

build_sdk_android:
name: build-sdk-android
runs-on: ubuntu-latest
- name: fetch SDK
uses: actions/checkout@v2.3.1
with:
path: sdk-src
ref: ${{ github.event.inputs.commitId }}
uses: actions/checkout@v2.3.1
with:
path: sdk-src
ref: ${{ github.event.inputs.commitId }}
- name: install prerequisites
run: sdk-src/build_scripts/android/install_prereqs.sh
run: sdk-src/build_scripts/android/install_prereqs.sh
- name: build sdk
run |
build_scripts/android/build.sh firebase-cpp-sdk-android sdk-src
tar -cvzf firebase-cpp-sdk-android.tgz firebase-cpp-sdk-android
run |
build_scripts/android/build.sh firebase-cpp-sdk-android sdk-src
tar -cvzf firebase-cpp-sdk-android.tgz firebase-cpp-sdk-android